[{"id":10989,"web_url":"https://patchwork.libcamera.org/comment/10989/","msgid":"<20200629205837.GU10681@pendragon.ideasonboard.com>","date":"2020-06-29T20:58:37","subject":"Re: [libcamera-devel] [PATCH 1/6] libcamera: formats: Add NV24 and\n\tNV42, and reorder NV formats","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Tue, Jun 30, 2020 at 12:14:06AM +0900, Paul Elder wrote:\n> Add formats for NV24 and NV42. While at it, reorder the NV formats so\n> that NV12 and NV21 come first, followed by NV16, NV61, NV24, and NV42.\n> \n> Signed-off-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/formats.cpp | 36 ++++++++++++++++++++++++++----------\n> 1 file changed, 26 insertions(+), 10 deletions(-)\n> \n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index 436672e..d3b722c 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -256,6 +256,22 @@ const std::map pixelFormatInfo{\n> \t} },\n> \n> \t/* YUV planar formats. */\n> +\t{ formats::NV12, {\n> +\t\t.name = \"NV12\",\n> +\t\t.format = formats::NV12,\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_NV12),\n> +\t\t.bitsPerPixel = 12,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +\t\t.packed = false,\n> +\t} },\n> +\t{ formats::NV21, {\n> +\t\t.name = \"NV21\",\n> +\t\t.format = formats::NV21,\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_NV21),\n> +\t\t.bitsPerPixel = 12,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +\t\t.packed = false,\n> +\t} },\n> \t{ formats::NV16, {\n> \t\t.name = \"NV16\",\n> \t\t.format = formats::NV16,\n> @@ -272,19 +288,19 @@ const std::map pixelFormatInfo{\n> \t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> \t\t.packed = false,\n> \t} },\n> -\t{ formats::NV12, {\n> -\t\t.name = \"NV12\",\n> -\t\t.format = formats::NV12,\n> -\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_NV12),\n> -\t\t.bitsPerPixel = 12,\n> +\t{ formats::NV24, {\n> +\t\t.name = \"NV24\",\n> +\t\t.format = formats::NV24,\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_NV24),\n> +\t\t.bitsPerPixel = 24,\n> \t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> \t\t.packed = false,\n> \t} },\n> -\t{ formats::NV21, {\n> -\t\t.name = \"NV21\",\n> -\t\t.format = formats::NV21,\n> -\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_NV21),\n> -\t\t.bitsPerPixel = 12,\n> +\t{ formats::NV42, {\n> +\t\t.name = \"NV42\",\n> +\t\t.format = formats::NV42,\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_NV42),\n> +\t\t.bitsPerPixel = 24,\n> \t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> \t\t.packed = false,\n> \t} },","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C0AD4BF415\n\tfor ;\n\tMon, 29 Jun 2020 20:58:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5CA58609DD;\n\tMon, 29 Jun 2020 22:58:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 21B3F603B2\n\tfor ;\n\tMon, 29 Jun 2020 22:58:41 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8F6FC299;\n\tMon, 29 Jun 2020 22:58:40 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LKDztCCG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593464320;\n\tbh=4u26ajiRsFILkV5mHXEpu16P6y8TzDDUWCgKyiEocK4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=LKDztCCG2Ilpy4gKragbrgzBsPO536V/r4bt941fGVwJAQQVdmU6TrJGDhZefgGrW\n\tSQcNbJs4T+1NlmBntDrKsZuGz1Mhy/8V9NMiQUtjQxNzwhacvfL27vsfBbzdLJMNs1\n\tA732dhJgTa/STJRwpQb2QnkCAqXgmIdQFAb73NN8=","Date":"Mon, 29 Jun 2020 23:58:37 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"<20200629205837.GU10681@pendragon.ideasonboard.com>","References":"<20200629151411.216477-1-paul.elder@ideasonboard.com>\n\t<20200629151411.216477-2-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200629151411.216477-2-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/6] libcamera: formats: Add NV24 and\n\tNV42, and reorder NV formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]