[{"id":10965,"web_url":"https://patchwork.libcamera.org/comment/10965/","msgid":"<20200629143150.GD1852218@oden.dyn.berto.se>","date":"2020-06-29T14:31:50","subject":"Re: [libcamera-devel] [PATCH v1 4/9] libcamera: pipeline:\n\traspberrypi: Constify parameter to StaggeredCtrl::set()","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2020-06-29 02:19:29 +0300, Laurent Pinchart wrote:\n> The controls parameter of StaggeredCtrl::set(), passed by reference, is\n> not modified by the function. Make it const.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp | 2 +-\n> src/libcamera/pipeline/raspberrypi/staggered_ctrl.h | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n> index 416cb9467147..0572acc93d63 100644\n> --- a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n> @@ -91,7 +91,7 @@ bool StaggeredCtrl::set(std::initializer_list\n> \treturn true;\n> }\n> \n> -bool StaggeredCtrl::set(ControlList &controls)\n> +bool StaggeredCtrl::set(const ControlList &controls)\n> {\n> \tstd::lock_guard lock(lock_);\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.h b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.h\n> index 98994a6177e1..382fa31a6853 100644\n> --- a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.h\n> +++ b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.h\n> @@ -41,7 +41,7 @@ public:\n> \n> \tbool set(uint32_t ctrl, int32_t value);\n> \tbool set(std::initializer_list> ctrlList);\n> -\tbool set(ControlList &controls);\n> +\tbool set(const ControlList &controls);\n> \n> \tint write();\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 781C1BFFE2\n\tfor ;\n\tMon, 29 Jun 2020 14:31:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4631B609D6;\n\tMon, 29 Jun 2020 16:31:53 +0200 (CEST)","from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 462D4603BB\n\tfor ;\n\tMon, 29 Jun 2020 16:31:52 +0200 (CEST)","by mail-lj1-x241.google.com with SMTP id b25so14670110ljp.6\n\tfor ;\n\tMon, 29 Jun 2020 07:31:52 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tf24sm12334ljk.125.2020.06.29.07.31.51\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 29 Jun 2020 07:31:51 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"l1sdUkVY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=Cy2NwEwzVtDZQZAKc1OfgJ1mEDz8Mqx19goA6lXE/cU=;\n\tb=l1sdUkVYR0Xkvqi4vmYtvC+QU7KXolEY9g4WDhgQb8s5TyQcqOkTOUxN3iYp9Q2V4Q\n\tWjsIKe1b2oGPZPG3kFjdMiZFuMCRdef1E+i3PpPbjMLF2iEdq30RLKVk0X/kcvNerRhZ\n\tY1BTryOxHWvjI1PYSSgpNwcBh7sYMoi6LM8w6TBRozEqrFS/H73lh2Fq6/oaR4goPlzg\n\t+hkmT1j+c6zLhyH4o9GzmcbJIbMtSphjX9ESC93PKNuwncRJVlBX6ozxw70c/uLzrVuL\n\tEMfeNND2k1kNr9j81dGssjYuvM+DMGR7XElJa+L8AOOxaab3VXvSDzuIep2NhtY74DI6\n\t6Orw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=Cy2NwEwzVtDZQZAKc1OfgJ1mEDz8Mqx19goA6lXE/cU=;\n\tb=l6BpbQb5TpUPHp+EnU6eug/nxxNsdLdTmIWeVhw5sycG4wf6w1tRD1uNifp7ZhFBir\n\tNNF2cpPrUOF9rBFQ4L2g8vk67mUVjfVV5+YLCK0COqYAPNFOq0Bq3zlQ5R78nRdN0nrc\n\tCDb4wKTH/Xqhju687cP7ElbVHlWcg2WqGtg8womkHeH2uDd0INEibqdQIeVXFXTiIJFL\n\trBzexL/zfouXuuZ3CGXTPyhUwxLvE55jpvFtZVx/wc8VEx86hhPGcTKKbOP5u8ECbdv7\n\tIm0OXwFh/FPRDDx3/EhmeCduM1Npwn22KRhH+xVBZbjVSXalHWmXtmuIBw1wlIggxI0x\n\tXjOA==","X-Gm-Message-State":"AOAM5312BLblPnJKeyCiY+/ixau9tTuI/6UJkFkrcY2MMMeq33qTTnQc\n\tvto6nSxAO6BEY1/nH5+xtQ7pEp3DWCY=","X-Google-Smtp-Source":"ABdhPJzfzmPpDB+qgmq/g55/UyJSP/5/JA5sfrCcDT6IjW/GZM/7ywdkKQRgGOAmLwfruhjHZsV70w==","X-Received":"by 2002:a2e:2f1e:: with SMTP id\n\tv30mr7939432ljv.202.1593441111664; \n\tMon, 29 Jun 2020 07:31:51 -0700 (PDT)","Date":"Mon, 29 Jun 2020 16:31:50 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"<20200629143150.GD1852218@oden.dyn.berto.se>","References":"<20200628231934.29025-1-laurent.pinchart@ideasonboard.com>\n\t<20200628231934.29025-5-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200628231934.29025-5-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v1 4/9] libcamera: pipeline:\n\traspberrypi: Constify parameter to StaggeredCtrl::set()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":10974,"web_url":"https://patchwork.libcamera.org/comment/10974/","msgid":"","date":"2020-06-29T16:58:01","subject":"Re: [libcamera-devel] [PATCH v1 4/9] libcamera: pipeline:\n\traspberrypi: Constify parameter to StaggeredCtrl::set()","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Laruent,\n\nThank you for the patch.\n\nOn Mon, 29 Jun 2020 at 15:31, Niklas Söderlund\n wrote:\n>\n> Hi Laurent,\n>\n> Thanks for your patch.\n>\n> On 2020-06-29 02:19:29 +0300, Laurent Pinchart wrote:\n> > The controls parameter of StaggeredCtrl::set(), passed by reference, is\n> > not modified by the function. Make it const.\n> >\n> > Signed-off-by: Laurent Pinchart \n>\n> Reviewed-by: Niklas Söderlund \n\nReviewed-by: Naushir Patuck \n\n>\n> > ---\n> > src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp | 2 +-\n> > src/libcamera/pipeline/raspberrypi/staggered_ctrl.h | 2 +-\n> > 2 files changed, 2 insertions(+), 2 deletions(-)\n> >\n> > diff --git a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n> > index 416cb9467147..0572acc93d63 100644\n> > --- a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n> > +++ b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n> > @@ -91,7 +91,7 @@ bool StaggeredCtrl::set(std::initializer_list\n> > return true;\n> > }\n> >\n> > -bool StaggeredCtrl::set(ControlList &controls)\n> > +bool StaggeredCtrl::set(const ControlList &controls)\n> > {\n> > std::lock_guard lock(lock_);\n> >\n> > diff --git a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.h b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.h\n> > index 98994a6177e1..382fa31a6853 100644\n> > --- a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.h\n> > +++ b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.h\n> > @@ -41,7 +41,7 @@ public:\n> >\n> > bool set(uint32_t ctrl, int32_t value);\n> > bool set(std::initializer_list> ctrlList);\n> > - bool set(ControlList &controls);\n> > + bool set(const ControlList &controls);\n> >\n> > int write();\n> >\n> > --\n> > Regards,\n> >\n> > Laurent Pinchart\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n>\n> --\n> Regards,\n> Niklas Söderlund\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E1E88BFFE2\n\tfor ;\n\tMon, 29 Jun 2020 16:58:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7729A609D6;\n\tMon, 29 Jun 2020 18:58:21 +0200 (CEST)","from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 48113603B2\n\tfor ;\n\tMon, 29 Jun 2020 18:58:19 +0200 (CEST)","by mail-lj1-x241.google.com with SMTP id 9so18846638ljc.8\n\tfor ;\n\tMon, 29 Jun 2020 09:58:19 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"bC4LTL98\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=OgHnLbr2gpWQGtFuiW8pZLJV1Twkj8GrUwk9Li0/NFc=;\n\tb=bC4LTL98g7FsEKhA9alq3jdVDFpBIr07EDOZNoJ1QLiWIxJ1MTp9QkwAcCAHnSjB5K\n\tSJj81NYwstFkILriwA4jAOlnEPIChGS1nwBh2p2+zQYfHOhxfU6/eKyMNiKvbNqtCTD/\n\td5+vgAu6P9g199nFQ1tAViT4aEyxtWF/Wt7S+42/OwUqt80EEOEzIQobpCWKr4aAghNO\n\tQ13F8nLIKyQN//3x3GuNY2/IfFbdP0KmfzwtseTgr4uSpNmxhRH+ROJA036B6H16Gf0U\n\tJiX+47oHuVFq0awp4cqwwm5a9bzu0Bj1JfigLkk6HjS/mMQserp5DNC2LPmobw+ZkG2H\n\t1mvw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=OgHnLbr2gpWQGtFuiW8pZLJV1Twkj8GrUwk9Li0/NFc=;\n\tb=ONb8yxGE6MPgi+SiEhSuFQ+JJWrm5AKCWwXde6ekI0cW2ZBdw9eZAB4MyhIlAWys64\n\tl9si9o4vEfJWX3Zods+lRBIAfP+GClsuX+RMUQvP38H84qTrNHwo3WIH9k1VqJWwgpb8\n\tB/bVS/vk3sZmpHiKr0wZ9ezMb/A4lTEfsRPX4TEuJa5haQ63EvkL00E6xdXl4ZlLuhNg\n\tXJBVW9GiRxUxNm2kbuM9uG8ZuVR9YZttvejyl6sTfLSOIa/DMDFSGPgR/2hTtT8CRs2O\n\tGSsj/ToBEmFprLHXwz8fQsc5MHs6yfq76blDpjJLZsGHO5QPvQvIgl+wAj+9TCj3kQ3b\n\tCuRg==","X-Gm-Message-State":"AOAM531CAEFSHdcqCB8DFcM/oq/1WsTVL6qJTqfI+gZj7U8jRUZz7+UG\n\th5IEJryDBkqKVoLXwfgyUyCK1IO1AiGdRbToBkunTg==","X-Google-Smtp-Source":"ABdhPJxC5lejQFMl854jUVUd7m8gt5Sepz4VlaUdeam8fr1zHdyRhSaNlK2eRjVvxklSj8rdZhYwXaJ5oUDEA7UEqiM=","X-Received":"by 2002:a2e:3a04:: with SMTP id h4mr8745619lja.103.1593449898581;\n\tMon, 29 Jun 2020 09:58:18 -0700 (PDT)","MIME-Version":"1.0","References":"<20200628231934.29025-1-laurent.pinchart@ideasonboard.com>\n\t<20200628231934.29025-5-laurent.pinchart@ideasonboard.com>\n\t<20200629143150.GD1852218@oden.dyn.berto.se>","In-Reply-To":"<20200629143150.GD1852218@oden.dyn.berto.se>","From":"Naushir Patuck ","Date":"Mon, 29 Jun 2020 17:58:01 +0100","Message-ID":"","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","Subject":"Re: [libcamera-devel] [PATCH v1 4/9] libcamera: pipeline:\n\traspberrypi: Constify parameter to StaggeredCtrl::set()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11007,"web_url":"https://patchwork.libcamera.org/comment/11007/","msgid":"<20200630103528.flsgn5nfxexylnlb@uno.localdomain>","date":"2020-06-30T10:35:28","subject":"Re: [libcamera-devel] [PATCH v1 4/9] libcamera: pipeline:\n\traspberrypi: Constify parameter to StaggeredCtrl::set()","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent\n\nOn Mon, Jun 29, 2020 at 02:19:29AM +0300, Laurent Pinchart wrote:\n> The controls parameter of StaggeredCtrl::set(), passed by reference, is\n> not modified by the function. Make it const.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n> ---\n> src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp | 2 +-\n> src/libcamera/pipeline/raspberrypi/staggered_ctrl.h | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n> index 416cb9467147..0572acc93d63 100644\n> --- a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n> @@ -91,7 +91,7 @@ bool StaggeredCtrl::set(std::initializer_list\n> \treturn true;\n> }\n>\n> -bool StaggeredCtrl::set(ControlList &controls)\n> +bool StaggeredCtrl::set(const ControlList &controls)\n> {\n> \tstd::lock_guard lock(lock_);\n>\n> diff --git a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.h b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.h\n> index 98994a6177e1..382fa31a6853 100644\n> --- a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.h\n> +++ b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.h\n> @@ -41,7 +41,7 @@ public:\n>\n> \tbool set(uint32_t ctrl, int32_t value);\n> \tbool set(std::initializer_list> ctrlList);\n> -\tbool set(ControlList &controls);\n> +\tbool set(const ControlList &controls);\n>\n> \tint write();\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5A584BFFE2\n\tfor ;\n\tTue, 30 Jun 2020 10:32:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 310A160C53;\n\tTue, 30 Jun 2020 12:32:01 +0200 (CEST)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5E8F8609C7\n\tfor ;\n\tTue, 30 Jun 2020 12:31:59 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id D96C81C000E;\n\tTue, 30 Jun 2020 10:31:58 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Tue, 30 Jun 2020 12:35:28 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20200630103528.flsgn5nfxexylnlb@uno.localdomain>","References":"<20200628231934.29025-1-laurent.pinchart@ideasonboard.com>\n\t<20200628231934.29025-5-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200628231934.29025-5-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v1 4/9] libcamera: pipeline:\n\traspberrypi: Constify parameter to StaggeredCtrl::set()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]