{"id":8488,"url":"https://patchwork.libcamera.org/api/patches/8488/?format=json","web_url":"https://patchwork.libcamera.org/patch/8488/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200628231934.29025-5-laurent.pinchart@ideasonboard.com>","date":"2020-06-28T23:19:29","name":"[libcamera-devel,v1,4/9] libcamera: pipeline: raspberrypi: Constify parameter to StaggeredCtrl::set()","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"69159293bbd594c2b8d8d2ccbbf2fa6955388cda","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8488/mbox/","series":[{"id":1054,"url":"https://patchwork.libcamera.org/api/series/1054/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1054","date":"2020-06-28T23:19:25","name":"Support passing custom data to IPA configure()","version":1,"mbox":"https://patchwork.libcamera.org/series/1054/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8488/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8488/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5DDE7C2E66\n\tfor ;\n\tSun, 28 Jun 2020 23:19:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ED3C260AF7;\n\tMon, 29 Jun 2020 01:19:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C11C0609C9\n\tfor ;\n\tMon, 29 Jun 2020 01:19:42 +0200 (CEST)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 53BD29DA;\n\tMon, 29 Jun 2020 01:19:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aw4rzMni\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593386382;\n\tbh=tmEt+A7Se7qLan6i4z3XNJKVwbzk+X8q7l7tJ79gNgM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=aw4rzMniX5K+WDbTZSJlqaGRxZ7RvN18b8JLy3I6KnO2LAnWarSms7QNiqmKNvcqV\n\tkgDSfiEDLkiJnLF8C1Y4HAbgtusRy9Z0RRb7nNnmg8spEEzXb2Uz45QwoPXL/amSU8\n\tbxEiJoTFtYkkqSUj3U+cTLtFL41qJMCTzvc4fMaA=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 29 Jun 2020 02:19:29 +0300","Message-Id":"<20200628231934.29025-5-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200628231934.29025-1-laurent.pinchart@ideasonboard.com>","References":"<20200628231934.29025-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v1 4/9] libcamera: pipeline: raspberrypi:\n\tConstify parameter to StaggeredCtrl::set()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The controls parameter of StaggeredCtrl::set(), passed by reference, is\nnot modified by the function. Make it const.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp | 2 +-\n src/libcamera/pipeline/raspberrypi/staggered_ctrl.h | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\nindex 416cb9467147..0572acc93d63 100644\n--- a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n@@ -91,7 +91,7 @@ bool StaggeredCtrl::set(std::initializer_list\n \treturn true;\n }\n \n-bool StaggeredCtrl::set(ControlList &controls)\n+bool StaggeredCtrl::set(const ControlList &controls)\n {\n \tstd::lock_guard lock(lock_);\n \ndiff --git a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.h b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.h\nindex 98994a6177e1..382fa31a6853 100644\n--- a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.h\n+++ b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.h\n@@ -41,7 +41,7 @@ public:\n \n \tbool set(uint32_t ctrl, int32_t value);\n \tbool set(std::initializer_list> ctrlList);\n-\tbool set(ControlList &controls);\n+\tbool set(const ControlList &controls);\n \n \tint write();\n \n","prefixes":["libcamera-devel","v1","4/9"]}