[{"id":10963,"web_url":"https://patchwork.libcamera.org/comment/10963/","msgid":"<20200629142521.GB1852218@oden.dyn.berto.se>","date":"2020-06-29T14:25:21","subject":"Re: [libcamera-devel] [PATCH v1 2/9] libcamera:\n\tipa_context_wrapper: Fix bad copy&paste in comment","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2020-06-29 02:19:27 +0300, Laurent Pinchart wrote:\n> A comment copied from the IPAInterfaceWrapper incorrectly mentions the\n> IPAInterfaceWrapper class instead of the IPAContextWrapper class. Fix\n> it.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/ipa_context_wrapper.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/ipa_context_wrapper.cpp b/src/libcamera/ipa_context_wrapper.cpp\n> index 054aa6ba2089..471118f57cdc 100644\n> --- a/src/libcamera/ipa_context_wrapper.cpp\n> +++ b/src/libcamera/ipa_context_wrapper.cpp\n> @@ -283,7 +283,7 @@ void IPAContextWrapper::queue_frame_action(void *ctx, unsigned int frame,\n> #ifndef __DOXYGEN__\n> /*\n> * This construct confuses Doxygen and makes it believe that all members of the\n> - * operations is a member of IPAInterfaceWrapper. It must thus be hidden.\n> + * operations is a member of IPAContextWrapper. It must thus be hidden.\n> */\n> const struct ipa_callback_ops IPAContextWrapper::callbacks_ = {\n> \t.queue_frame_action = &IPAContextWrapper::queue_frame_action,\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 495BEBF415\n\tfor ;\n\tMon, 29 Jun 2020 14:25:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1679C609D6;\n\tMon, 29 Jun 2020 16:25:25 +0200 (CEST)","from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 54B60603BB\n\tfor ;\n\tMon, 29 Jun 2020 16:25:23 +0200 (CEST)","by mail-lf1-x143.google.com with SMTP id g139so9172400lfd.10\n\tfor ;\n\tMon, 29 Jun 2020 07:25:23 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\ty26sm14587ljm.46.2020.06.29.07.25.22\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 29 Jun 2020 07:25:22 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"Du5puIDh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=41UEX63Lh3y8idSF6BrjBnFPPqbdyfuMuGWeYhIEDTQ=;\n\tb=Du5puIDhEQNxRa3so1ZyBUsrOiFztENpqZjRJNbyHRp5S/gl8GVVwF2malwM03ao1v\n\tXaNE/S6Qw63pzeQGj5Scb7rcCzBfnLOoVIdYbCpbzcLmy4pn43Zhxka9DkNqs9EZynMz\n\tL2DrM6HTNMB8Ae6RWNqTL/MR+aYKOFDXTxh8+7stYzAqteo7WE2p/tmRX/u2SFQVsCz4\n\t6f5QdA8WC0P1bT3+eB1/45uXCHbrpVsBflWZXcM3wtwGr9UZIDn8/gUDSrnT7qFHoG5W\n\tkuac2ASR85ISNQJx0Il1Fn4W7ISWcjTKicYssfurKgV+GOzRNhJDKo3CwjqRgpGBwk09\n\teUwg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=41UEX63Lh3y8idSF6BrjBnFPPqbdyfuMuGWeYhIEDTQ=;\n\tb=s54tOazV022p0M7GwKarDQcZRTFdNKS2/xrZoueGk8CLCxX6loY7hCzZzpTdPSNYu0\n\tSTkSkEjfzE7kLzuTyu4VupE6A66B4v5Ten0H3//4hSbJFPIymKy2qat/3ZUgsiqbnrve\n\tFmeh41Dq8+ppinI368HN/t448zrZNgmSBW0EJFiJjUayXE24bAyl0Ccg02FlISnHmAjh\n\tE0fvPkJvWvEyqYAjVU6EuUM8bWHJJ09CLAKA2Sw/2aCnv+GTn2NqGcVsrGeuAin4KmAu\n\tASR/0OStMEyRH5gN871FNdam/Piqaqr6mayYov/kW0zPx0iablB4HrLLVm9FhVCu2iKR\n\tVDow==","X-Gm-Message-State":"AOAM530zZiGRikwKOOvk08dKKNfUMpd+9EIzQjaHeMXhx6SGNOUlwO7/\n\tWehNf5N2nsTZevBm+h4v/EqlpDxdOVs=","X-Google-Smtp-Source":"ABdhPJyry7a8sn92YVZf+08A2oYRb1MheKuSB1wyrQZfOA2/M22pycAy5X8dshHWh6fgx7jxBKPESQ==","X-Received":"by 2002:a19:8055:: with SMTP id\n\tb82mr9319795lfd.178.1593440722668; \n\tMon, 29 Jun 2020 07:25:22 -0700 (PDT)","Date":"Mon, 29 Jun 2020 16:25:21 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"<20200629142521.GB1852218@oden.dyn.berto.se>","References":"<20200628231934.29025-1-laurent.pinchart@ideasonboard.com>\n\t<20200628231934.29025-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200628231934.29025-3-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v1 2/9] libcamera:\n\tipa_context_wrapper: Fix bad copy&paste in comment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11005,"web_url":"https://patchwork.libcamera.org/comment/11005/","msgid":"<20200630102640.zdneaddb4tfg6itu@uno.localdomain>","date":"2020-06-30T10:26:40","subject":"Re: [libcamera-devel] [PATCH v1 2/9] libcamera:\n\tipa_context_wrapper: Fix bad copy&paste in comment","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi LAurent\n\nOn Mon, Jun 29, 2020 at 04:25:21PM +0200, Niklas Söderlund wrote:\n> Hi Laurent,\n>\n> Thanks for your patch.\n>\n> On 2020-06-29 02:19:27 +0300, Laurent Pinchart wrote:\n> > A comment copied from the IPAInterfaceWrapper incorrectly mentions the\n> > IPAInterfaceWrapper class instead of the IPAContextWrapper class. Fix\n> > it.\n> >\n> > Signed-off-by: Laurent Pinchart \n>\n> Reviewed-by: Niklas Söderlund \n>\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> > ---\n> > src/libcamera/ipa_context_wrapper.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/src/libcamera/ipa_context_wrapper.cpp b/src/libcamera/ipa_context_wrapper.cpp\n> > index 054aa6ba2089..471118f57cdc 100644\n> > --- a/src/libcamera/ipa_context_wrapper.cpp\n> > +++ b/src/libcamera/ipa_context_wrapper.cpp\n> > @@ -283,7 +283,7 @@ void IPAContextWrapper::queue_frame_action(void *ctx, unsigned int frame,\n> > #ifndef __DOXYGEN__\n> > /*\n> > * This construct confuses Doxygen and makes it believe that all members of the\n> > - * operations is a member of IPAInterfaceWrapper. It must thus be hidden.\n> > + * operations is a member of IPAContextWrapper. It must thus be hidden.\n> > */\n> > const struct ipa_callback_ops IPAContextWrapper::callbacks_ = {\n> > \t.queue_frame_action = &IPAContextWrapper::queue_frame_action,\n> > --\n> > Regards,\n> >\n> > Laurent Pinchart\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n>\n> --\n> Regards,\n> Niklas Söderlund\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EF3C1BF415\n\tfor ;\n\tTue, 30 Jun 2020 10:23:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C76A360C57;\n\tTue, 30 Jun 2020 12:23:12 +0200 (CEST)","from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C280C609C5\n\tfor ;\n\tTue, 30 Jun 2020 12:23:11 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 1D5341BF208;\n\tTue, 30 Jun 2020 10:23:10 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Tue, 30 Jun 2020 12:26:40 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200630102640.zdneaddb4tfg6itu@uno.localdomain>","References":"<20200628231934.29025-1-laurent.pinchart@ideasonboard.com>\n\t<20200628231934.29025-3-laurent.pinchart@ideasonboard.com>\n\t<20200629142521.GB1852218@oden.dyn.berto.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200629142521.GB1852218@oden.dyn.berto.se>","Subject":"Re: [libcamera-devel] [PATCH v1 2/9] libcamera:\n\tipa_context_wrapper: Fix bad copy&paste in comment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]