[{"id":10962,"web_url":"https://patchwork.libcamera.org/comment/10962/","msgid":"<20200629142439.GA1852218@oden.dyn.berto.se>","date":"2020-06-29T14:24:39","subject":"Re: [libcamera-devel] [PATCH v1 1/9] libcamera: ipa: Document the\n\tparameters of the IPA C configure function","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-06-29 02:19:26 +0300, Laurent Pinchart wrote:\n> The parameters to the configure() function part of the ipa_context_ops\n> are not documented. Fix that.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/ipa_interface.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/src/libcamera/ipa_interface.cpp b/src/libcamera/ipa_interface.cpp\n> index 69835e63ab46..ebe47e1233a5 100644\n> --- a/src/libcamera/ipa_interface.cpp\n> +++ b/src/libcamera/ipa_interface.cpp\n> @@ -340,6 +340,11 @@\n> * \\var ipa_context_ops::configure\n> * \\brief Configure the IPA stream and sensor settings\n> * \\param[in] ctx The IPA context\n> + * \\param[in] sensor_info Camera sensor information\n> + * \\param[in] streams Configuration of all active streams\n> + * \\param[in] num_streams The number of entries in the \\a streams array\n> + * \\param[in] maps Controls provided by the pipeline entities\n> + * \\param[in] num_maps The number of entries in the \\a maps array\n> *\n> * \\sa libcamera::IPAInterface::configure()\n> */\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C3B2FBF415\n\tfor ;\n\tMon, 29 Jun 2020 14:24:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 255C8609DB;\n\tMon, 29 Jun 2020 16:24:43 +0200 (CEST)","from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A2040603BB\n\tfor ;\n\tMon, 29 Jun 2020 16:24:41 +0200 (CEST)","by mail-lj1-x241.google.com with SMTP id s9so18200057ljm.11\n\tfor ;\n\tMon, 29 Jun 2020 07:24:41 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id f5sm12508ljc.99.2020.06.29.07.24.39\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 29 Jun 2020 07:24:39 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"Skoeip/t\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=pV17+MqsTwM+bG+GwQAU/sXl1e/1m1qEw7jo/WdBYG0=;\n\tb=Skoeip/thR9gzKrxTFVe4oLaCFLkTPQUjONt5WcdVoUKGnbStRiFM3J5MxtDn/2aOQ\n\tKnArPyZZzXOTB4jiaNAoWXX8Q3bAghP54MA2Rhl5MwAO1RIP6Fmw/q/63nX7214IJzvY\n\tJQg8UigTY69H2bIkhVySC/uAobfPzOlpmiptFfBP66EcrjXVIeM3ALxmIWuZsdmiP46X\n\t6NgNdag3txBef/ludNiWig0UJJEfPU9aBTs2yKK6jovQ1Nw8NNCBhvZVS0nGnTZCtOTl\n\tmrtVluKXDLhuo5+8j7dmGmQAxvT6WYp8BXafR0zOAk4+5L535mwg80Uwl4VSNkCrgzU5\n\tlQEg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=pV17+MqsTwM+bG+GwQAU/sXl1e/1m1qEw7jo/WdBYG0=;\n\tb=UiRs3C+dpFceIbAhUas0cUf1K+6Isem89coPES91SoAUS7uPo1XrfBWGkKYmFE0jSY\n\tCf5dujsQqFezAO7CEVdSRv9ufwEqerOiv7O9M4cpf3v9wJoSqy0VYgb90OT/HIlG2E0x\n\t5qD5Oi/R5tHqNFmfDFCQTFsxtQdnJmqVJzgOzGUqVgtlfOoBK9z0qPqHVMjMlCho4ZVh\n\tudHCzyRfeddFfEccPhlV6g3lSsR2sF823nq6q/mnIoG7MsrgjB6L7EowBbVQQuNYRqRb\n\t8geKhkDVb5DWyh5BrGjIiYG33uSoTpE18bWYrh/HPfqypIaCVKrg64yGs+sjBrKbKdv7\n\t5ylg==","X-Gm-Message-State":"AOAM531qVUe5bY+8nmuXY6OQ2y9A0nLDhLhrs+gBbi7x5RAfhvuFCsZ5\n\tTDOOppWKd0oFDf2NcrdrNQeKprpCews=","X-Google-Smtp-Source":"ABdhPJxybEJfW4lVhS6ZAUna3MWsNlSqgTjX4VfuWMo/L34MRaxRiFNBpxvIl26AT0pHUEDBuJTGKQ==","X-Received":"by 2002:a2e:730c:: with SMTP id\n\to12mr2504095ljc.165.1593440680687; \n\tMon, 29 Jun 2020 07:24:40 -0700 (PDT)","Date":"Mon, 29 Jun 2020 16:24:39 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"<20200629142439.GA1852218@oden.dyn.berto.se>","References":"<20200628231934.29025-1-laurent.pinchart@ideasonboard.com>\n\t<20200628231934.29025-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200628231934.29025-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v1 1/9] libcamera: ipa: Document the\n\tparameters of the IPA C configure function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11004,"web_url":"https://patchwork.libcamera.org/comment/11004/","msgid":"<20200630102522.ieurh4wx6w4jgsvc@uno.localdomain>","date":"2020-06-30T10:25:22","subject":"Re: [libcamera-devel] [PATCH v1 1/9] libcamera: ipa: Document the\n\tparameters of the IPA C configure function","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Mon, Jun 29, 2020 at 02:19:26AM +0300, Laurent Pinchart wrote:\n> The parameters to the configure() function part of the ipa_context_ops\n> are not documented. Fix that.\n>\n> Signed-off-by: Laurent Pinchart \n\nNo warning from doxygen, so I guess this part is not parsed.\nAssuming that's intended\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n> ---\n> src/libcamera/ipa_interface.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n>\n> diff --git a/src/libcamera/ipa_interface.cpp b/src/libcamera/ipa_interface.cpp\n> index 69835e63ab46..ebe47e1233a5 100644\n> --- a/src/libcamera/ipa_interface.cpp\n> +++ b/src/libcamera/ipa_interface.cpp\n> @@ -340,6 +340,11 @@\n> * \\var ipa_context_ops::configure\n> * \\brief Configure the IPA stream and sensor settings\n> * \\param[in] ctx The IPA context\n> + * \\param[in] sensor_info Camera sensor information\n> + * \\param[in] streams Configuration of all active streams\n> + * \\param[in] num_streams The number of entries in the \\a streams array\n> + * \\param[in] maps Controls provided by the pipeline entities\n> + * \\param[in] num_maps The number of entries in the \\a maps array\n> *\n> * \\sa libcamera::IPAInterface::configure()\n> */\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8919DBFFE2\n\tfor ;\n\tTue, 30 Jun 2020 10:21:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0DE6160C56;\n\tTue, 30 Jun 2020 12:21:56 +0200 (CEST)","from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 508B4609C5\n\tfor ;\n\tTue, 30 Jun 2020 12:21:54 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 9E8BD1BF213;\n\tTue, 30 Jun 2020 10:21:53 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Tue, 30 Jun 2020 12:25:22 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20200630102522.ieurh4wx6w4jgsvc@uno.localdomain>","References":"<20200628231934.29025-1-laurent.pinchart@ideasonboard.com>\n\t<20200628231934.29025-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200628231934.29025-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v1 1/9] libcamera: ipa: Document the\n\tparameters of the IPA C configure function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]