[{"id":10941,"web_url":"https://patchwork.libcamera.org/comment/10941/","msgid":"<20200628191143.GU6954@pendragon.ideasonboard.com>","date":"2020-06-28T19:11:43","subject":"Re: [libcamera-devel] [PATCH v3 2/2] libcamera: ipu3: cio2: Use\n\tSize::isNull()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Sun, Jun 28, 2020 at 09:09:20PM +0200, Niklas Söderlund wrote:\n> Use the Size::isNull() helper instead of using local code.\n> \n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/ipu3/cio2.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/cio2.cpp b/src/libcamera/pipeline/ipu3/cio2.cpp\n> index 885e2ca0d9677364..aa1459fb3599283b 100644\n> --- a/src/libcamera/pipeline/ipu3/cio2.cpp\n> +++ b/src/libcamera/pipeline/ipu3/cio2.cpp\n> @@ -185,7 +185,7 @@ CIO2Device::generateConfiguration(Size size) const\n> \tStreamConfiguration cfg;\n> \n> \t/* If no desired size use the sensor resolution. */\n> -\tif (!size.width && !size.height)\n> +\tif (size.isNull())\n> \t\tsize = sensor_->resolution();\n> \n> \t/* Query the sensor static information for closest match. */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 39AC7C2E69\n\tfor ;\n\tSun, 28 Jun 2020 19:11:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A54CC609D6;\n\tSun, 28 Jun 2020 21:11:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 99D49603B5\n\tfor ;\n\tSun, 28 Jun 2020 21:11:48 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A64B34FB;\n\tSun, 28 Jun 2020 21:11:47 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GoOIX4e0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593371508;\n\tbh=5UMhXFw+Li1GY6VYKA79GjLmcrnjJOxKLuCjWQ9NGz8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GoOIX4e0duWBsBPoFSUPbF6m9tNcp3gSO9RM6ZXigcLc/7UQvsu7s7dKizKpgRI5k\n\ttOisjX+dBg6xrqsT8zMD7qt+AZD52BtoKqiK2OutAV8Mn8zfg73/21vxe7Mtn9EY66\n\t+kTHRa7jIFQ2PW24QXK10JqCRZ4+TNyLdMl3JCUs=","Date":"Sun, 28 Jun 2020 22:11:43 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200628191143.GU6954@pendragon.ideasonboard.com>","References":"<20200628190920.3206340-1-niklas.soderlund@ragnatech.se>\n\t<20200628190920.3206340-3-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200628190920.3206340-3-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v3 2/2] libcamera: ipu3: cio2: Use\n\tSize::isNull()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":10951,"web_url":"https://patchwork.libcamera.org/comment/10951/","msgid":"<20200629073242.6pu76bmkg2plx5ag@uno.localdomain>","date":"2020-06-29T07:34:09","subject":"Re: [libcamera-devel] [PATCH v3 2/2] libcamera: ipu3: cio2: Use\n\tSize::isNull()","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Sun, Jun 28, 2020 at 09:09:20PM +0200, Niklas Söderlund wrote:\n> Use the Size::isNull() helper instead of using local code.\n>\n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n> ---\n> src/libcamera/pipeline/ipu3/cio2.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/pipeline/ipu3/cio2.cpp b/src/libcamera/pipeline/ipu3/cio2.cpp\n> index 885e2ca0d9677364..aa1459fb3599283b 100644\n> --- a/src/libcamera/pipeline/ipu3/cio2.cpp\n> +++ b/src/libcamera/pipeline/ipu3/cio2.cpp\n> @@ -185,7 +185,7 @@ CIO2Device::generateConfiguration(Size size) const\n> \tStreamConfiguration cfg;\n>\n> \t/* If no desired size use the sensor resolution. */\n> -\tif (!size.width && !size.height)\n> +\tif (size.isNull())\n> \t\tsize = sensor_->resolution();\n>\n> \t/* Query the sensor static information for closest match. */\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6A12DC2E66\n\tfor ;\n\tMon, 29 Jun 2020 07:30:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E4445609C9;\n\tMon, 29 Jun 2020 09:30:42 +0200 (CEST)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8EEBD603BB\n\tfor ;\n\tMon, 29 Jun 2020 09:30:41 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 136101C0005;\n\tMon, 29 Jun 2020 07:30:40 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Mon, 29 Jun 2020 09:34:09 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200629073242.6pu76bmkg2plx5ag@uno.localdomain>","References":"<20200628190920.3206340-1-niklas.soderlund@ragnatech.se>\n\t<20200628190920.3206340-3-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200628190920.3206340-3-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v3 2/2] libcamera: ipu3: cio2: Use\n\tSize::isNull()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]