[{"id":10939,"web_url":"https://patchwork.libcamera.org/comment/10939/","msgid":"<20200628183112.GO1105424@oden.dyn.berto.se>","date":"2020-06-28T18:31:12","subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: raspberrypi: Fail on\n\tunsupported stream role","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2020-06-28 18:17:22 +0200, Jacopo Mondi wrote:\n> When an unsupported stream roles is requested to\n> generateConfiguration(), the function shall fail instead of simply\n> ignoring the request.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index d1338b640e3c..aa7b7eb93aab 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -568,7 +568,8 @@ CameraConfiguration *PipelineHandlerRPi::generateConfiguration(Camera *camera,\n> \t\tdefault:\n> \t\t\tLOG(RPI, Error) << \"Requested stream role not supported: \"\n> \t\t\t\t\t<< role;\n> -\t\t\tbreak;\n> +\t\t\tdelete config;\n> +\t\t\treturn nullptr;\n> \t\t}\n> \n> \t\tif (rawCount > 1 || outCount > 2) {\n> -- \n> 2.27.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 208D9C2E69\n\tfor ;\n\tSun, 28 Jun 2020 18:31:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E4765609D6;\n\tSun, 28 Jun 2020 20:31:15 +0200 (CEST)","from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5A3DF603B5\n\tfor ;\n\tSun, 28 Jun 2020 20:31:14 +0200 (CEST)","by mail-lj1-x243.google.com with SMTP id n24so15619513lji.10\n\tfor ;\n\tSun, 28 Jun 2020 11:31:14 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tt4sm8552033lfp.21.2020.06.28.11.31.12\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 28 Jun 2020 11:31:12 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"RSZK0F3y\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=+I+dJpETPJZ2/gPHgbQWVHoFiEBurAfSrQSW4kDd/Uw=;\n\tb=RSZK0F3ytacHKUiokw4vKvlwGDTlTzxRfhxHmtvTNl0paKxirX1VCFeYTDdZYLRCkU\n\tl6OMpvtYOjdxIWAlof+B/zasc8XFSogsSQLCDRmQchF19TUjKnvHQGh1B1CYQv5Ampho\n\tyUOros21JLwRdGQwKvYRvfxV1wP7HVI1BUY6Mn6CeqYPKEJ9wfmwe25KFhKXVOx2iQEW\n\t/Tr29qaRJ3Y4LH2VC20tVvpbQyPAU4bVhqDLs7y28w/IEvGZQsUXVg0ttzjRtpvjRF48\n\tSp9JXSDx058S1e6dMVqUfbxIdZUbUgt7ar3KWJYFrKMy2f+24gO8RVuAfkGa8f9uJ6FG\n\tSTlA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=+I+dJpETPJZ2/gPHgbQWVHoFiEBurAfSrQSW4kDd/Uw=;\n\tb=TrZvWtHPXRB99D3oZ+WU6VJnCkgIqMiIh5W5gXEJztCvdZC1a9xZ8VXvxhA3HZR5jG\n\t2u7mAIkbBa7c4w7k3NkeVQNvggoykK+0hYCiW0lYmmz7FoPK96WoJXFx3DjeOJZ0quJB\n\tBcFESCIM3hR7gI8oHvaxpkOI4nIVhTZPWoYq0VIJlN969j1uXyK4I8JM5ELxYl0gh63v\n\tpRx/Roio+xkLIVILDPzrtCWsvBhX8hXhzp9zfu/b5KMzJH1x35KD9i3P+X7kZSV5Sqc8\n\tc1zIyoiEsncRNJCd4NzfVw76Rn9hciYRYrGDE7mnfj8cpSZVvCF+JE8ZIYGDlu5TpAuw\n\tVqmg==","X-Gm-Message-State":"AOAM533cfP6CBGwUiteZrhea5RowR2vfMc7/I3pRTiPwz6uLo2dRopY+\n\tfwoa84uLf5zFQfARJT2v8bojww==","X-Google-Smtp-Source":"ABdhPJxmY7HTPcPHWa0B/1vEnolUGbEuMto770Vp5imQoMDr2D8Aeq5d3bnfoexQ2C7tBVTf87gcPQ==","X-Received":"by 2002:a2e:9d48:: with SMTP id y8mr6286373ljj.419.1593369073736;\n\tSun, 28 Jun 2020 11:31:13 -0700 (PDT)","Date":"Sun, 28 Jun 2020 20:31:12 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"<20200628183112.GO1105424@oden.dyn.berto.se>","References":"<20200628161723.30625-1-jacopo@jmondi.org>\n\t<20200628161723.30625-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200628161723.30625-3-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: raspberrypi: Fail on\n\tunsupported stream role","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":10947,"web_url":"https://patchwork.libcamera.org/comment/10947/","msgid":"<20200628232952.GD6954@pendragon.ideasonboard.com>","date":"2020-06-28T23:29:52","subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: raspberrypi: Fail on\n\tunsupported stream role","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Sun, Jun 28, 2020 at 06:17:22PM +0200, Jacopo Mondi wrote:\n> When an unsupported stream roles is requested to\n> generateConfiguration(), the function shall fail instead of simply\n> ignoring the request.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index d1338b640e3c..aa7b7eb93aab 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -568,7 +568,8 @@ CameraConfiguration *PipelineHandlerRPi::generateConfiguration(Camera *camera,\n> \t\tdefault:\n> \t\t\tLOG(RPI, Error) << \"Requested stream role not supported: \"\n> \t\t\t\t\t<< role;\n> -\t\t\tbreak;\n> +\t\t\tdelete config;\n> +\t\t\treturn nullptr;\n> \t\t}\n> \n> \t\tif (rawCount > 1 || outCount > 2) {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9966EC2E69\n\tfor ;\n\tSun, 28 Jun 2020 23:29:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 67095603B6;\n\tMon, 29 Jun 2020 01:29:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BFCD8603B6\n\tfor ;\n\tMon, 29 Jun 2020 01:29:55 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4F5724FB;\n\tMon, 29 Jun 2020 01:29:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tP3rFvLs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593386995;\n\tbh=YWb2bH4ab4mcwPYehm86ELdK8/MFlYIMR+5h295zSOE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tP3rFvLsblh6+rCoQDlQpaB9l1pM8uxCI3LTzw/qZawNBtiff2YZpGglSltytCv57\n\ttOwsX8qHOdRIDsM5cqCvLfXiB0Tf260Ofj8b79xZfCV48FZSNoeVZaDx/if4rlAUDO\n\tCXnjuG4DX4wXsgGzxiW8rjn9y35PZCTe4E4LHZrg=","Date":"Mon, 29 Jun 2020 02:29:52 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"<20200628232952.GD6954@pendragon.ideasonboard.com>","References":"<20200628161723.30625-1-jacopo@jmondi.org>\n\t<20200628161723.30625-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200628161723.30625-3-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: raspberrypi: Fail on\n\tunsupported stream role","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]