[{"id":10937,"web_url":"https://patchwork.libcamera.org/comment/10937/","msgid":"<20200628181157.GM1105424@oden.dyn.berto.se>","date":"2020-06-28T18:11:57","subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: ipu3: Fix wrong\n\tindentation","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your fix.\n\nOn 2020-06-28 17:55:39 +0200, Jacopo Mondi wrote:\n> Fix wrong parameter indent in generateConfiguration() function\n> implementation.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index cbf19793c43e..1bdad209de6e 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -289,7 +289,7 @@ PipelineHandlerIPU3::PipelineHandlerIPU3(CameraManager *manager)\n> }\n> \n> CameraConfiguration *PipelineHandlerIPU3::generateConfiguration(Camera *camera,\n> -\tconst StreamRoles &roles)\n> +\t\t\t\t\t\t\t\tconst StreamRoles &roles)\n> {\n> \tIPU3CameraData *data = cameraData(camera);\n> \tIPU3CameraConfiguration *config = new IPU3CameraConfiguration(camera, data);\n> -- \n> 2.27.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E128EC2E66\n\tfor ;\n\tSun, 28 Jun 2020 18:12:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B1CD6609C9;\n\tSun, 28 Jun 2020 20:12:00 +0200 (CEST)","from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 88AB9603B5\n\tfor ;\n\tSun, 28 Jun 2020 20:11:59 +0200 (CEST)","by mail-lj1-x241.google.com with SMTP id s1so15651410ljo.0\n\tfor ;\n\tSun, 28 Jun 2020 11:11:59 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\te80sm8575701lfd.64.2020.06.28.11.11.58\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 28 Jun 2020 11:11:58 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"a0ze2Uww\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=2uBi0wR848bLYIwQy8yHLW1XshdxVSdjrERDSJVqD+8=;\n\tb=a0ze2Uwwkc5KaF3ovEIPyjqKNF0BKBAxJC5UfzB67S8Q1PWbXWM+G6BLb+NrDe0G/j\n\to2KjpF0eER5VitLwz2BRStzTyL/q0RRVksx0uBS/nv0XwFYZhkV01IarIICj1/n1bk41\n\tv2vnOuCr9n5kKDEjq3UU2VIojBNGEw+at64tZgORD/JKalE8lFMef70jGahZYbOAPTck\n\tphgJqoCg/UPhMRQIsADIGG1CSyAZayW8Dgr8IsgaD4EV1mCdsYoNaJvBKJ8ltAVtanGN\n\teOdItApCB272U+nCfJnU6XYaK43fMRepP8ayh9RA6X8JkK0KPPGl5Ni8kjFWPucHA93I\n\tZ5Qg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=2uBi0wR848bLYIwQy8yHLW1XshdxVSdjrERDSJVqD+8=;\n\tb=fWK2Ue6rVhz40PFHFcDF6XSMl+ZwIbuKoONh403HpBExLwiZch8T2nmujutPYBHEhm\n\ttcsO3nIU+x0etM+n9GUoUjVMlJ8G9pveTq9ILGKDir5id/GqlGyWIjyNz97aT9M3xFqG\n\tZH0b3vCU7m5sj+5bcKtHNc8OdLgZFT3kipN/v5yM9PEw/XTbyDuGxQpnuUFbXVLizhHk\n\ta/+RAX5eZgoMr4FhKdou2vwpwRnIvneeTDcTA7ye1VVAXIT/kXET7jHD7iKla5LFwMQA\n\t1rjnHHxgf29czQ5zrKQc0kWMdM8sjkCXp+lAL+hKfRPdf3tkhIytXrFnCX4B2Cs+qbaJ\n\tCUsw==","X-Gm-Message-State":"AOAM53006to2kDgg/KQa95VASKTJzjv7zqew3xJW3oxwtBoDteXL5yLx\n\tguTEZUBMsYW2IVpMSNSI+HicujujW70=","X-Google-Smtp-Source":"ABdhPJyCmXg8DKkK9shxfAgDruEd1HaOtu2mNkXVDtVZFKK15RT6Ww7Kro2F7d9xc780jaoh0rxWPg==","X-Received":"by 2002:a2e:8184:: with SMTP id e4mr6611032ljg.334.1593367918824;\n\tSun, 28 Jun 2020 11:11:58 -0700 (PDT)","Date":"Sun, 28 Jun 2020 20:11:57 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"<20200628181157.GM1105424@oden.dyn.berto.se>","References":"<20200628155539.29498-1-jacopo@jmondi.org>\n\t<20200628155539.29498-4-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200628155539.29498-4-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: ipu3: Fix wrong\n\tindentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":10944,"web_url":"https://patchwork.libcamera.org/comment/10944/","msgid":"<20200628204420.GY6954@pendragon.ideasonboard.com>","date":"2020-06-28T20:44:20","subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: ipu3: Fix wrong\n\tindentation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Sun, Jun 28, 2020 at 05:55:39PM +0200, Jacopo Mondi wrote:\n> Fix wrong parameter indent in generateConfiguration() function\n> implementation.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index cbf19793c43e..1bdad209de6e 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -289,7 +289,7 @@ PipelineHandlerIPU3::PipelineHandlerIPU3(CameraManager *manager)\n> }\n> \n> CameraConfiguration *PipelineHandlerIPU3::generateConfiguration(Camera *camera,\n> -\tconst StreamRoles &roles)\n> +\t\t\t\t\t\t\t\tconst StreamRoles &roles)\n\nIt may have been done on purpose to shorten the line.\n\nReviewed-by: Laurent Pinchart \n\n> {\n> \tIPU3CameraData *data = cameraData(camera);\n> \tIPU3CameraConfiguration *config = new IPU3CameraConfiguration(camera, data);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 52AD9C2E69\n\tfor ;\n\tSun, 28 Jun 2020 20:44:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CE742609D6;\n\tSun, 28 Jun 2020 22:44:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5058E609A3\n\tfor ;\n\tSun, 28 Jun 2020 22:44:24 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B7D1D4FB;\n\tSun, 28 Jun 2020 22:44:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UUjAc1b4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593377063;\n\tbh=CtbW/oAFFlase/qSJhz2f66IfOk47NsvF6jLPlGvauk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=UUjAc1b4NY2IiWNSU+KfA4LraxzhTeKkcx9RCpqgwp7EPHZ6UQZyYGNr4Yk/ila17\n\tmPAliZ03aLBZY8OPfodkxNlu7DBy+CIw/nRe62mZM0RCw3tp7+hBLcSrnnXvZjbjJ9\n\tWUnzfI1pSqF3plEC6OuoWmoCZCSR6yfZ/SLHP0GA=","Date":"Sun, 28 Jun 2020 23:44:20 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"<20200628204420.GY6954@pendragon.ideasonboard.com>","References":"<20200628155539.29498-1-jacopo@jmondi.org>\n\t<20200628155539.29498-4-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200628155539.29498-4-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: ipu3: Fix wrong\n\tindentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]