[{"id":10935,"web_url":"https://patchwork.libcamera.org/comment/10935/","msgid":"<20200628181026.GK1105424@oden.dyn.berto.se>","date":"2020-06-28T18:10:26","subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: ipu3: Improve error on\n\tmultiple raw streams request","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2020-06-28 17:55:37 +0200, Jacopo Mondi wrote:\n> Improve the error message emitted when multiple raw streams are\n> requested.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index f2aa0caede7f..ef57196c32da 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -341,8 +341,7 @@ CameraConfiguration *PipelineHandlerIPU3::generateConfiguration(Camera *camera,\n> \t\tcase StreamRole::StillCaptureRaw: {\n> \t\t\tif (streams.find(&data->rawStream_) == streams.end()) {\n> \t\t\t\tLOG(IPU3, Error)\n> -\t\t\t\t\t<< \"No stream available for requested role \"\n> -\t\t\t\t\t<< role;\n> +\t\t\t\t\t<< \"Multiple raw streams are not supported\";\n> \t\t\t\tbreak;\n> \t\t\t}\n> \n> -- \n> 2.27.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 08CBEC2E69\n\tfor ;\n\tSun, 28 Jun 2020 18:10:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 831B4609DB;\n\tSun, 28 Jun 2020 20:10:29 +0200 (CEST)","from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C441B603B5\n\tfor ;\n\tSun, 28 Jun 2020 20:10:27 +0200 (CEST)","by mail-lj1-x244.google.com with SMTP id n24so15588473lji.10\n\tfor ;\n\tSun, 28 Jun 2020 11:10:27 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tn1sm6973359ljg.131.2020.06.28.11.10.26\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 28 Jun 2020 11:10:26 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"EmKyGPiT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=JvITU9SwhZyYCUKpZcB/YTYvSaQGXgHvTG9yVoOagCA=;\n\tb=EmKyGPiT2Prlx0ja/Hdii98xnb+RjuRvUNCcYaBwhoeT+nIION5UjcZSPG6NAhHNAW\n\tiP7+UUILeJCP3pBNHtYZ7c9e2GarwZWcbkUHHQjh+EX3tFLazUUpTGHM6z5RN/b2MrTi\n\trpCoQh/2x2+GUdoG0wEQ/YzPOWlahTxpdXfCmzuVGBVterHocPsXVJsTePt3oJVUPdLr\n\tHcS3VB01YWKS5AarYFzWLwlLlruN8pKWw2FDxJBG523wIYcLQbLXxjxhaR0wPPgHG0Jm\n\trdmsxGu/EdtctNSA1uHEKrMvY7IGDc+LtrfO7CMcJufZuigdYLfSQ1RSjUWPbkn6khg0\n\tRKVw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=JvITU9SwhZyYCUKpZcB/YTYvSaQGXgHvTG9yVoOagCA=;\n\tb=Mi5R32YwXF0tNvYXEii6tZnM9mpoXULAn0HPUjBlrY8C2sUyGy3L3X6ZmAe5vGM/3f\n\tUL0MXac/PIiNd3R29vTH+mAzCcaAs/bcCfiFWUHuZ/mHOAqR/Ork9B66ByNR4bfDw6ZH\n\tLDHHYcg6Ll0kvUD0125lBr2h4qrBjQXIm6E6AM+5KNyqd11zENEgEr02GRoJpbUWCltd\n\t4rKVxftHG5MrA1s+GVywVbCrWetrLfXdel5SHd03eBMhBtAusaLjfYXD/hJlhGBNRll5\n\tweWYZ7PxJbFGgqfumf1aMJnFP2Kkcvpf41U/uWjxAE/9pTGm2jIEbKTtSFHy4Lqg7CkK\n\tTMXw==","X-Gm-Message-State":"AOAM5300d5CzMNT1+bcw/gs6trFpHgkPBxQk4fcU9RgIjRUUeufODhbw\n\t3GlwxBsQAHVpcQ2RarEnV/gEXK16HhM=","X-Google-Smtp-Source":"ABdhPJyWdd/s3Zeke6E8YNYEyQUaP4UNb4B1nAy5MOcE2bkjkGU51YnZvryspAX6DSPVpqWlP41xwQ==","X-Received":"by 2002:a2e:87da:: with SMTP id v26mr6091969ljj.14.1593367827172;\n\tSun, 28 Jun 2020 11:10:27 -0700 (PDT)","Date":"Sun, 28 Jun 2020 20:10:26 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"<20200628181026.GK1105424@oden.dyn.berto.se>","References":"<20200628155539.29498-1-jacopo@jmondi.org>\n\t<20200628155539.29498-2-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200628155539.29498-2-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: ipu3: Improve error on\n\tmultiple raw streams request","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":10942,"web_url":"https://patchwork.libcamera.org/comment/10942/","msgid":"<20200628204029.GW6954@pendragon.ideasonboard.com>","date":"2020-06-28T20:40:29","subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: ipu3: Improve error on\n\tmultiple raw streams request","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Sun, Jun 28, 2020 at 05:55:37PM +0200, Jacopo Mondi wrote:\n> Improve the error message emitted when multiple raw streams are\n> requested.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index f2aa0caede7f..ef57196c32da 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -341,8 +341,7 @@ CameraConfiguration *PipelineHandlerIPU3::generateConfiguration(Camera *camera,\n> \t\tcase StreamRole::StillCaptureRaw: {\n> \t\t\tif (streams.find(&data->rawStream_) == streams.end()) {\n> \t\t\t\tLOG(IPU3, Error)\n> -\t\t\t\t\t<< \"No stream available for requested role \"\n> -\t\t\t\t\t<< role;\n> +\t\t\t\t\t<< \"Multiple raw streams are not supported\";\n> \t\t\t\tbreak;\n> \t\t\t}\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 31943C2E66\n\tfor ;\n\tSun, 28 Jun 2020 20:40:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9F6DF609C9;\n\tSun, 28 Jun 2020 22:40:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4B09F603B5\n\tfor ;\n\tSun, 28 Jun 2020 22:40:33 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B008D4FB;\n\tSun, 28 Jun 2020 22:40:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PwiQZ2EF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593376832;\n\tbh=KTiNt37zDT9Uz2nxzY7Ws7QU+neYKJ4cbfxbRJ9achs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=PwiQZ2EFshOzHX+uHQzZs2f02coKsdUXGhTMDItI+JrC895zDzyoz6jnljDuqPyIw\n\tNVSFdYK7DFjN8Lj/cdD3MzGQLH4a/e/9Yn7m01ApVNokPkU6lUzy+Oj36MY1cK8Y6a\n\tmxLsiAHAPffGGxsA0FDUsX+YAMdIRcH3KNZVOiec=","Date":"Sun, 28 Jun 2020 23:40:29 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"<20200628204029.GW6954@pendragon.ideasonboard.com>","References":"<20200628155539.29498-1-jacopo@jmondi.org>\n\t<20200628155539.29498-2-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200628155539.29498-2-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: ipu3: Improve error on\n\tmultiple raw streams request","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":10956,"web_url":"https://patchwork.libcamera.org/comment/10956/","msgid":"<3ef053d6-0743-0a06-8529-7e99861a2998@ideasonboard.com>","date":"2020-06-29T10:21:45","subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: ipu3: Improve error on\n\tmultiple raw streams request","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 28/06/2020 16:55, Jacopo Mondi wrote:\n> Improve the error message emitted when multiple raw streams are\n> requested.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index f2aa0caede7f..ef57196c32da 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -341,8 +341,7 @@ CameraConfiguration *PipelineHandlerIPU3::generateConfiguration(Camera *camera,\n> \t\tcase StreamRole::StillCaptureRaw: {\n> \t\t\tif (streams.find(&data->rawStream_) == streams.end()) {\n> \t\t\t\tLOG(IPU3, Error)\n> -\t\t\t\t\t<< \"No stream available for requested role \"\n> -\t\t\t\t\t<< role;\n> +\t\t\t\t\t<< \"Multiple raw streams are not supported\";\n\nI'm confused. Doesn't this conditional block look to find the rawStream\nin the streams, and if it doesn't exist print this message?\n\nI can't see where the context is that means this is adding 'another' raw\nstream... unless the logic is inverted in the if statement? (or I'm just\ngetting it wrong).\n\n\n\n\n> \t\t\t\tbreak;\n> \t\t\t}\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 67149BF415\n\tfor ;\n\tMon, 29 Jun 2020 10:21:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 09BAD609C6;\n\tMon, 29 Jun 2020 12:21:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2476F603B4\n\tfor ;\n\tMon, 29 Jun 2020 12:21:49 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 76A6C293;\n\tMon, 29 Jun 2020 12:21:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CFjAeWNk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593426108;\n\tbh=Exbi+f0/v3gy42c2iFiUvWkkgU2drjRx3AaMKvIsteo=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=CFjAeWNkZDrJRtR9VGGy+AG9H3O5y1K2CFhQDch2/rlf3H3dlfbPq3fjvSUenGDLG\n\tCo5KaTW2sZ9BFkAeyvl4LsiutvSIbLcHmL/KcL2M9ZtzJsLfwuud0I1HefhnEUpTg3\n\tR7hjuPtm5IXaMMI3xWsU9WhepiqdUrOoKQGhNj2E=","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20200628155539.29498-1-jacopo@jmondi.org>\n\t<20200628155539.29498-2-jacopo@jmondi.org>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<3ef053d6-0743-0a06-8529-7e99861a2998@ideasonboard.com>","Date":"Mon, 29 Jun 2020 11:21:45 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.8.0","MIME-Version":"1.0","In-Reply-To":"<20200628155539.29498-2-jacopo@jmondi.org>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: ipu3: Improve error on\n\tmultiple raw streams request","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":10958,"web_url":"https://patchwork.libcamera.org/comment/10958/","msgid":"<20200629103202.vgq5i77kes4hluw4@uno.localdomain>","date":"2020-06-29T10:32:02","subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: ipu3: Improve error on\n\tmultiple raw streams request","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran,\n\nOn Mon, Jun 29, 2020 at 11:21:45AM +0100, Kieran Bingham wrote:\n> Hi Jacopo,\n>\n> On 28/06/2020 16:55, Jacopo Mondi wrote:\n> > Improve the error message emitted when multiple raw streams are\n> > requested.\n> >\n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > src/libcamera/pipeline/ipu3/ipu3.cpp | 3 +--\n> > 1 file changed, 1 insertion(+), 2 deletions(-)\n> >\n> > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > index f2aa0caede7f..ef57196c32da 100644\n> > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > @@ -341,8 +341,7 @@ CameraConfiguration *PipelineHandlerIPU3::generateConfiguration(Camera *camera,\n> > \t\tcase StreamRole::StillCaptureRaw: {\n> > \t\t\tif (streams.find(&data->rawStream_) == streams.end()) {\n> > \t\t\t\tLOG(IPU3, Error)\n> > -\t\t\t\t\t<< \"No stream available for requested role \"\n> > -\t\t\t\t\t<< role;\n> > +\t\t\t\t\t<< \"Multiple raw streams are not supported\";\n>\n> I'm confused. Doesn't this conditional block look to find the rawStream\n> in the streams, and if it doesn't exist print this message?\n>\n\nYes\n\n> I can't see where the context is that means this is adding 'another' raw\n> stream... unless the logic is inverted in the if statement? (or I'm just\n> getting it wrong).\n\n\nThe functions declares an array of available streams\n\tstd::set streams = {\n\t\t&data->outStream_,\n\t\t&data->vfStream_,\n\t\t&data->rawStream_,\n\t};\n\nwhen one gets assigned it is removed from there\n\n\t\tstreams.erase(stream);\n\nSo if we get here and fail to find rawStream_, it means it has been\nassigned already.\n\n\n>\n>\n>\n>\n> > \t\t\t\tbreak;\n> > \t\t\t}\n> >\n> >\n>\n> --\n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E42ACBFFE2\n\tfor ;\n\tMon, 29 Jun 2020 10:28:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C1907609D6;\n\tMon, 29 Jun 2020 12:28:34 +0200 (CEST)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2B63F603B4\n\tfor ;\n\tMon, 29 Jun 2020 12:28:34 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id B346FC0006;\n\tMon, 29 Jun 2020 10:28:33 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Mon, 29 Jun 2020 12:32:02 +0200","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20200629103202.vgq5i77kes4hluw4@uno.localdomain>","References":"<20200628155539.29498-1-jacopo@jmondi.org>\n\t<20200628155539.29498-2-jacopo@jmondi.org>\n\t<3ef053d6-0743-0a06-8529-7e99861a2998@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<3ef053d6-0743-0a06-8529-7e99861a2998@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: ipu3: Improve error on\n\tmultiple raw streams request","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]