{"id":8474,"url":"https://patchwork.libcamera.org/api/patches/8474/?format=json","web_url":"https://patchwork.libcamera.org/patch/8474/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200628155539.29498-2-jacopo@jmondi.org>","date":"2020-06-28T15:55:37","name":"[libcamera-devel,1/3] libcamera: ipu3: Improve error on multiple raw streams request","commit_ref":"83d37d54666f6114527ad503ea5e80d5b9388f11","pull_url":null,"state":"accepted","archived":false,"hash":"4ff99706c89dea8f6f40dbd8a3059895d0e502de","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8474/mbox/","series":[{"id":1051,"url":"https://patchwork.libcamera.org/api/series/1051/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1051","date":"2020-06-28T15:55:36","name":"ipu3: Accept empty roles list in generateConfiguration()","version":1,"mbox":"https://patchwork.libcamera.org/series/1051/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8474/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8474/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 67E7EC2E69\n\tfor ;\n\tSun, 28 Jun 2020 15:52:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 825CF609E8;\n\tSun, 28 Jun 2020 17:52:17 +0200 (CEST)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B0C1A603B5\n\tfor ;\n\tSun, 28 Jun 2020 17:52:16 +0200 (CEST)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 2F42AC0004;\n\tSun, 28 Jun 2020 15:52:16 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Sun, 28 Jun 2020 17:55:37 +0200","Message-Id":"<20200628155539.29498-2-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200628155539.29498-1-jacopo@jmondi.org>","References":"<20200628155539.29498-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 1/3] libcamera: ipu3: Improve error on\n\tmultiple raw streams request","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Improve the error message emitted when multiple raw streams are\nrequested.\n\nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex f2aa0caede7f..ef57196c32da 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -341,8 +341,7 @@ CameraConfiguration *PipelineHandlerIPU3::generateConfiguration(Camera *camera,\n \t\tcase StreamRole::StillCaptureRaw: {\n \t\t\tif (streams.find(&data->rawStream_) == streams.end()) {\n \t\t\t\tLOG(IPU3, Error)\n-\t\t\t\t\t<< \"No stream available for requested role \"\n-\t\t\t\t\t<< role;\n+\t\t\t\t\t<< \"Multiple raw streams are not supported\";\n \t\t\t\tbreak;\n \t\t\t}\n \n","prefixes":["libcamera-devel","1/3"]}