[{"id":10934,"web_url":"https://patchwork.libcamera.org/comment/10934/","msgid":"<20200628180651.GJ1105424@oden.dyn.berto.se>","date":"2020-06-28T18:06:51","subject":"Re: [libcamera-devel] [PATCH v2] utils: raspberrypi: ctt: Fix\n\tpycodestyle W605","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-06-28 15:37:30 +0300, Laurent Pinchart wrote:\n> W605 invalid escape sequence '\\.'\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> Changes since v1:\n> \n> - Use raw strings for regular expressions\n> ---\n> utils/raspberrypi/ctt/ctt.py | 4 ++--\n> utils/raspberrypi/ctt/ctt_awb.py | 4 ++--\n> 2 files changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/utils/raspberrypi/ctt/ctt.py b/utils/raspberrypi/ctt/ctt.py\n> index d7e38c31986d..30d35ae4e3d4 100755\n> --- a/utils/raspberrypi/ctt/ctt.py\n> +++ b/utils/raspberrypi/ctt/ctt.py\n> @@ -42,8 +42,8 @@ def get_col_lux(string):\n> \"\"\"\n> Extract colour and lux values from filename\n> \"\"\"\n> - col = re.search('([0-9]+)[kK](\\.(jpg|jpeg|brcm|dng)|_.*\\.(jpg|jpeg|brcm|dng))$', string)\n> - lux = re.search('([0-9]+)[lL](\\.(jpg|jpeg|brcm|dng)|_.*\\.(jpg|jpeg|brcm|dng))$', string)\n> + col = re.search(r'([0-9]+)[kK](\\.(jpg|jpeg|brcm|dng)|_.*\\.(jpg|jpeg|brcm|dng))$', string)\n> + lux = re.search(r'([0-9]+)[lL](\\.(jpg|jpeg|brcm|dng)|_.*\\.(jpg|jpeg|brcm|dng))$', string)\n> try:\n> col = col.group(1)\n> except AttributeError:\n> diff --git a/utils/raspberrypi/ctt/ctt_awb.py b/utils/raspberrypi/ctt/ctt_awb.py\n> index 7055b8639178..3c8cd9027a1a 100644\n> --- a/utils/raspberrypi/ctt/ctt_awb.py\n> +++ b/utils/raspberrypi/ctt/ctt_awb.py\n> @@ -257,8 +257,8 @@ def awb(Cam, cal_cr_list, cal_cb_list, plot):\n> plt.scatter(rbs_hat[0], rbs_hat[1], color='red')\n> for i, ct in enumerate(rbs_hat[2]):\n> plt.annotate(str(ct), (rbs_hat[0][i], rbs_hat[1][i]))\n> - plt.xlabel('$\\hat{r}$')\n> - plt.ylabel('$\\hat{b}$')\n> + plt.xlabel('$\\\\hat{r}$')\n> + plt.ylabel('$\\\\hat{b}$')\n> \"\"\"\n> optional set axes equal to shortest distance so line really does\n> looks perpendicular and everybody is happy\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 51761C2E66\n\tfor ;\n\tSun, 28 Jun 2020 18:06:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E1D3D609C9;\n\tSun, 28 Jun 2020 20:06:55 +0200 (CEST)","from mail-lj1-x231.google.com (mail-lj1-x231.google.com\n\t[IPv6:2a00:1450:4864:20::231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2F13F603B5\n\tfor ;\n\tSun, 28 Jun 2020 20:06:54 +0200 (CEST)","by mail-lj1-x231.google.com with SMTP id n24so15582893lji.10\n\tfor ;\n\tSun, 28 Jun 2020 11:06:54 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tx10sm6974556ljx.67.2020.06.28.11.06.51\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 28 Jun 2020 11:06:52 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"CoS/NuSk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=Z7u4rKbqYprePAa3wXpJ7w0prn40gHysHHookIvzVzo=;\n\tb=CoS/NuSkMZ1gRew+vzepTO/WmavX174tDTfEBlUhQ4I31Av/Wbjpeyfe/YYxFNiZEG\n\tQUAkY/amLbNC2Wdlr56an4ex9Ek6qYN07+/M70FDpITlgpQp3YKic0LAGPFLlM/sALJg\n\t09KNuQgZxumsJp9aqRg0WeVcl1boR9zvD0OsOZ8dWdO4eVs8/EkCJ73mEt+fzUTVyiU1\n\tos3ZFmCrm4k6a1VG+Ib8xgJydw+YrSKBHEci6cHABBP+Wybxrva9cqdRLwPsFoi775MC\n\tNf8nGXsc+S8jFWN/d492f+yn6eMeLNu0y2vZQfOWGb8P0LUJQA2Mc4XTtItU2DYW9s7m\n\tNaIA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=Z7u4rKbqYprePAa3wXpJ7w0prn40gHysHHookIvzVzo=;\n\tb=U9eTOBRokB4xOlEZXJq689TvCmKWJGTtIL+S/m/AE72/QeUBXi3auNj47IV9hwqW3e\n\tLKYVI4Z5aOdjUyVH5dlxYne3hT2CP1KawYxoPeZAFi7hPyFKUJgYzU/ZE7nxTSgXidAQ\n\tP+rwxAjdrXd2aMidFVXgwjKaERBJvOEbp5zjhR/IYmxRcdP6MwGvTsaSdIOfkN6evlle\n\teoc2MUhf403m3ibpDcnjvuslBqy5leOe71ITxTLdd51VyrADtTDgV3yfgjPKIQxe4m0f\n\tAxUKCC4/XeUTccPF/AK/lxU1uJVJwYmDW0goyMuY1a5ODjtEDJxGknIABBPKrl50FwIv\n\tRTNw==","X-Gm-Message-State":"AOAM531QwkumxF8kCoo0xqarSfeS+CxmyCcPf6+wo3fCUzleiZxhox9B\n\tsTj5ICt+Dr8JCFKWw/TVaAU1eg==","X-Google-Smtp-Source":"ABdhPJxO3DpaNULWJGfBtet1v4xYc6ROOyzRkRpQFdZhmyGZ4yosi9S/VJo7HixDcvMuuPOLbfay3w==","X-Received":"by 2002:a2e:9585:: with SMTP id w5mr5678841ljh.58.1593367613155; \n\tSun, 28 Jun 2020 11:06:53 -0700 (PDT)","Date":"Sun, 28 Jun 2020 20:06:51 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"<20200628180651.GJ1105424@oden.dyn.berto.se>","References":"<20200628123730.31992-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200628123730.31992-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2] utils: raspberrypi: ctt: Fix\n\tpycodestyle W605","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":10952,"web_url":"https://patchwork.libcamera.org/comment/10952/","msgid":"","date":"2020-06-29T07:41:17","subject":"Re: [libcamera-devel] [PATCH v2] utils: raspberrypi: ctt: Fix\n\tpycodestyle W605","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Laurent\n\nThanks for tidying this up!\n\nOn Sun, 28 Jun 2020 at 19:06, Niklas Söderlund\n wrote:\n>\n> Hi Laurent,\n>\n> Thanks for your work.\n>\n> On 2020-06-28 15:37:30 +0300, Laurent Pinchart wrote:\n> > W605 invalid escape sequence '\\.'\n> >\n> > Signed-off-by: Laurent Pinchart \n>\n> Reviewed-by: Niklas Söderlund \n\nReviewed-by: David Plowman \n\nBest regards\nDavid\n\n>\n> > ---\n> > Changes since v1:\n> >\n> > - Use raw strings for regular expressions\n> > ---\n> > utils/raspberrypi/ctt/ctt.py | 4 ++--\n> > utils/raspberrypi/ctt/ctt_awb.py | 4 ++--\n> > 2 files changed, 4 insertions(+), 4 deletions(-)\n> >\n> > diff --git a/utils/raspberrypi/ctt/ctt.py b/utils/raspberrypi/ctt/ctt.py\n> > index d7e38c31986d..30d35ae4e3d4 100755\n> > --- a/utils/raspberrypi/ctt/ctt.py\n> > +++ b/utils/raspberrypi/ctt/ctt.py\n> > @@ -42,8 +42,8 @@ def get_col_lux(string):\n> > \"\"\"\n> > Extract colour and lux values from filename\n> > \"\"\"\n> > - col = re.search('([0-9]+)[kK](\\.(jpg|jpeg|brcm|dng)|_.*\\.(jpg|jpeg|brcm|dng))$', string)\n> > - lux = re.search('([0-9]+)[lL](\\.(jpg|jpeg|brcm|dng)|_.*\\.(jpg|jpeg|brcm|dng))$', string)\n> > + col = re.search(r'([0-9]+)[kK](\\.(jpg|jpeg|brcm|dng)|_.*\\.(jpg|jpeg|brcm|dng))$', string)\n> > + lux = re.search(r'([0-9]+)[lL](\\.(jpg|jpeg|brcm|dng)|_.*\\.(jpg|jpeg|brcm|dng))$', string)\n> > try:\n> > col = col.group(1)\n> > except AttributeError:\n> > diff --git a/utils/raspberrypi/ctt/ctt_awb.py b/utils/raspberrypi/ctt/ctt_awb.py\n> > index 7055b8639178..3c8cd9027a1a 100644\n> > --- a/utils/raspberrypi/ctt/ctt_awb.py\n> > +++ b/utils/raspberrypi/ctt/ctt_awb.py\n> > @@ -257,8 +257,8 @@ def awb(Cam, cal_cr_list, cal_cb_list, plot):\n> > plt.scatter(rbs_hat[0], rbs_hat[1], color='red')\n> > for i, ct in enumerate(rbs_hat[2]):\n> > plt.annotate(str(ct), (rbs_hat[0][i], rbs_hat[1][i]))\n> > - plt.xlabel('$\\hat{r}$')\n> > - plt.ylabel('$\\hat{b}$')\n> > + plt.xlabel('$\\\\hat{r}$')\n> > + plt.ylabel('$\\\\hat{b}$')\n> > \"\"\"\n> > optional set axes equal to shortest distance so line really does\n> > looks perpendicular and everybody is happy\n> > --\n> > Regards,\n> >\n> > Laurent Pinchart\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n>\n> --\n> Regards,\n> Niklas Söderlund\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 92502C2E69\n\tfor ;\n\tMon, 29 Jun 2020 07:41:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 061A0609D6;\n\tMon, 29 Jun 2020 09:41:30 +0200 (CEST)","from mail-oi1-x241.google.com (mail-oi1-x241.google.com\n\t[IPv6:2607:f8b0:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B28E603BB\n\tfor ;\n\tMon, 29 Jun 2020 09:41:28 +0200 (CEST)","by mail-oi1-x241.google.com with SMTP id y22so1009112oie.8\n\tfor ;\n\tMon, 29 Jun 2020 00:41:28 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"tydA9kRi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=uwBbTFppuIh3k7tnchapA+BUsmsFwTRitsebDO9pM48=;\n\tb=tydA9kRiH7YwWsuW5HF0WvpEiIXEvzlQZXvo8jez7GtqGy2O4oNsofgirhTqxVOroB\n\tA09Fh6Z4uJHvD8oEn0TPsJ2hkH2g4aiK7NYIw7ThVf/rylDvYGBk5kfgoF2uMG1tlQsY\n\t4HlkyqXEfpJwbXlrzIEjSi/OntuOPRfQIxAlLsMLvX2iZXlky21d1gcn0VvYZvVEWK1c\n\t807eJGuHijWEAZ89w44gH4PZJeENkRRxuWgXU19CpSfzbTvyuVqM3jif5fkwRmi1c5aF\n\t5VlLNHRt2mz3X+fRhmTWk7pOF7023RQhLMhumASAVF9o4+OsQAqtxs+TvLH63/4ITXDQ\n\tEGyw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=uwBbTFppuIh3k7tnchapA+BUsmsFwTRitsebDO9pM48=;\n\tb=QWp99SVw59uudT9qNvnhbI228YoWPQ49wJ3Q6gq2rFcCRwzNT+7mMk76V2yVKTH/ut\n\tKFonJEtDMKx9JOAcSL2NH1/gSwjFnVxl0LqEmzfiWhWKLW8b07VOqOMKf6JDatjDn54K\n\tUTQl/omex0kGJp7p9FXFGqQeMj43itilSoIrKfFua3hXdOXAOSBV6tkw+dJ/hJsAyiYO\n\t4WlsdMj/MaBHrmloDkfgo+q91xAoeMFk238JcB7/KjnaLp+Vlh4HpiShk9O45xeH4Zdy\n\tFzdZRFjjbPmUNP5kEq2H9D029daqv83DkN/0xfu8fKlZwM4rvKnitKa/lg9kgTx12zqU\n\tLxKw==","X-Gm-Message-State":"AOAM531QglUYEzYN8THQB2eJllAZ1w9OPDpzeehb0sg8RilR+9Lekey8\n\tyYXD97qv3idL1HGNujMno+lSmO2W+BaQ9XIgBsCy3EiR","X-Google-Smtp-Source":"ABdhPJwcKTSzYqHFk2+YIVUGNNSzzEtvDqF8uwIXOZ6GuMdVYqxWJcaqlWAbczVqYg16LxoooYU3fr0Rngzc2FnLa2g=","X-Received":"by 2002:a05:6808:149:: with SMTP id\n\th9mr11572775oie.107.1593416487155; \n\tMon, 29 Jun 2020 00:41:27 -0700 (PDT)","MIME-Version":"1.0","References":"<20200628123730.31992-1-laurent.pinchart@ideasonboard.com>\n\t<20200628180651.GJ1105424@oden.dyn.berto.se>","In-Reply-To":"<20200628180651.GJ1105424@oden.dyn.berto.se>","From":"David Plowman ","Date":"Mon, 29 Jun 2020 08:41:17 +0100","Message-ID":"","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","Subject":"Re: [libcamera-devel] [PATCH v2] utils: raspberrypi: ctt: Fix\n\tpycodestyle W605","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]