[{"id":10910,"web_url":"https://patchwork.libcamera.org/comment/10910/","msgid":"<20200627162718.GG5966@pendragon.ideasonboard.com>","date":"2020-06-27T16:27:18","subject":"Re: [libcamera-devel] [PATCH 07/13] libcamera: ipu3: imgu: Mark\n\tthings that are internal as private","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Sat, Jun 27, 2020 at 05:00:37AM +0200, Niklas Söderlund wrote:\n> Mark all variables and functions that are only used internally as\n> private.\n> \n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/ipu3/imgu.h | 24 +++++++++++++-----------\n> 1 file changed, 13 insertions(+), 11 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/imgu.h b/src/libcamera/pipeline/ipu3/imgu.h\n> index ad5aabf134e2099d..b6b08b4fef2d3a9d 100644\n> --- a/src/libcamera/pipeline/ipu3/imgu.h\n> +++ b/src/libcamera/pipeline/ipu3/imgu.h\n> @@ -24,11 +24,6 @@ struct StreamConfiguration;\n> class ImgUDevice\n> {\n> public:\n> -\tstatic constexpr unsigned int PAD_INPUT = 0;\n> -\tstatic constexpr unsigned int PAD_OUTPUT = 2;\n> -\tstatic constexpr unsigned int PAD_VF = 3;\n> -\tstatic constexpr unsigned int PAD_STAT = 4;\n> -\n> \t/* ImgU output descriptor: group data specific to an ImgU output. */\n> \tstruct ImgUOutput {\n> \t\tV4L2VideoDevice *dev;\n> @@ -64,20 +59,27 @@ public:\n> \tint start();\n> \tint stop();\n> \n> -\tint linkSetup(const std::string &source, unsigned int sourcePad,\n> -\t\t const std::string &sink, unsigned int sinkPad,\n> -\t\t bool enable);\n> \tint enableLinks(bool enable);\n> \n> -\tstd::string name_;\n> -\tMediaDevice *media_;\n> -\n> \tV4L2Subdevice *imgu_;\n> \tV4L2VideoDevice *input_;\n> \tImgUOutput output_;\n> \tImgUOutput viewfinder_;\n> \tImgUOutput stat_;\n> \t/* \\todo Add param video device for 3A tuning */\n> +\n> +private:\n> +\tstatic constexpr unsigned int PAD_INPUT = 0;\n> +\tstatic constexpr unsigned int PAD_OUTPUT = 2;\n> +\tstatic constexpr unsigned int PAD_VF = 3;\n> +\tstatic constexpr unsigned int PAD_STAT = 4;\n> +\n> +\tint linkSetup(const std::string &source, unsigned int sourcePad,\n> +\t\t const std::string &sink, unsigned int sinkPad,\n> +\t\t bool enable);\n> +\n> +\tstd::string name_;\n> +\tMediaDevice *media_;\n> };\n> \n> } /* namespace libcamera */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BFFE6C2E66\n\tfor ;\n\tSat, 27 Jun 2020 16:27:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3EA78609C8;\n\tSat, 27 Jun 2020 18:27:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C1CD0603B6\n\tfor ;\n\tSat, 27 Jun 2020 18:27:21 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 39A46576;\n\tSat, 27 Jun 2020 18:27:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wBLa8kdh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593275241;\n\tbh=msBv8BEHfuaTox3yZPPD3gswjOlSf5RtSWz/7B416xA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=wBLa8kdhupDyq5vrMKDkUpAPdF0EPsPBBvVy+7IxJAsizL3UD5opw1RvevDs9Dskg\n\t+3ZJVj+dBJ+oTZkpCjdj6o2vYe7o2ajJqJHrcubYaeyym4nGkGFF8q7vXvn0srrYfv\n\t3tjrpWS1n+FE8J4IGPYDRr2YAZ8q0OG8WecWSRYc=","Date":"Sat, 27 Jun 2020 19:27:18 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200627162718.GG5966@pendragon.ideasonboard.com>","References":"<20200627030043.2088585-1-niklas.soderlund@ragnatech.se>\n\t<20200627030043.2088585-8-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200627030043.2088585-8-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH 07/13] libcamera: ipu3: imgu: Mark\n\tthings that are internal as private","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]