[{"id":10909,"web_url":"https://patchwork.libcamera.org/comment/10909/","msgid":"<20200627161208.GF5966@pendragon.ideasonboard.com>","date":"2020-06-27T16:12:08","subject":"Re: [libcamera-devel] [PATCH 06/13] libcamera: ipu3: imgu: Do not\n\tcache index","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Sat, Jun 27, 2020 at 05:00:36AM +0200, Niklas Söderlund wrote:\n> The numerical index of the imgu is only used to create its name in\n> string form. There is no need to keep it around after that, remove it.\n> \n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/ipu3/imgu.cpp | 3 +--\n> src/libcamera/pipeline/ipu3/imgu.h | 1 -\n> 2 files changed, 1 insertion(+), 3 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp\n> index 26a95979d0c7735a..5d11539605f26303 100644\n> --- a/src/libcamera/pipeline/ipu3/imgu.cpp\n> +++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n> @@ -37,8 +37,7 @@ int ImgUDevice::init(MediaDevice *media, unsigned int index)\n> {\n> \tint ret;\n> \n> -\tindex_ = index;\n> -\tname_ = \"ipu3-imgu \" + std::to_string(index_);\n> +\tname_ = \"ipu3-imgu \" + std::to_string(index);\n> \tmedia_ = media;\n> \n> \t/*\n> diff --git a/src/libcamera/pipeline/ipu3/imgu.h b/src/libcamera/pipeline/ipu3/imgu.h\n> index 9bb1b88e2ca8ea2d..ad5aabf134e2099d 100644\n> --- a/src/libcamera/pipeline/ipu3/imgu.h\n> +++ b/src/libcamera/pipeline/ipu3/imgu.h\n> @@ -69,7 +69,6 @@ public:\n> \t\t bool enable);\n> \tint enableLinks(bool enable);\n> \n> -\tunsigned int index_;\n> \tstd::string name_;\n> \tMediaDevice *media_;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F0C52C2E69\n\tfor ;\n\tSat, 27 Jun 2020 16:12:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BA80A609D6;\n\tSat, 27 Jun 2020 18:12:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F3B0609C2\n\tfor ;\n\tSat, 27 Jun 2020 18:12:11 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 15F6F576;\n\tSat, 27 Jun 2020 18:12:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jbxPIoXK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593274331;\n\tbh=k7PcYzRM8zAZkQLrtIqq9AVCjDgFWIV+aG7VVXMStnI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=jbxPIoXKhfHp+Bhnm0Cw4QARTD6YHzBLbtbTPly1HTouu60X34BOpI+EYMtlw84Zx\n\t0zoufBdK+uf+Eo6jrg5rPgMDsmfrQLVfwvU5gLnp7o2k1xv4Nyz7ng3SkoAADQgcwB\n\t1tZmJcBUXbV4KLii2ovIIB+Tc88Csfuv/lle3S8Q=","Date":"Sat, 27 Jun 2020 19:12:08 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200627161208.GF5966@pendragon.ideasonboard.com>","References":"<20200627030043.2088585-1-niklas.soderlund@ragnatech.se>\n\t<20200627030043.2088585-7-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200627030043.2088585-7-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH 06/13] libcamera: ipu3: imgu: Do not\n\tcache index","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]