[{"id":10908,"web_url":"https://patchwork.libcamera.org/comment/10908/","msgid":"<20200627161136.GE5966@pendragon.ideasonboard.com>","date":"2020-06-27T16:11:36","subject":"Re: [libcamera-devel] [PATCH 04/13] libcamera: ipu3: Remove usage\n\tof IPU3CameraData from ImgUDevice","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Sat, Jun 27, 2020 at 05:00:34AM +0200, Niklas Söderlund wrote:\n> The IPU3CameraData argument to allocateBuffers() and freeBuffers() is no\n> longer used and can be removed.\n> \n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 16 +++++++---------\n> 1 file changed, 7 insertions(+), 9 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 5a473e18c082cee8..36413a824ebbf564 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -34,8 +34,6 @@ namespace libcamera {\n> \n> LOG_DEFINE_CATEGORY(IPU3)\n> \n> -class IPU3CameraData;\n> -\n> class ImgUDevice\n> {\n> public:\n> @@ -75,8 +73,8 @@ public:\n> \t\t\t const StreamConfiguration &cfg,\n> \t\t\t V4L2DeviceFormat *outputFormat);\n> \n> -\tint allocateBuffers(IPU3CameraData *data, unsigned int bufferCount);\n> -\tvoid freeBuffers(IPU3CameraData *data);\n> +\tint allocateBuffers(unsigned int bufferCount);\n> +\tvoid freeBuffers();\n> \n> \tint start();\n> \tint stop();\n> @@ -665,7 +663,7 @@ int PipelineHandlerIPU3::allocateBuffers(Camera *camera)\n> \t\tdata->rawStream_.configuration().bufferCount,\n> \t});\n> \n> -\tret = imgu->allocateBuffers(data, bufferCount);\n> +\tret = imgu->allocateBuffers(bufferCount);\n> \tif (ret < 0)\n> \t\treturn ret;\n> \n> @@ -676,7 +674,7 @@ int PipelineHandlerIPU3::freeBuffers(Camera *camera)\n> {\n> \tIPU3CameraData *data = cameraData(camera);\n> \n> -\tdata->imgu_->freeBuffers(data);\n> +\tdata->imgu_->freeBuffers();\n> \n> \treturn 0;\n> }\n> @@ -1121,7 +1119,7 @@ int ImgUDevice::configureOutput(ImgUOutput *output,\n> /**\n> * \\brief Allocate buffers for all the ImgU video devices\n> */\n> -int ImgUDevice::allocateBuffers(IPU3CameraData *data, unsigned int bufferCount)\n> +int ImgUDevice::allocateBuffers(unsigned int bufferCount)\n> {\n> \t/* Share buffers between CIO2 output and ImgU input. */\n> \tint ret = input_->importBuffers(bufferCount);\n> @@ -1158,7 +1156,7 @@ int ImgUDevice::allocateBuffers(IPU3CameraData *data, unsigned int bufferCount)\n> \treturn 0;\n> \n> error:\n> -\tfreeBuffers(data);\n> +\tfreeBuffers();\n> \n> \treturn ret;\n> }\n> @@ -1166,7 +1164,7 @@ error:\n> /**\n> * \\brief Release buffers for all the ImgU video devices\n> */\n> -void ImgUDevice::freeBuffers(IPU3CameraData *data)\n> +void ImgUDevice::freeBuffers()\n> {\n> \tint ret;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 86E86C2E69\n\tfor ;\n\tSat, 27 Jun 2020 16:11:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 55521609D6;\n\tSat, 27 Jun 2020 18:11:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 505B5609C2\n\tfor ;\n\tSat, 27 Jun 2020 18:11:40 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 98C10576;\n\tSat, 27 Jun 2020 18:11:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DNOq/nQz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593274300;\n\tbh=5A66SyeKRTZLaAaew/P56uyPhLumtW9NKUo+Ds4PrcM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=DNOq/nQznkT8wLuN4udTd3rJOGPHhtsW1SqEUUrJE4M0nb6h2wWvf6bAt2vQLTMbv\n\tKqN9xyrTr+2Xgbwj9k7CEHRmJCc49QD+HgoDFOiW4TI4rWkRzn8v4KaKXHz73jOrwA\n\trxkl5Q3+G+QVm2zfqJ4wWagT7L6HVu2KppY+B+IM=","Date":"Sat, 27 Jun 2020 19:11:36 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200627161136.GE5966@pendragon.ideasonboard.com>","References":"<20200627030043.2088585-1-niklas.soderlund@ragnatech.se>\n\t<20200627030043.2088585-5-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200627030043.2088585-5-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH 04/13] libcamera: ipu3: Remove usage\n\tof IPU3CameraData from ImgUDevice","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]