[{"id":10907,"web_url":"https://patchwork.libcamera.org/comment/10907/","msgid":"<20200627161113.GD5966@pendragon.ideasonboard.com>","date":"2020-06-27T16:11:13","subject":"Re: [libcamera-devel] [PATCH 01/13] libcamera: ipu3: Remove unused\n\tname_ filed from IPU3Stream","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Sat, Jun 27, 2020 at 05:00:31AM +0200, Niklas Söderlund wrote:\n> The field is never used, remove it.\n> \n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 4 ----\n> 1 file changed, 4 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 6c43169eb0915965..fba45935741e0e4e 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -109,7 +109,6 @@ public:\n> \n> \tbool active_;\n> \tbool raw_;\n> -\tstd::string name_;\n> \tImgUDevice::ImgUOutput *device_;\n> };\n> \n> @@ -867,11 +866,8 @@ int PipelineHandlerIPU3::registerCameras()\n> \t\t */\n> \t\tdata->imgu_ = numCameras ? &imgu1_ : &imgu0_;\n> \t\tdata->outStream_.device_ = &data->imgu_->output_;\n> -\t\tdata->outStream_.name_ = \"output\";\n> \t\tdata->vfStream_.device_ = &data->imgu_->viewfinder_;\n> -\t\tdata->vfStream_.name_ = \"viewfinder\";\n> \t\tdata->rawStream_.raw_ = true;\n> -\t\tdata->rawStream_.name_ = \"raw\";\n> \n> \t\t/*\n> \t\t * Connect video devices' 'bufferReady' signals to their","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 33877C2E66\n\tfor ;\n\tSat, 27 Jun 2020 16:11:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F0931609DB;\n\tSat, 27 Jun 2020 18:11:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1083D609C2\n\tfor ;\n\tSat, 27 Jun 2020 18:11:17 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9F292576;\n\tSat, 27 Jun 2020 18:11:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"q4By36Zh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593274276;\n\tbh=XIrEJBRxz75683FEkrBje2O7okpw0AUmawku8ByopYw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=q4By36ZhTrIWcLi84yCuUnpKCwtmHoxdzWpFviBu3kyXxwoMFhKdKjb/qiupcPwfw\n\tvNnWF79QddgKAcpCOtSCAjWH9TbgmA+J/+oQdtGSEIAwHoGa2b76O61jGHnlfjovym\n\tkTaa1jhu9LjDNZ6z8T7GJG87nQ79sdUj+orb3w0w=","Date":"Sat, 27 Jun 2020 19:11:13 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200627161113.GD5966@pendragon.ideasonboard.com>","References":"<20200627030043.2088585-1-niklas.soderlund@ragnatech.se>\n\t<20200627030043.2088585-2-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200627030043.2088585-2-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH 01/13] libcamera: ipu3: Remove unused\n\tname_ filed from IPU3Stream","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]