[{"id":10889,"web_url":"https://patchwork.libcamera.org/comment/10889/","msgid":"","date":"2020-06-26T12:31:50","subject":"Re: [libcamera-devel] [PATCH 3/4] libcamera: ipa: raspberrypi:\n\tPopulate libcamera metadata after controller process","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nYes, this change seems correct to me.\n\nReviewed-by: David Plowman \n\nBest regards\nDavd\n\nOn Fri, 26 Jun 2020 at 11:25, Naushir Patuck wrote:\n>\n> For control algorithms like focus, this is needed to return out the\n> the current frame focus statistics. For other algorithms, there is no\n> functional change.\n>\n> Signed-off-By: Naushir Patuck \n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index bc89ab58..62730198 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -318,6 +318,8 @@ void IPARPi::processEvent(const IPAOperationData &event)\n> if (frame_count_ > mistrust_count_)\n> processStats(bufferId);\n>\n> + reportMetadata();\n> +\n> IPAOperationData op;\n> op.operation = RPI_IPA_ACTION_STATS_METADATA_COMPLETE;\n> op.data = { bufferId & RPiIpaMask::ID };\n> @@ -336,7 +338,6 @@ void IPARPi::processEvent(const IPAOperationData &event)\n> * they are \"unreliable\".\n> */\n> prepareISP(embeddedbufferId);\n> - reportMetadata();\n>\n> /* Ready to push the input buffer into the ISP. */\n> IPAOperationData op;\n> --\n> 2.25.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 06C1CC0109\n\tfor ;\n\tFri, 26 Jun 2020 12:32:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A53D8609C8;\n\tFri, 26 Jun 2020 14:32:02 +0200 (CEST)","from mail-oi1-x243.google.com (mail-oi1-x243.google.com\n\t[IPv6:2607:f8b0:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 987EB609C3\n\tfor ;\n\tFri, 26 Jun 2020 14:32:01 +0200 (CEST)","by mail-oi1-x243.google.com with SMTP id k4so7920262oik.2\n\tfor ;\n\tFri, 26 Jun 2020 05:32:01 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"ofxed/iw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=aKbmIwtPH1t+bJ3+Jlhf+RQeoY41sIulfSZyBcUZGEA=;\n\tb=ofxed/iw9zRJtEyAt0Fhj+CYdCSn4sODpQgt7NQfaC2WHc/WAs60LwlYCo6OoPV9dh\n\tn58hHxTBv11QpUPZfGZprRQelb/6xnm6fxouZxKJUt2EJI1/J97TbTAHFSBXgCuQpJOJ\n\t88nkfz0rG0r8D1cbBdEv3Fzww/bMKEjxDKEhNCki/j3EM4ed6sihrqQY+Ao2scJBc8A7\n\tqenZ34EnZKgRk7yaZTKq3qd4Ryt9l7bqJcyfQZ04blLmDJUX2x1JKLJ9JjAewwVdoJdl\n\t+QYKpFKqbL7Gt9m7lUAhdRjGUHVOt920Rj9cigFIsgxoSjg5hY3ogpm9wxpzYJ4uLe9c\n\tP/6w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=aKbmIwtPH1t+bJ3+Jlhf+RQeoY41sIulfSZyBcUZGEA=;\n\tb=oFglkUyV0vm0P7exIWJWcykSf/wfpbjpv979Zqa78nfz2q9kHMzp53XOJg2Vh/mwDe\n\tg/f24dBcXo7AJtapwuc1a2gPZfBbZ9LjWET2qaZSjaHKwwJYGLNK/kgwdZjzFlywMvsP\n\tXuab3kBcMQ8R6bE7o5rrR89m9oZ8eRJdGr722JMf2B48k0JZYRzSQHdiDvlxJOUM5o+y\n\t68JY3Yguhu8T6OgJst/3EE47JssBZwPMHLbjGaMvlBxDS//1s6I4MMaxc7Vt+sOH2H52\n\tgRYZmrBmS6SUhsZ3h6ifnG934v8vuXdBwKInhpBEXkjH7FV/Z3wCZ60b+6UtK5phslCI\n\tYttw==","X-Gm-Message-State":"AOAM53330WgSxW82K5mutWON8f+mz8h3yJrF+Nycx/280xB7OhTr/Ae8\n\tXI8fcNW3dSEdwy5dERolVI8plaiRkByXKbRDPhJaQQ==","X-Google-Smtp-Source":"ABdhPJwAE9231xHIywbF5fgVoDpGG8fCa9lG98742hjUEOXo6RZdlJf5EwvTvHTz1rD7zOolCvlZEn7T9d/TkZDa8i4=","X-Received":"by 2002:a05:6808:149:: with SMTP id\n\th9mr2302729oie.107.1593174720602; \n\tFri, 26 Jun 2020 05:32:00 -0700 (PDT)","MIME-Version":"1.0","References":"<20200626102531.1187650-1-naush@raspberrypi.com>\n\t<20200626102531.1187650-4-naush@raspberrypi.com>","In-Reply-To":"<20200626102531.1187650-4-naush@raspberrypi.com>","From":"David Plowman ","Date":"Fri, 26 Jun 2020 13:31:50 +0100","Message-ID":"","To":"Naushir Patuck ","Subject":"Re: [libcamera-devel] [PATCH 3/4] libcamera: ipa: raspberrypi:\n\tPopulate libcamera metadata after controller process","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11109,"web_url":"https://patchwork.libcamera.org/comment/11109/","msgid":"<20200703010431.GK12562@pendragon.ideasonboard.com>","date":"2020-07-03T01:04:31","subject":"Re: [libcamera-devel] [PATCH 3/4] libcamera: ipa: raspberrypi:\n\tPopulate libcamera metadata after controller process","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Fri, Jun 26, 2020 at 11:25:30AM +0100, Naushir Patuck wrote:\n> For control algorithms like focus, this is needed to return out the\n> the current frame focus statistics. For other algorithms, there is no\n> functional change.\n> \n> Signed-off-By: Naushir Patuck \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index bc89ab58..62730198 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -318,6 +318,8 @@ void IPARPi::processEvent(const IPAOperationData &event)\n> \t\tif (frame_count_ > mistrust_count_)\n> \t\t\tprocessStats(bufferId);\n> \n> +\t\treportMetadata();\n> +\n> \t\tIPAOperationData op;\n> \t\top.operation = RPI_IPA_ACTION_STATS_METADATA_COMPLETE;\n> \t\top.data = { bufferId & RPiIpaMask::ID };\n> @@ -336,7 +338,6 @@ void IPARPi::processEvent(const IPAOperationData &event)\n> \t\t * they are \"unreliable\".\n> \t\t */\n> \t\tprepareISP(embeddedbufferId);\n> -\t\treportMetadata();\n> \n> \t\t/* Ready to push the input buffer into the ISP. */\n> \t\tIPAOperationData op;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E5558BE905\n\tfor ;\n\tFri, 3 Jul 2020 01:04:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6EEA360C56;\n\tFri, 3 Jul 2020 03:04:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A901C603B3\n\tfor ;\n\tFri, 3 Jul 2020 03:04:37 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F2FF49CB;\n\tFri, 3 Jul 2020 03:04:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QXOe860B\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593738277;\n\tbh=cIXXFMeV35Nsk1Jx+SxHwEFKUXus1LXzrRrFx+ESGdc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=QXOe860B4lUM9ZE2rB6rKVKa3lXtzK8oWlHxKjrRYkmdgqIbEE0x/UUn1dj8ctMff\n\tMMp3xAgTLCW5g1lZk6tiy/aGxGNCBfYcaq++hdxwH3v5taEfPMWVY5ziu3p+jOPh3Q\n\tbSKrBB+8K78QL/W2vzRoQ4543AphX5bqQUcHvDpE=","Date":"Fri, 3 Jul 2020 04:04:31 +0300","From":"Laurent Pinchart ","To":"Naushir Patuck ","Message-ID":"<20200703010431.GK12562@pendragon.ideasonboard.com>","References":"<20200626102531.1187650-1-naush@raspberrypi.com>\n\t<20200626102531.1187650-4-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200626102531.1187650-4-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 3/4] libcamera: ipa: raspberrypi:\n\tPopulate libcamera metadata after controller process","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]