[{"id":10888,"web_url":"https://patchwork.libcamera.org/comment/10888/","msgid":"","date":"2020-06-26T12:30:05","subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: ipa: raspberrypi:\n\tfocus: Fix for uninitialised variable","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for this. Looks good to me!\n\nReviewed-by: David Plowman \n\nBest regards\nDavid\n\nOn Fri, 26 Jun 2020 at 11:25, Naushir Patuck wrote:\n>\n> Coverity static analysis check was reporting print_ was not initialised\n> before being used in process(). Add an explicit initialiser for print_\n> to the constructor.\n>\n> Reported-by: Coverity CID=293456\n> Signed-off-by: Naushir Patuck \n> ---\n> src/ipa/raspberrypi/controller/rpi/focus.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/raspberrypi/controller/rpi/focus.cpp b/src/ipa/raspberrypi/controller/rpi/focus.cpp\n> index 1e2b6491..4028ba56 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/focus.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/focus.cpp\n> @@ -15,7 +15,7 @@ using namespace RPi;\n> #define NAME \"rpi.focus\"\n>\n> Focus::Focus(Controller *controller)\n> - : Algorithm(controller)\n> + : Algorithm(controller), print_(false)\n> {\n> }\n>\n> --\n> 2.25.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 66398C2E66\n\tfor ;\n\tFri, 26 Jun 2020 12:30:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 31CCE609C8;\n\tFri, 26 Jun 2020 14:30:19 +0200 (CEST)","from mail-ot1-x344.google.com (mail-ot1-x344.google.com\n\t[IPv6:2607:f8b0:4864:20::344])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C69C0609C3\n\tfor ;\n\tFri, 26 Jun 2020 14:30:17 +0200 (CEST)","by mail-ot1-x344.google.com with SMTP id n5so8457477otj.1\n\tfor ;\n\tFri, 26 Jun 2020 05:30:17 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"YkNBiUjN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=ppK+F3Bt8rMruQNdRm2v7+4G2OELDEnXJlSTNv1fkN0=;\n\tb=YkNBiUjNdWFSTgte344ap/cdAGbzMzst/UFRdApdqDw4pt4P1OXi8dowEnINzhSvwp\n\tZG0HNR2baWhgVron34psNuzJuWyjATzjOtLbJJoSvAbK0U2//8WiU7kfE0PYrL+9KFNi\n\tfzW0noT2eX9An28IyjJBun2uW9690vnOpYQfSEu63F2dXc15qbov6JQvCNylEhe76UWI\n\tENU+/2fxw+nhBgDic6jy5vQKdmxiLFRIR8wbaBU8qYgPEV0nhl2nlXhzEb95ka6zn4l1\n\tm4NS5vQIwohWCxEBvDKzXaKFkKzsxcK9P8c6yt/2Sb7YNJJ6yklguH6lQpNB8gtrP4Dc\n\tARrg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=ppK+F3Bt8rMruQNdRm2v7+4G2OELDEnXJlSTNv1fkN0=;\n\tb=dzR4EknyTpHHSvqwuvPhKYGqjU0aD4SPJzFfF+/QgX/85GP8AlfvA1ZI28Mp3+DXEe\n\tmSIJEwAXpZgqq4vfxLi9GfKuzyrbjBE+NjOTZ2l7LaovEfTj8Pt5hAaylh/sS3KSVAwF\n\tMlTaIrXA0XyfY4ZKp+5cmqdihN543T3kFyqL9ddpcrUpfnZ7clfu70Qp1sPZxnN34XP9\n\tiqz0lwQMpEztvHGqsvUQfDKjaZBRPu/bSrXaEF751DudgRpWue+HTtn+h9kDMf/rEZwj\n\tASXcLOUREg7CjJ3eAI2gyc2vSuO8Qsg8rUqImDbntVdKHBdzIK+onQ16RO7NgydAQQQg\n\tyqVw==","X-Gm-Message-State":"AOAM531LKFd2+dKn7byTsGkduaqF6//ZPXE65upHeG0Klzj949Kl4YFU\n\tzuLn8qqAjrvgKwbEVZAckP6YbZ56M/I/pmN1It1iYA==","X-Google-Smtp-Source":"ABdhPJyIZEAmvpUN3OkPIaO6uFmgERTN5lpt4txakltZFSgAv+UP9laVknUN4d8JXp1M3kV7fYAEKVReYhuNqhWKwBE=","X-Received":"by 2002:a4a:5209:: with SMTP id d9mr2177595oob.28.1593174616304; \n\tFri, 26 Jun 2020 05:30:16 -0700 (PDT)","MIME-Version":"1.0","References":"<20200626102531.1187650-1-naush@raspberrypi.com>\n\t<20200626102531.1187650-3-naush@raspberrypi.com>","In-Reply-To":"<20200626102531.1187650-3-naush@raspberrypi.com>","From":"David Plowman ","Date":"Fri, 26 Jun 2020 13:30:05 +0100","Message-ID":"","To":"Naushir Patuck ","Subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: ipa: raspberrypi:\n\tfocus: Fix for uninitialised variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11108,"web_url":"https://patchwork.libcamera.org/comment/11108/","msgid":"<20200703010232.GJ12562@pendragon.ideasonboard.com>","date":"2020-07-03T01:02:32","subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: ipa: raspberrypi:\n\tfocus: Fix for uninitialised variable","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Fri, Jun 26, 2020 at 11:25:29AM +0100, Naushir Patuck wrote:\n> Coverity static analysis check was reporting print_ was not initialised\n> before being used in process(). Add an explicit initialiser for print_\n> to the constructor.\n> \n> Reported-by: Coverity CID=293456\n> Signed-off-by: Naushir Patuck \n\nThis looks good, but David submitted a patch that removes the print_\nfield, so this one won't be applicable anymore.\n\n> ---\n> src/ipa/raspberrypi/controller/rpi/focus.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/raspberrypi/controller/rpi/focus.cpp b/src/ipa/raspberrypi/controller/rpi/focus.cpp\n> index 1e2b6491..4028ba56 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/focus.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/focus.cpp\n> @@ -15,7 +15,7 @@ using namespace RPi;\n> #define NAME \"rpi.focus\"\n> \n> Focus::Focus(Controller *controller)\n> -\t: Algorithm(controller)\n> +\t: Algorithm(controller), print_(false)\n> {\n> }\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 314AFBFFE2\n\tfor ;\n\tFri, 3 Jul 2020 01:02:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F1A4B60C56;\n\tFri, 3 Jul 2020 03:02:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9B418603B3\n\tfor ;\n\tFri, 3 Jul 2020 03:02:38 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2F8929CB;\n\tFri, 3 Jul 2020 03:02:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TX3L7V5S\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593738158;\n\tbh=PBPvKJHq4jM4LHuidM8/yWvxg/rsnGl8F7RF3psAPfI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=TX3L7V5SBabWcBnUn36+C61Rk6t4egEMuO12Tod/kqfcLbvLs1lfBfbbfGz3hzJSl\n\twk6v9FVU6c114dT8KpuDPuXr5zi8itQUI8xkY31snKXV5MiP3Vf9tHqTFx6ouBAsW3\n\t4iBRAJh/k7bqzB5gh8xbZNjd4d9myPehm7sBpf/k=","Date":"Fri, 3 Jul 2020 04:02:32 +0300","From":"Laurent Pinchart ","To":"Naushir Patuck ","Message-ID":"<20200703010232.GJ12562@pendragon.ideasonboard.com>","References":"<20200626102531.1187650-1-naush@raspberrypi.com>\n\t<20200626102531.1187650-3-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200626102531.1187650-3-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: ipa: raspberrypi:\n\tfocus: Fix for uninitialised variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11115,"web_url":"https://patchwork.libcamera.org/comment/11115/","msgid":"","date":"2020-07-03T08:06:33","subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: ipa: raspberrypi:\n\tfocus: Fix for uninitialised variable","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush, Laurent\n\n\nOn Fri, 3 Jul 2020 at 02:02, Laurent Pinchart\n wrote:\n>\n> Hi Naush,\n>\n> Thank you for the patch.\n>\n> On Fri, Jun 26, 2020 at 11:25:29AM +0100, Naushir Patuck wrote:\n> > Coverity static analysis check was reporting print_ was not initialised\n> > before being used in process(). Add an explicit initialiser for print_\n> > to the constructor.\n> >\n> > Reported-by: Coverity CID=293456\n> > Signed-off-by: Naushir Patuck \n>\n> This looks good, but David submitted a patch that removes the print_\n> field, so this one won't be applicable anymore.\n\nIndeed, sorry for the churn. I think we just drop this particular\npatch and it's all good.\n\nBest regards\nDavid\n\n>\n> > ---\n> > src/ipa/raspberrypi/controller/rpi/focus.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/src/ipa/raspberrypi/controller/rpi/focus.cpp b/src/ipa/raspberrypi/controller/rpi/focus.cpp\n> > index 1e2b6491..4028ba56 100644\n> > --- a/src/ipa/raspberrypi/controller/rpi/focus.cpp\n> > +++ b/src/ipa/raspberrypi/controller/rpi/focus.cpp\n> > @@ -15,7 +15,7 @@ using namespace RPi;\n> > #define NAME \"rpi.focus\"\n> >\n> > Focus::Focus(Controller *controller)\n> > - : Algorithm(controller)\n> > + : Algorithm(controller), print_(false)\n> > {\n> > }\n> >\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 827F3BFFE2\n\tfor ;\n\tFri, 3 Jul 2020 08:06:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 10FA260C50;\n\tFri, 3 Jul 2020 10:06:46 +0200 (CEST)","from mail-oi1-x242.google.com (mail-oi1-x242.google.com\n\t[IPv6:2607:f8b0:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 87389603AD\n\tfor ;\n\tFri, 3 Jul 2020 10:06:44 +0200 (CEST)","by mail-oi1-x242.google.com with SMTP id w17so25154875oie.6\n\tfor ;\n\tFri, 03 Jul 2020 01:06:44 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"S+u5RoCT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=xeJzbLGfTxTFKP4Tc2uU5bhn+dsCaTChp24GuFZWovM=;\n\tb=S+u5RoCTSueyWFghOLPuavitm8svaW1OO0jlZgnAd1iHyY++UZ4SRC802aZTcE1jM4\n\t9DXlxwPqdJeCpl+DkmJ36UAek0iptrgAqJ16Obf1QkvoE0C0hVwt6LeheCkOPcVUXo1X\n\tQtIqs1SV/W0sAzZAmzsh8c5kjWn+3/lVGfrKP2oV1/GgL0MwAL33SXqnJ10IBoq2ij1m\n\t+oSx3LU0L1IDnLqozTJ4tCmsZK3i72NYTAcaDkVVkWXvqeOevFsbdZOqUdIoSM3uv3C7\n\t9n9KEdZyWr9MItDv1UebkNEPpiWWVeBJ9FuEu+q0cet/RYFJKBdrumM+wvL/6N19pCyE\n\te7ew==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=xeJzbLGfTxTFKP4Tc2uU5bhn+dsCaTChp24GuFZWovM=;\n\tb=uckbT59kf62XXo64cT8EllPaeaJOunTGwA59CkCCUNVLlTyFnSFr18m3aOCMQEOf6z\n\tSanAx/LlBB3PkSoiBNNckW7nfLAHDBWspR1rzwNB3WFa4XD4GTPgsp2xTnyqBV6MnM/T\n\tSm0AtXf8CgJZGdSUfj7KTaHp0W0L0p8or/VHvw1YD8bmT8KcLQaSMHSDeq4Sqv6w3Xyr\n\tYB7R5wwsR/KqE3HbLlXw6oAXXo8hyfSBY+dVjkqKmFXesRWdllhddFbuMqsKQ7GTSJoL\n\thVuif97XKxjEzVbuwgwWZeO56caAVi5Ptvsoc5TZi7wnQ2xzZ/bpCJYZySgTlOftaxdJ\n\tlx9g==","X-Gm-Message-State":"AOAM530PPfIxkTW35IWV0GBQcEsux0RIjPjQg2yuqM7jJjERwJB+OdCH\n\tj0IpMSPCAohQSoZcyDx5QclctPFcNAHXBkp4W8QDKQ==","X-Google-Smtp-Source":"ABdhPJxaQdR0u6aK3I/1dw005GaqzSnLix8Ch+iKuN089SJr5cxft4xqzK/CbAhcR2gIAswYimILp+F7Eyy64uIvhxc=","X-Received":"by 2002:aca:ac01:: with SMTP id v1mr11562329oie.22.1593763603223;\n\tFri, 03 Jul 2020 01:06:43 -0700 (PDT)","MIME-Version":"1.0","References":"<20200626102531.1187650-1-naush@raspberrypi.com>\n\t<20200626102531.1187650-3-naush@raspberrypi.com>\n\t<20200703010232.GJ12562@pendragon.ideasonboard.com>","In-Reply-To":"<20200703010232.GJ12562@pendragon.ideasonboard.com>","From":"David Plowman ","Date":"Fri, 3 Jul 2020 09:06:33 +0100","Message-ID":"","To":"Laurent Pinchart ","Subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: ipa: raspberrypi:\n\tfocus: Fix for uninitialised variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]