{"id":8418,"url":"https://patchwork.libcamera.org/api/patches/8418/?format=json","web_url":"https://patchwork.libcamera.org/patch/8418/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200624145256.48266-21-paul.elder@ideasonboard.com>","date":"2020-06-24T14:52:54","name":"[libcamera-devel,v4,20/22] v4l2: v4l2_camera_proxy: Don't allow buffers to be freed if still mmaped","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"73c40b33e45728b23a26659ccff594d7c5b638ae","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8418/mbox/","series":[{"id":1041,"url":"https://patchwork.libcamera.org/api/series/1041/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1041","date":"2020-06-24T14:52:34","name":"Support v4l2-compliance","version":4,"mbox":"https://patchwork.libcamera.org/series/1041/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8418/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8418/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4BB93609C3\n\tfor ;\n\tWed, 24 Jun 2020 16:54:03 +0200 (CEST)","from jade.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:8147:f2a2:a8c6:9087])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 87D242A8;\n\tWed, 24 Jun 2020 16:54:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"dxbNd/pX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593010443;\n\tbh=pu86KmKFVtINlzQhg6zRy5w3BRoOG280URxjslj0/zg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=dxbNd/pXVLzfG2PN2Nx+CmX1oooihXEckb+Tn+8XEfScSV6et61D12kIKap0vWKIv\n\tgUxojdshZD42N1NNxDoX8l9hY6RjLDzh90DJGECbrk2J57+kpRQB1K5dlEf34kN+ay\n\teYUYVVtk9qklhrhcIAGZnF/va6HG6BpUG4azc4Y4=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 24 Jun 2020 23:52:54 +0900","Message-Id":"<20200624145256.48266-21-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200624145256.48266-1-paul.elder@ideasonboard.com>","References":"<20200624145256.48266-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 20/22] v4l2: v4l2_camera_proxy: Don't\n\tallow buffers to be freed if still mmaped","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 24 Jun 2020 14:54:03 -0000"},"content":"In VIDIOC_REQBUFS with count = 0, if the buffers are still mmaped, they\nshould not be allowed to be freed. Add a check for this.\n\nSigned-off-by: Paul Elder \nReviewed-by: Laurent Pinchart \n\n---\nChanges in v4:\n- add todo to support buffer orphaning\n\nNo change in v3\n\nNew in v2\n- split from \"Fix v4l2-compliance streaming tests\"\n---\n src/v4l2/v4l2_camera_proxy.cpp | 4 ++++\n 1 file changed, 4 insertions(+)","diff":"diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex 2dbeef3..d5c146f 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -470,6 +470,10 @@ int V4L2CameraProxy::vidioc_reqbufs(V4L2CameraFile *file, struct v4l2_requestbuf\n \tmemset(arg->reserved, 0, sizeof(arg->reserved));\n \n \tif (arg->count == 0) {\n+\t\t/* \\todo Add buffer orphaning support */\n+\t\tif (!mmaps_.empty())\n+\t\t\treturn -EBUSY;\n+\n \t\tif (vcam_->isRunning())\n \t\t\treturn -EBUSY;\n \n","prefixes":["libcamera-devel","v4","20/22"]}