[{"id":1214,"web_url":"https://patchwork.libcamera.org/comment/1214/","msgid":"<20190402155320.GI4805@pendragon.ideasonboard.com>","date":"2019-04-02T15:53:20","subject":"Re: [libcamera-devel] [PATCH 4/4] cam: Allow cameras with more then\n\tone stream","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Tue, Apr 02, 2019 at 02:54:06AM +0200, Niklas Söderlund wrote:\n> The libcamera API and the cam tool is now ready to make use of cameras\n\ns/is now/are now/\n\n> with more then one stream. Remove the limitation in the tool which\n\ns/then/than/\n\n> disallows cameras which provides more then one stream.\n\ns/which provides/that provide/\ns/then/than/\n\nhttp://grammartips.homestead.com/than.html\n\n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/cam/main.cpp | 8 --------\n> 1 file changed, 8 deletions(-)\n> \n> diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n> index 6aed4073f70d37a2..9fb29fc8995001f6 100644\n> --- a/src/cam/main.cpp\n> +++ b/src/cam/main.cpp\n> @@ -317,14 +317,6 @@ int main(int argc, char **argv)\n> \t\t\tgoto out;\n> \t\t}\n> \n> -\t\tconst std::set &streams = camera->streams();\n> -\t\tif (streams.size() != 1) {\n> -\t\t\tstd::cout << \"Camera has \" << streams.size()\n> -\t\t\t\t << \" streams, only 1 is supported\"\n> -\t\t\t\t << std::endl;\n> -\t\t\tgoto out;\n> -\t\t}\n> -\n> \t\tif (camera->acquire()) {\n> \t\t\tstd::cout << \"Failed to acquire camera\" << std::endl;\n> \t\t\tgoto out;","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9D319600FB\n\tfor ;\n\tTue, 2 Apr 2019 17:53:31 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 268022F9;\n\tTue, 2 Apr 2019 17:53:31 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1554220411;\n\tbh=DFaQFCI3X/eyxZCLH7RsaWfSbGrTprH7Xq0EIfsEzSI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=KhSKzYW8Qbd9m2iswUFD3sZxAk4bqwjsjc1ddJsnyn2Id2rLqFCB1qZTU/m2R+QOd\n\tkqY/9nf6mIrcXNupmxJ7sW8QZd9KbiXOTh9jPmlRKAlK0MA+KQNUuzsxddxnAruIDO\n\tlTmCMIj1lwWihld8ZgAS/4qGojUdvT3N5aP8N2Tk=","Date":"Tue, 2 Apr 2019 18:53:20 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190402155320.GI4805@pendragon.ideasonboard.com>","References":"<20190402005406.25097-1-niklas.soderlund@ragnatech.se>\n\t<20190402005406.25097-5-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190402005406.25097-5-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 4/4] cam: Allow cameras with more then\n\tone stream","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 02 Apr 2019 15:53:31 -0000"}}]