[{"id":1207,"web_url":"https://patchwork.libcamera.org/comment/1207/","msgid":"<20190402142632.GB4805@pendragon.ideasonboard.com>","date":"2019-04-02T14:26:32","subject":"Re: [libcamera-devel] [RFC 3/5] test: camera: Remove test for bad\n\tStream IDs","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Tue, Apr 02, 2019 at 02:53:30AM +0200, Niklas Söderlund wrote:\n> In preparation of reworking how a default configuration is retrieved\n> from a camera remove test that stream IDs must be valid as the data type\n> passed to Camera::streamConfiguration() will change. This change is in\n> preparation for a invasive change.\n\ns/a invasive/an invasive/\n\n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> test/camera/configuration_default.cpp | 13 -------------\n> 1 file changed, 13 deletions(-)\n> \n> diff --git a/test/camera/configuration_default.cpp b/test/camera/configuration_default.cpp\n> index 53ee021d33ca39b1..856cd415f7a6aec1 100644\n> --- a/test/camera/configuration_default.cpp\n> +++ b/test/camera/configuration_default.cpp\n> @@ -49,19 +49,6 @@ protected:\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> -\t\t/*\n> -\t\t * Test that asking for configuration for an array of bad streams\n> -\t\t * returns an empty list of configurations.\n> -\t\t */\n> -\t\tStream *stream_bad = reinterpret_cast(0xdeadbeef);\n> -\t\tstd::set streams_bad = { stream_bad };\n> -\t\tconf = camera_->streamConfiguration(streams_bad);\n> -\t\tif (!conf.empty()) {\n> -\t\t\tcout << \"Failed to retrieve configuration for bad streams\"\n> -\t\t\t << endl;\n> -\t\t\treturn TestFail;\n> -\t\t}\n> -\n> \t\treturn TestPass;\n> \t}\n> };","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7C1D8600FB\n\tfor ;\n\tTue, 2 Apr 2019 16:26:43 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C5FC12F9;\n\tTue, 2 Apr 2019 16:26:42 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1554215203;\n\tbh=1ENzsxyyCS1PHbWhErLP7D84/q9yAA1Aiza7hHFH14s=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=b32Cf/Qr9fdiwhIqIwYVvVP61thAE4iKlhgdfHpljCMMW/I8kIN6fnAtMNuow1JMY\n\tNipLl9EcYtpvxDmK8iARfikElj30SkYCw5Epn0sDuf7sKzgXVKdgZrrrxS8srmPjQw\n\taU/ZgWL51jXHwncyv8MjwfL6pxzEnuCFXPpcW77o=","Date":"Tue, 2 Apr 2019 17:26:32 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190402142632.GB4805@pendragon.ideasonboard.com>","References":"<20190402005332.25018-1-niklas.soderlund@ragnatech.se>\n\t<20190402005332.25018-4-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190402005332.25018-4-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [RFC 3/5] test: camera: Remove test for bad\n\tStream IDs","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 02 Apr 2019 14:26:43 -0000"}}]