[{"id":1152,"web_url":"https://patchwork.libcamera.org/comment/1152/","msgid":"<20190329143707.GB4934@pendragon.ideasonboard.com>","date":"2019-03-29T14:37:07","subject":"Re: [libcamera-devel] [PATCH] libcamera: stream: Qualify 'Camera'\n\tfriend directive","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Fri, Mar 29, 2019 at 12:13:07PM +0100, Jacopo Mondi wrote:\n> Align the Stream class to all other classes in the code base to use the\n> 'class' qualifier in 'friend' declarations.\n> \n> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  include/libcamera/stream.h | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\n> index 24407cb65361..970c479627fa 100644\n> --- a/include/libcamera/stream.h\n> +++ b/include/libcamera/stream.h\n> @@ -29,7 +29,7 @@ public:\n>  \tconst StreamConfiguration &configuration() const { return configuration_; }\n> \n>  private:\n> -\tfriend Camera;\n> +\tfriend class Camera;\n> \n>  \tBufferPool bufferPool_;\n>  \tStreamConfiguration configuration_;","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4EFC6600FB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 29 Mar 2019 15:37:18 +0100 (CET)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DE8729A3;\n\tFri, 29 Mar 2019 15:37:17 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1553870238;\n\tbh=FlEF4XD4CfelEynIwDBQHD7TakEqMCBUnCYJ0yfdMWw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=usKvYGpzugC2oc5KvVRq4KkQHgRw59exoPkMci2Ihde5QzPbM8ZkhfbelfwbBk5C/\n\tmuIXf/WX1CocT/mp5vopFrMqULtKgANcClVvDAFJgVrQP9rh/u+EtIenUc5kgrmlOt\n\t9/57iPf0Tw2O/rfMTKbftcxTjZInwpox0nZpcVWA=","Date":"Fri, 29 Mar 2019 16:37:07 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Jacopo Mondi <jacopo@jmondi.org>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190329143707.GB4934@pendragon.ideasonboard.com>","References":"<20190329111307.16656-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190329111307.16656-1-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: stream: Qualify 'Camera'\n\tfriend directive","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 29 Mar 2019 14:37:18 -0000"}}]