[{"id":1190,"web_url":"https://patchwork.libcamera.org/comment/1190/","msgid":"<20190402105514.GN4805@pendragon.ideasonboard.com>","date":"2019-04-02T10:55:14","subject":"Re: [libcamera-devel] [PATCH v5 18/19] libcamera: ipu3: Limit\n\tresolution to 2560x1920","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Mar 26, 2019 at 09:39:01AM +0100, Jacopo Mondi wrote:\n> As the procedure to configure the intermediate sizes and the alignement\n> requirements of the ImgU device have not been clarified yet, return as\n> default configuration the (2560x1920) resolution that has been validated\n> for both cameras.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 14 ++++++++++----\n> 1 file changed, 10 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 7b7baa5ac5fb..66efcc37d695 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -248,11 +248,17 @@ PipelineHandlerIPU3::streamConfiguration(Camera *camera,\n> \tstd::map configs;\n> \tIPU3CameraData *data = cameraData(camera);\n> \tStreamConfiguration *config = &configs[&data->stream_];\n> -\tCIO2Device *cio2 = &data->cio2_;\n> -\tSizeRange &maxRange = cio2->maxSizes_.second;\n> \n> -\tconfig->width = maxRange.maxWidth;\n> -\tconfig->height = maxRange.maxHeight;\n> +\t/*\n> +\t * FIXME: Soraka: the maximum resolution reported by both sensors\n> +\t * (2592x1944 for ov5670 and 4224x3136 for ov13858) are returned as\n> +\t * default configurations but they're not correctly processed by the\n> +\t * ImgU. Resolutions up tp 2560x1920 have been validated.\n> +\t *\n> +\t * \\todo Clarify ImgU alignement requirements.\n> +\t */\n> +\tconfig->width = 2560;\n> +\tconfig->height = 1920;\n> \tconfig->pixelFormat = V4L2_PIX_FMT_NV12;\n> \tconfig->bufferCount = IPU3_BUFFER_COUNT;\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1F813600FB\n\tfor ;\n\tTue, 2 Apr 2019 12:55:26 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7E21C2F9;\n\tTue, 2 Apr 2019 12:55:25 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1554202525;\n\tbh=3ZcTmj530JA70isGNL74eIT0ruFs8q9d5qQg+6/jAug=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=YH+hdmQyDEFNFgpJGZ1LwJ4DgupDVrH5s4nuXa2SXR7pmuU5wvIKJ30omeKkq5OOX\n\texa1DELR+pIteYYaibzcmuXEkl0zsB93f2FZHEdtjWCn4xOlObSKJ+BMIyBVmefbQg\n\tdAEwU4VJOkwAAfTcAkOlv89roFPMgvk/e/Okd8Ro=","Date":"Tue, 2 Apr 2019 13:55:14 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190402105514.GN4805@pendragon.ideasonboard.com>","References":"<20190326083902.26121-1-jacopo@jmondi.org>\n\t<20190326083902.26121-19-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190326083902.26121-19-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v5 18/19] libcamera: ipu3: Limit\n\tresolution to 2560x1920","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 02 Apr 2019 10:55:26 -0000"}},{"id":1199,"web_url":"https://patchwork.libcamera.org/comment/1199/","msgid":"<20190402114143.GS23466@bigcity.dyn.berto.se>","date":"2019-04-02T11:41:44","subject":"Re: [libcamera-devel] [PATCH v5 18/19] libcamera: ipu3: Limit\n\tresolution to 2560x1920","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2019-03-26 09:39:01 +0100, Jacopo Mondi wrote:\n> As the procedure to configure the intermediate sizes and the alignement\n> requirements of the ImgU device have not been clarified yet, return as\n> default configuration the (2560x1920) resolution that has been validated\n> for both cameras.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 14 ++++++++++----\n> 1 file changed, 10 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 7b7baa5ac5fb..66efcc37d695 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -248,11 +248,17 @@ PipelineHandlerIPU3::streamConfiguration(Camera *camera,\n> \tstd::map configs;\n> \tIPU3CameraData *data = cameraData(camera);\n> \tStreamConfiguration *config = &configs[&data->stream_];\n> -\tCIO2Device *cio2 = &data->cio2_;\n> -\tSizeRange &maxRange = cio2->maxSizes_.second;\n> \n> -\tconfig->width = maxRange.maxWidth;\n> -\tconfig->height = maxRange.maxHeight;\n> +\t/*\n> +\t * FIXME: Soraka: the maximum resolution reported by both sensors\n> +\t * (2592x1944 for ov5670 and 4224x3136 for ov13858) are returned as\n> +\t * default configurations but they're not correctly processed by the\n> +\t * ImgU. Resolutions up tp 2560x1920 have been validated.\n> +\t *\n> +\t * \\todo Clarify ImgU alignement requirements.\n> +\t */\n> +\tconfig->width = 2560;\n> +\tconfig->height = 1920;\n> \tconfig->pixelFormat = V4L2_PIX_FMT_NV12;\n> \tconfig->bufferCount = IPU3_BUFFER_COUNT;\n> \n> -- \n> 2.21.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x136.google.com (mail-lf1-x136.google.com\n\t[IPv6:2a00:1450:4864:20::136])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 72D8360DB3\n\tfor ;\n\tTue, 2 Apr 2019 13:41:45 +0200 (CEST)","by mail-lf1-x136.google.com with SMTP id v71so3913268lfa.11\n\tfor ;\n\tTue, 02 Apr 2019 04:41:45 -0700 (PDT)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\te64sm2735082ljf.75.2019.04.02.04.41.44\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 02 Apr 2019 04:41:44 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=M3Yx/VZGh9N48ahrYBMlFBK30YI5Ofhp9iEOtapjS44=;\n\tb=URexbWV5dGVozG/0gQcRST8bI+Gf7dgySNSqg4eESUaiH+PrQRHBqhsuBgX7Vm7KyM\n\tC8PuarJ3wLJ628V1qw+Ai6OHFrcvoGuTxTJ/Mi3KZrbAlTqs7ikQZbznZ8wLk3eQgoCd\n\tf+uBf6YYwpqdWG0PqlD1atS8LSuQBgf8gWOG8n/RuD4/zV1eFk7S0PW/pa0YtgDR3dV7\n\t/dTJCo4muTSxe5tkaoqJWZdiIkNn0Pd6mQwYYLObxak3snBUFy44hsggc9WlCuQWv02u\n\tZpIUShPUQB9T7X5KlciW4KpAy6xrfHdbOU0RNuEOV5bavyf4/eRx3lAAabfSMO184EAh\n\t/LeQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=M3Yx/VZGh9N48ahrYBMlFBK30YI5Ofhp9iEOtapjS44=;\n\tb=dGtWZ0AUDpggskOg2s1wR0+bBaOmybW4Ej2h+/jp0W2COOyrthGnbM7WJJa6G98qYX\n\tG+YQMA3E3ZFAFoVc+F8qbgPAawH2+F98YakitZSm9xifTWiBvuohvEb9uCwPntcXsI83\n\tjXHK/9exPNs1rZOjn94HF/FocOa/cYisiGwtK/uaHUrAa4TgfU4fDf2+Lkk7kl/gXn8c\n\tClo6NPvFDSWG946o/GHmW1yPExfuydSRlrfSUddzoLw3vq+eDCP7e4BCCAfhJZaZKd2r\n\t1pqKiJLR18+gPNeEyEMe/uOJML1NVJiZPY2dZA9HYoUUiarg8D3UHf2LPYBHULazoHw9\n\tVH7Q==","X-Gm-Message-State":"APjAAAWLTbRY3UhyVEHSCerw1/yLu9+cGCRJcOaDJJCKzFw0eafv8VL+\n\tT86lspDGgaTH/F35Rm1k8jX3Sw==","X-Google-Smtp-Source":"APXvYqznAbejmLViBFhhCn/y5BzTEAAoITrjdQQfyuoDVElOa56HicTlJn5KtI5NevLLPvvHna5ViA==","X-Received":"by 2002:a19:9794:: with SMTP id\n\tz142mr37588905lfd.46.1554205304960; \n\tTue, 02 Apr 2019 04:41:44 -0700 (PDT)","Date":"Tue, 2 Apr 2019 13:41:44 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190402114143.GS23466@bigcity.dyn.berto.se>","References":"<20190326083902.26121-1-jacopo@jmondi.org>\n\t<20190326083902.26121-19-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190326083902.26121-19-jacopo@jmondi.org>","User-Agent":"Mutt/1.11.3 (2019-02-01)","Subject":"Re: [libcamera-devel] [PATCH v5 18/19] libcamera: ipu3: Limit\n\tresolution to 2560x1920","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 02 Apr 2019 11:41:45 -0000"}}]