{"id":813,"url":"https://patchwork.libcamera.org/api/patches/813/?format=json","web_url":"https://patchwork.libcamera.org/patch/813/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190326083902.26121-19-jacopo@jmondi.org>","date":"2019-03-26T08:39:01","name":"[libcamera-devel,v5,18/19] libcamera: ipu3: Limit resolution to 2560x1920","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"61dddf4fdfa8826a178b4f3932bd217978d09cc9","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/813/mbox/","series":[{"id":219,"url":"https://patchwork.libcamera.org/api/series/219/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=219","date":"2019-03-26T08:38:43","name":"libcamera: ipu3: Add ImgU support","version":5,"mbox":"https://patchwork.libcamera.org/series/219/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/813/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/813/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7BBD261112\n\tfor ;\n\tTue, 26 Mar 2019 09:38:42 +0100 (CET)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 1011A24000A;\n\tTue, 26 Mar 2019 08:38:41 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 26 Mar 2019 09:39:01 +0100","Message-Id":"<20190326083902.26121-19-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190326083902.26121-1-jacopo@jmondi.org>","References":"<20190326083902.26121-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v5 18/19] libcamera: ipu3: Limit\n\tresolution to 2560x1920","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 26 Mar 2019 08:38:42 -0000"},"content":"As the procedure to configure the intermediate sizes and the alignement\nrequirements of the ImgU device have not been clarified yet, return as\ndefault configuration the (2560x1920) resolution that has been validated\nfor both cameras.\n\nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 14 ++++++++++----\n 1 file changed, 10 insertions(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 7b7baa5ac5fb..66efcc37d695 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -248,11 +248,17 @@ PipelineHandlerIPU3::streamConfiguration(Camera *camera,\n \tstd::map configs;\n \tIPU3CameraData *data = cameraData(camera);\n \tStreamConfiguration *config = &configs[&data->stream_];\n-\tCIO2Device *cio2 = &data->cio2_;\n-\tSizeRange &maxRange = cio2->maxSizes_.second;\n \n-\tconfig->width = maxRange.maxWidth;\n-\tconfig->height = maxRange.maxHeight;\n+\t/*\n+\t * FIXME: Soraka: the maximum resolution reported by both sensors\n+\t * (2592x1944 for ov5670 and 4224x3136 for ov13858) are returned as\n+\t * default configurations but they're not correctly processed by the\n+\t * ImgU. Resolutions up tp 2560x1920 have been validated.\n+\t *\n+\t * \\todo Clarify ImgU alignement requirements.\n+\t */\n+\tconfig->width = 2560;\n+\tconfig->height = 1920;\n \tconfig->pixelFormat = V4L2_PIX_FMT_NV12;\n \tconfig->bufferCount = IPU3_BUFFER_COUNT;\n \n","prefixes":["libcamera-devel","v5","18/19"]}