[{"id":1198,"web_url":"https://patchwork.libcamera.org/comment/1198/","msgid":"<20190402114050.GR23466@bigcity.dyn.berto.se>","date":"2019-04-02T11:40:50","subject":"Re: [libcamera-devel] [PATCH v5 17/19] libcamera: ipu3: Use NV12 as\n\tdefault image format","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2019-03-26 09:39:00 +0100, Jacopo Mondi wrote:\n> Now that images come from the ImgU output, hardcode NV12 as default\n> output format.\n> \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 7a5e715458ae..7b7baa5ac5fb 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -253,13 +253,13 @@ PipelineHandlerIPU3::streamConfiguration(Camera *camera,\n> \n> \tconfig->width = maxRange.maxWidth;\n> \tconfig->height = maxRange.maxHeight;\n> -\tconfig->pixelFormat = cio2->maxSizes_.first;\n> +\tconfig->pixelFormat = V4L2_PIX_FMT_NV12;\n> \tconfig->bufferCount = IPU3_BUFFER_COUNT;\n> \n> \tLOG(IPU3, Debug)\n> \t\t<< \"Stream format set to: \" << config->width << \"x\"\n> \t\t<< config->height << \"-0x\" << std::hex << std::setfill('0')\n> -\t\t<< std::setw(4) << config->pixelFormat;\n> +\t\t<< std::setw(8) << config->pixelFormat;\n> \n> \treturn configs;\n> }\n> -- \n> 2.21.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x133.google.com (mail-lf1-x133.google.com\n\t[IPv6:2a00:1450:4864:20::133])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7FABC60DB3\n\tfor ;\n\tTue, 2 Apr 2019 13:40:52 +0200 (CEST)","by mail-lf1-x133.google.com with SMTP id a28so8733037lfo.7\n\tfor ;\n\tTue, 02 Apr 2019 04:40:52 -0700 (PDT)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tb7sm2773476ljb.6.2019.04.02.04.40.51\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 02 Apr 2019 04:40:51 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=SEwqnYJLDA9fS6w3/7yNAXi7NjqvWJ4PoZoZNNCXTfg=;\n\tb=Yf+17l4TT0ZvvFyoFsPWcnOQf4QGE/J6GgvtQecPiu0NKCZs3gTOiud9GwPZoSYMUq\n\tK7M3WWALsrP6nQiMD7qnjJ5Zk4uim7SfCi51VKQzrCUbl57NMdyjv6d+3DPJk331PoVG\n\tVL/RR9rnJM6RbTD5WkB1rh9IP6sbEAmPjSUEOLfYQS6OveArtz8zFvm76nDLDQdI7L4a\n\ti9xjxtMk+ajnis0iIaRyev0gb2V4+U7SPP8ohE68URHgsPcquRrgHqY1wo6wv6dnryCp\n\tuVH53uAxb1W+sTRqdH3835Oj/chSEovcY4wVj9OMiklPnP5ZPu8xfNboGgkQ5nZWVzpC\n\tTnLw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=SEwqnYJLDA9fS6w3/7yNAXi7NjqvWJ4PoZoZNNCXTfg=;\n\tb=KyJ53pEj+v938rua7bco/pxxKyF1Nu+adXdLUUrMFX/5H+OJ0wYbg/1tN03ZHK1ZU8\n\tejCQiMUBiC/5bd5eaDgSFBsvIfi9V+64UOyE0pT3vLP3IMYJs3z/m3e93jF92ThnmExc\n\t1elWHmpqykJuQBmFjYKSTWrpXhJoFWbcE7d2ZbwAKXsv8VEj7ICT4foBcS30P4biKYEp\n\tAc2AXKZEzYvM4wWq5aH6nXKzSzUvZkiLKY2I+plteNFJLHBKCpbW0lqcEmXECI49FRNr\n\t5FA6wcaRIT4/9mfmXESkOcc3cH+dF3bENqVyGIXw/OmP0UdbEB3NmQkgezfxEYbw24Cp\n\tiGKw==","X-Gm-Message-State":"APjAAAWIbHcyM+iQ2VYQILa8Oyt+AVb7PqhQz93OysvHpU2dd/W4AZkZ\n\tyo7S8JdFahLD5OUxmjwjUa7iRQ==","X-Google-Smtp-Source":"APXvYqwWRPpFHAZ70fWnrt/NkWXi1CGu/BoFb+UGOnkSeD4Ji2JdcIrAQ4YIfpmNlkmMJj9kyPEKtQ==","X-Received":"by 2002:a19:e003:: with SMTP id x3mr37160666lfg.66.1554205252036;\n\tTue, 02 Apr 2019 04:40:52 -0700 (PDT)","Date":"Tue, 2 Apr 2019 13:40:50 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190402114050.GR23466@bigcity.dyn.berto.se>","References":"<20190326083902.26121-1-jacopo@jmondi.org>\n\t<20190326083902.26121-18-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190326083902.26121-18-jacopo@jmondi.org>","User-Agent":"Mutt/1.11.3 (2019-02-01)","Subject":"Re: [libcamera-devel] [PATCH v5 17/19] libcamera: ipu3: Use NV12 as\n\tdefault image format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 02 Apr 2019 11:40:52 -0000"}}]