[{"id":1182,"web_url":"https://patchwork.libcamera.org/comment/1182/","msgid":"<20190402102621.GK4805@pendragon.ideasonboard.com>","date":"2019-04-02T10:26:21","subject":"Re: [libcamera-devel] [PATCH v5 15/19] libcamera: ipu3: Queue\n\trequests to ImgU","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Mar 26, 2019 at 09:38:58AM +0100, Jacopo Mondi wrote:\n> Implement queueRequest for the IPU3 pipeline manager. When a request is\n> queued, a new buffer is queued to the ImgU output for capture.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 5b3c44174566..9e8a20849ed0 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -414,9 +414,10 @@ void PipelineHandlerIPU3::stop(Camera *camera)\n> int PipelineHandlerIPU3::queueRequest(Camera *camera, Request *request)\n> {\n> \tIPU3CameraData *data = cameraData(camera);\n> -\tV4L2Device *cio2 = data->cio2_.output_;\n> +\tV4L2Device *output = data->imgu_->output_;\n> \tStream *stream = &data->stream_;\n> \n> +\t/* Queue a buffer to the ImgU output for capture. */\n> \tBuffer *buffer = request->findBuffer(stream);\n> \tif (!buffer) {\n> \t\tLOG(IPU3, Error)\n> @@ -424,7 +425,7 @@ int PipelineHandlerIPU3::queueRequest(Camera *camera, Request *request)\n> \t\treturn -ENOENT;\n> \t}\n> \n> -\tint ret = cio2->queueBuffer(buffer);\n> +\tint ret = output->queueBuffer(buffer);\n> \tif (ret < 0)\n> \t\treturn ret;\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DBA1F600FB\n\tfor ;\n\tTue, 2 Apr 2019 12:26:32 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 53CE62F9;\n\tTue, 2 Apr 2019 12:26:32 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1554200792;\n\tbh=dxXqZWvTXJps1hrJc6wLHmOf+auElF0ZpC06+8VKjFk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=nYTK45jFO3tN8me7Za9YRKLAOLBWXJf/rM9D63Mi6EriqDmoEP/wtNzoWcpCgiAiX\n\tIQReeOWLFsolCpQmgpKPaiGE4HmovfZu2sWnb/67h/rSENbXcHRKWPJgcw6Nk/vrJ/\n\tshfJjH3uLzKtTSbrXBMdpi+q+lGNH6ovhVeKSRVY=","Date":"Tue, 2 Apr 2019 13:26:21 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190402102621.GK4805@pendragon.ideasonboard.com>","References":"<20190326083902.26121-1-jacopo@jmondi.org>\n\t<20190326083902.26121-16-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190326083902.26121-16-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v5 15/19] libcamera: ipu3: Queue\n\trequests to ImgU","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 02 Apr 2019 10:26:33 -0000"}},{"id":1196,"web_url":"https://patchwork.libcamera.org/comment/1196/","msgid":"<20190402113746.GP23466@bigcity.dyn.berto.se>","date":"2019-04-02T11:37:46","subject":"Re: [libcamera-devel] [PATCH v5 15/19] libcamera: ipu3: Queue\n\trequests to ImgU","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2019-03-26 09:38:58 +0100, Jacopo Mondi wrote:\n> Implement queueRequest for the IPU3 pipeline manager. When a request is\n> queued, a new buffer is queued to the ImgU output for capture.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 5b3c44174566..9e8a20849ed0 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -414,9 +414,10 @@ void PipelineHandlerIPU3::stop(Camera *camera)\n> int PipelineHandlerIPU3::queueRequest(Camera *camera, Request *request)\n> {\n> \tIPU3CameraData *data = cameraData(camera);\n> -\tV4L2Device *cio2 = data->cio2_.output_;\n> +\tV4L2Device *output = data->imgu_->output_;\n> \tStream *stream = &data->stream_;\n> \n> +\t/* Queue a buffer to the ImgU output for capture. */\n> \tBuffer *buffer = request->findBuffer(stream);\n> \tif (!buffer) {\n> \t\tLOG(IPU3, Error)\n> @@ -424,7 +425,7 @@ int PipelineHandlerIPU3::queueRequest(Camera *camera, Request *request)\n> \t\treturn -ENOENT;\n> \t}\n> \n> -\tint ret = cio2->queueBuffer(buffer);\n> +\tint ret = output->queueBuffer(buffer);\n> \tif (ret < 0)\n> \t\treturn ret;\n> \n> -- \n> 2.21.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D1D4F60DB3\n\tfor ;\n\tTue, 2 Apr 2019 13:37:47 +0200 (CEST)","by mail-lf1-x143.google.com with SMTP id y18so8744332lfe.1\n\tfor ;\n\tTue, 02 Apr 2019 04:37:47 -0700 (PDT)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tm23sm2747790ljh.93.2019.04.02.04.37.46\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 02 Apr 2019 04:37:46 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=Q8+DChYz4UBpLlOmYic1zR1og97n9bpBzbxNglROqFI=;\n\tb=D0sc9+wyJ0Q6Cud/vLyjjbXrthLTJwOeqqaxYl+hzlUXA2Zv7fQv5277WPCpJmrUdN\n\tivrZ49S2QDOPf3vFdOsiz4uaz8gkyWQrOLurFPZb24c6P75o0NfTZWhr2HbkPhOd9tAv\n\t5qfROMftslTHaTda6OS8IaBltq31ds8P4AJ5FdhAyy2URk2ZS6g/ze0fFvYTJgP4NWMG\n\tpmuzpnm1p2vraxCJds57LNqZNOIg8y75/dGSmCrOSLxWqZg7H7+rw+1kVhFkvTLI6igp\n\trwj8RsP+6vx++hWbKX28CSkW+8SUfjmxF1suzLM1nSMkPSZhgQX1D+eUqMZZGVMjZT6N\n\t22uA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=Q8+DChYz4UBpLlOmYic1zR1og97n9bpBzbxNglROqFI=;\n\tb=K5WgDXkUrUHjXMFL4CCJuJ9DYdrUsOVULHd0fAnly+LWSIt/OEMureF4fODnYdapaU\n\taGw3zfgMcOCAf2WW1y7/nmJurs3R06xKUmjHcrPWmeLmUuZ3TjqLqTcFeiMpjaDLJAeA\n\tMoniaF3bOOE0dE6Yx51KOlVgTPZz32DIls3N+7xbZX2Ji6+WgO99jl+iTMDzZ9dlwhxa\n\t9EwpJIuCEcf+dtwt9m02IQTsjzwpVHxcY/wfeezaiD+ifonGGBNkkRcza1XMDsVr460j\n\tOpx/hvSXTkOd+AZVV9vDUby8HEqE8cRe906sTTxe5rpP4miBEp/0Aow79ZBTGkPIzPHM\n\tm9ow==","X-Gm-Message-State":"APjAAAWAu1lGwc+yzEcLnEIalvBS9mswqh9pbuFgPBu1kOe5YsV2qrlK\n\tLpUUZSd3HYQVPvFJS+wrh98SQA==","X-Google-Smtp-Source":"APXvYqzuL69V07/k2AaT8UbSGive7HX1L8mvLY98CKT6dySew+PKpsQVmdRAeMnSrzTj8sR21WxvcQ==","X-Received":"by 2002:a19:f703:: with SMTP id z3mr19539560lfe.15.1554205067339;\n\tTue, 02 Apr 2019 04:37:47 -0700 (PDT)","Date":"Tue, 2 Apr 2019 13:37:46 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190402113746.GP23466@bigcity.dyn.berto.se>","References":"<20190326083902.26121-1-jacopo@jmondi.org>\n\t<20190326083902.26121-16-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190326083902.26121-16-jacopo@jmondi.org>","User-Agent":"Mutt/1.11.3 (2019-02-01)","Subject":"Re: [libcamera-devel] [PATCH v5 15/19] libcamera: ipu3: Queue\n\trequests to ImgU","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 02 Apr 2019 11:37:48 -0000"}}]