[{"id":1162,"web_url":"https://patchwork.libcamera.org/comment/1162/","msgid":"<20190401215704.GL4787@pendragon.ideasonboard.com>","date":"2019-04-01T21:57:04","subject":"Re: [libcamera-devel] [PATCH v5 04/19] libcamera: geometry: Add\n\ttoString to Rectangle","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Mar 26, 2019 at 09:38:47AM +0100, Jacopo Mondi wrote:\n> Add toString() helpers to pretty print out the sizes of a Rectangle.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/geometry.cpp | 16 ++++++++++++++++\n> src/libcamera/include/geometry.h | 4 ++++\n> 2 files changed, 20 insertions(+)\n> \n> diff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\n> index dbc37ca8e3f4..f76001d94562 100644\n> --- a/src/libcamera/geometry.cpp\n> +++ b/src/libcamera/geometry.cpp\n> @@ -5,6 +5,8 @@\n> * geometry.cpp - Geometry-related structures\n> */\n> \n> +#include \n> +\n> #include \"geometry.h\"\n> \n> /**\n> @@ -46,6 +48,20 @@ namespace libcamera {\n> * \\brief The distance between the top and bottom sides\n> */\n> \n> +/**\n> + * \\brief Assemble and return a string describing the rectangle\n> + *\n> + * \\return A string describing the Rectangle\n> + */\n> +const std::string Rectangle::toString() const\n> +{\n> +\tstd::stringstream ss;\n> +\n> +\tss << \"(\" << x << \"x\" << y << \")/\" << w << \"x\" << h;\n> +\n> +\treturn ss.str();\n> +}\n> +\n> /**\n> * \\struct SizeRange\n> * \\brief Describe a range of image sizes\n> diff --git a/src/libcamera/include/geometry.h b/src/libcamera/include/geometry.h\n> index 749746495204..567a54299b24 100644\n> --- a/src/libcamera/include/geometry.h\n> +++ b/src/libcamera/include/geometry.h\n> @@ -8,6 +8,8 @@\n> #ifndef __LIBCAMERA_GEOMETRY_H__\n> #define __LIBCAMERA_GEOMETRY_H__\n> \n> +#include \n> +\n> namespace libcamera {\n> \n> struct Rectangle {\n> @@ -15,6 +17,8 @@ struct Rectangle {\n> \tint y;\n> \tunsigned int w;\n> \tunsigned int h;\n> +\n> +\tconst std::string toString() const;\n> };\n> \n> struct SizeRange {","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EE8DD610B3\n\tfor ;\n\tMon, 1 Apr 2019 23:57:15 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 899E1542;\n\tMon, 1 Apr 2019 23:57:15 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1554155835;\n\tbh=kmzTCo4v/g4UdUGV/bS4gV+r+cJlXfgb4vdgcIpHpGg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=QUWNtKFYss4M1cUld1aZw9W/jpbcIORQcgNVHCvHgiaYziTI25jC0n4V75O4aDd+b\n\tvCj2kJRm0fDwZjs8xbblGShYahkBXkckaRZFxmx6k7ymsIxgJ4yTL5pKBCJLLod4r+\n\tiAN++Ejx0F7uRW/ygKPWiLNuvi4nc10gNot6oePg=","Date":"Tue, 2 Apr 2019 00:57:04 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190401215704.GL4787@pendragon.ideasonboard.com>","References":"<20190326083902.26121-1-jacopo@jmondi.org>\n\t<20190326083902.26121-5-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190326083902.26121-5-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v5 04/19] libcamera: geometry: Add\n\ttoString to Rectangle","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 01 Apr 2019 21:57:16 -0000"}}]