{"id":798,"url":"https://patchwork.libcamera.org/api/patches/798/?format=json","web_url":"https://patchwork.libcamera.org/patch/798/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190326083902.26121-4-jacopo@jmondi.org>","date":"2019-03-26T08:38:46","name":"[libcamera-devel,v5,03/19] libcamera: geometry: Add 0-initialized SizeRange constructor","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"a110acfd09cf72a09186cd591054cfbe894638a7","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/798/mbox/","series":[{"id":219,"url":"https://patchwork.libcamera.org/api/series/219/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=219","date":"2019-03-26T08:38:43","name":"libcamera: ipu3: Add ImgU support","version":5,"mbox":"https://patchwork.libcamera.org/series/219/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/798/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/798/checks/","tags":{},"headers":{"Return-Path":"<jacopo@jmondi.org>","Received":["from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DAADD611A7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 26 Mar 2019 09:38:31 +0100 (CET)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 626EA24000C;\n\tTue, 26 Mar 2019 08:38:31 +0000 (UTC)"],"From":"Jacopo Mondi <jacopo@jmondi.org>","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 26 Mar 2019 09:38:46 +0100","Message-Id":"<20190326083902.26121-4-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190326083902.26121-1-jacopo@jmondi.org>","References":"<20190326083902.26121-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v5 03/19] libcamera: geometry: Add\n\t0-initialized SizeRange constructor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Tue, 26 Mar 2019 08:38:32 -0000"},"content":"Add constructor to SizeRange which initialize all the size range fields\nto 0.\n\nWhile at there make the in-line constructor declarations respect the\ncoding style by moving braces to a new line.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/geometry.cpp       | 11 ++++++++++-\n src/libcamera/include/geometry.h |  9 ++++++++-\n 2 files changed, 18 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\nindex b6b6592bdfec..dbc37ca8e3f4 100644\n--- a/src/libcamera/geometry.cpp\n+++ b/src/libcamera/geometry.cpp\n@@ -57,7 +57,16 @@ namespace libcamera {\n \n /**\n  * \\fn SizeRange::SizeRange()\n- * \\brief Construct a size range\n+ * \\brief Construct a size range initialized to 0\n+ */\n+\n+/**\n+ * \\fn SizeRange::SizeRange(unsigned int minW, unsigned int minH, unsigned int maxW, unsigned int maxH)\n+ * \\brief Construct an initialized size range\n+ * \\param minW The minimum width\n+ * \\param minH The minimum height\n+ * \\param maxW The maximum width\n+ * \\param maxH The maximum height\n  */\n \n /**\ndiff --git a/src/libcamera/include/geometry.h b/src/libcamera/include/geometry.h\nindex eadc4ed4f9cb..749746495204 100644\n--- a/src/libcamera/include/geometry.h\n+++ b/src/libcamera/include/geometry.h\n@@ -18,10 +18,17 @@ struct Rectangle {\n };\n \n struct SizeRange {\n+\tSizeRange(void)\n+\t\t: SizeRange(0, 0, 0, 0)\n+\t{\n+\t}\n+\n \tSizeRange(unsigned int minW, unsigned int minH,\n \t\t  unsigned int maxW, unsigned int maxH)\n \t\t: minWidth(minW), minHeight(minH), maxWidth(maxW),\n-\t\t  maxHeight(maxH) {}\n+\t\t  maxHeight(maxH)\n+\t{\n+\t}\n \n \tunsigned int minWidth;\n \tunsigned int minHeight;\n","prefixes":["libcamera-devel","v5","03/19"]}