{"id":786,"url":"https://patchwork.libcamera.org/api/patches/786/?format=json","web_url":"https://patchwork.libcamera.org/patch/786/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190322104350.31091-4-kieran.bingham@ideasonboard.com>","date":"2019-03-22T10:43:49","name":"[libcamera-devel,3/4] libcamera: log: Use internal basename implementation.","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"bbfdceaf3a571374481ac429e58485df73dc6e13","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/786/mbox/","series":[{"id":216,"url":"https://patchwork.libcamera.org/api/series/216/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=216","date":"2019-03-22T10:43:46","name":"Cleanup and non-GNU C library support","version":1,"mbox":"https://patchwork.libcamera.org/series/216/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/786/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/786/checks/","tags":{},"headers":{"Return-Path":"<kieran.bingham@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5CF6C6110A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 22 Mar 2019 11:43:59 +0100 (CET)","from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 96A2810D2;\n\tFri, 22 Mar 2019 11:43:55 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1553251435;\n\tbh=RJ99mCOaa6LBykVeCADsMPf0dkS0adtrYvIBNu4z06o=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=gnAk8sWeRj96L4RJXBOYNCOJaTb/ZIeWIjft7jvv5JZrDHLs+mWTBuU1GAIBj8Phb\n\t7nQv1SVyjPtpJbkIB7hy1iHa8zk0sDuJ97YYLiM9QEBHfY1eU2B0ely6kCDv6DY549\n\twQpdb1c8siKmIpWx/ZGWBfoOk+bnrU2TZ8gKOJGs=","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","To":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","Date":"Fri, 22 Mar 2019 10:43:49 +0000","Message-Id":"<20190322104350.31091-4-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.19.1","In-Reply-To":"<20190322104350.31091-1-kieran.bingham@ideasonboard.com>","References":"<20190322104350.31091-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 3/4] libcamera: log: Use internal basename\n\timplementation.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 22 Mar 2019 10:43:59 -0000"},"content":"Differing implementations of basename() exist, some of which may modify\nthe content of the string passed as an argument.\n\nThe implementation of basename() is trivial, thus to support different\ntoolchains, provide our own version which accepts and returns a const\nchar*.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/log.cpp | 6 ++++++\n 1 file changed, 6 insertions(+)","diff":"diff --git a/src/libcamera/log.cpp b/src/libcamera/log.cpp\nindex 26ebf410a7a9..7d930cd6b99e 100644\n--- a/src/libcamera/log.cpp\n+++ b/src/libcamera/log.cpp\n@@ -358,6 +358,12 @@ static const char *log_severity_name(LogSeverity severity)\n \t\treturn \"UNKWN\";\n }\n \n+static const char *basename(const char *path)\n+{\n+\tconst char *base = strrchr(path, '/');\n+\treturn base ? ++base : path;\n+}\n+\n /**\n  * \\class LogMessage\n  * \\brief Internal log message representation.\n","prefixes":["libcamera-devel","3/4"]}