[{"id":1099,"web_url":"https://patchwork.libcamera.org/comment/1099/","msgid":"<20190322225928.GC4572@pendragon.ideasonboard.com>","date":"2019-03-22T22:59:28","subject":"Re: [libcamera-devel] [PATCH 1/4] meson: Re-order the optional\n\tcomponents","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Fri, Mar 22, 2019 at 10:43:47AM +0000, Kieran Bingham wrote:\n> Re-order the optional components to make them alphabetical, and fix up\n> the indentation to use two spaces as required by meson. A comment is\n> added to highlight that these optional components are enabled by\n> default.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> meson.build | 11 +++++++----\n> 1 file changed, 7 insertions(+), 4 deletions(-)\n> \n> diff --git a/meson.build b/meson.build\n> index 43d4a57602bb..e001cd267c78 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -29,12 +29,15 @@ subdir('include')\n> subdir('src')\n> subdir('utils')\n> \n> -if get_option('tests')\n> -\tsubdir('test')\n> -endif\n> +# The documentation and test components are optional and can be desabled\n\ns/desabled/disabled/\n\n> +# through configuration values. They are enabled by default.\n> \n> if get_option('documentation')\n> -\tsubdir('Documentation')\n> + subdir('Documentation')\n> +endif\n> +\n> +if get_option('tests')\n> + subdir('test')\n> endif\n\nI would have not have separated the optional components, but I'll let\nyou decide.\n\nReviewed-by: Laurent Pinchart \n\n> \n> pkg_mod = import('pkgconfig')","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CD418600F9\n\tfor ;\n\tFri, 22 Mar 2019 23:59:44 +0100 (CET)","from pendragon.ideasonboard.com\n\t(p5269001-ipngn11702marunouchi.tokyo.ocn.ne.jp [114.158.195.1])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4A4F549;\n\tFri, 22 Mar 2019 23:59:38 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1553295580;\n\tbh=GdXfRwv6PzLRCUP/FFqxC+0HJB6ASq38ZPxYBnut4wo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=YLL2mf8IVVk5ldU1eqY5a5FXHZGkCm+M03LQtQAhcWBTjq1N0B8XlVqnDd1PQ8mXS\n\tSvEnTbprv/H+uT8mdqVSVkBjelUXiPeEgP927x5JC0rI0R5BY99BoDJ3mMzngqlgZU\n\tGsbSg1r3IP6rvwNfx5Cfj8pqZg/6WWfQmkStxeHs=","Date":"Sat, 23 Mar 2019 00:59:28 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Message-ID":"<20190322225928.GC4572@pendragon.ideasonboard.com>","References":"<20190322104350.31091-1-kieran.bingham@ideasonboard.com>\n\t<20190322104350.31091-2-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190322104350.31091-2-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 1/4] meson: Re-order the optional\n\tcomponents","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 22 Mar 2019 22:59:45 -0000"}},{"id":1124,"web_url":"https://patchwork.libcamera.org/comment/1124/","msgid":"","date":"2019-03-25T15:45:45","subject":"Re: [libcamera-devel] [PATCH 1/4] meson: Re-order the optional\n\tcomponents","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 22/03/2019 22:59, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Fri, Mar 22, 2019 at 10:43:47AM +0000, Kieran Bingham wrote:\n>> Re-order the optional components to make them alphabetical, and fix up\n>> the indentation to use two spaces as required by meson. A comment is\n>> added to highlight that these optional components are enabled by\n>> default.\n>>\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> meson.build | 11 +++++++----\n>> 1 file changed, 7 insertions(+), 4 deletions(-)\n>>\n>> diff --git a/meson.build b/meson.build\n>> index 43d4a57602bb..e001cd267c78 100644\n>> --- a/meson.build\n>> +++ b/meson.build\n>> @@ -29,12 +29,15 @@ subdir('include')\n>> subdir('src')\n>> subdir('utils')\n>> \n>> -if get_option('tests')\n>> -\tsubdir('test')\n>> -endif\n>> +# The documentation and test components are optional and can be desabled\n> \n> s/desabled/disabled/\n\nUgh - How did I type that...\n\n\n> \n>> +# through configuration values. They are enabled by default.\n>> \n>> if get_option('documentation')\n>> -\tsubdir('Documentation')\n>> + subdir('Documentation')\n>> +endif\n>> +\n>> +if get_option('tests')\n>> + subdir('test')\n>> endif\n> \n> I would have not have separated the optional components, but I'll let\n> you decide.\n\nThat produces either A):\n\n# The documentation and test components are optional and can be disabled\n# through configuration values. They are enabled by default.\nif get_option('documentation')\n subdir('Documentation')\nendif\nsubdir('include')\nsubdir('src')\nif get_option('tests')\n subdir('test')\nendif\nsubdir('utils')\n\n\nor B) (with a bit more spacing)\n\n# The documentation and test components are optional and can be disabled\n# through configuration values. They are enabled by default.\n\nif get_option('documentation')\n subdir('Documentation')\nendif\n\nsubdir('include')\nsubdir('src')\n\nif get_option('tests')\n subdir('test')\nendif\n\nsubdir('utils')\n\n\nBoth of which look really weird to me. If you prefer either A) or B) let\nme know and I'll update the patch for that.\n\n\n> \n> Reviewed-by: Laurent Pinchart \n> \n>> \n>> pkg_mod = import('pkgconfig')\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1664D600FD\n\tfor ;\n\tMon, 25 Mar 2019 16:45:49 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5D6A52F3;\n\tMon, 25 Mar 2019 16:45:48 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1553528748;\n\tbh=FRuE6wpmDQt/8DT7DIlQZpndp1gtEQSpVfq7Zun7dOk=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=o1O1zgUg7oaNeLLp/Mzx3M6lseD7OR43ikgxP2r13r+6cIknp8DGjPiol0jYMIbLg\n\tiAawVFsNR47N2ebT0Rx5E3vA2T6AjQtmLyDyr69MXFH9+txCJBPQLGRu5V5XIOb1EF\n\tQKtAdfD+9TF0EWXHp9WtoyLEtbDVMZDVh+NiCm+0=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ","Cc":"LibCamera Devel ","References":"<20190322104350.31091-1-kieran.bingham@ideasonboard.com>\n\t<20190322104350.31091-2-kieran.bingham@ideasonboard.com>\n\t<20190322225928.GC4572@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"","Date":"Mon, 25 Mar 2019 15:45:45 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.5.1","MIME-Version":"1.0","In-Reply-To":"<20190322225928.GC4572@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH 1/4] meson: Re-order the optional\n\tcomponents","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 25 Mar 2019 15:45:49 -0000"}}]