[{"id":102,"web_url":"https://patchwork.libcamera.org/comment/102/","msgid":"<3616253.gFc9v980aM@avalon>","date":"2018-12-28T17:03:09","subject":"Re: [libcamera-devel] [PATCH 02/12] libcamera: add dependency on\n\tlibudev","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Sunday, 23 December 2018 01:00:31 EET Niklas Söderlund wrote:\n> The device enumeration will depend on libudev, add the dependency to the\n> build system. This should be turned into a optional dependency once a\n> device enumerator not using udev is supported.\n> \n> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\nI would have squashed this with the patch that adds the code depending on \nlibudev. In either case,\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  src/libcamera/meson.build | 5 ++++-\n>  1 file changed, 4 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 46591069aa5f8beb..52b556a8ed4050cb 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -16,7 +16,10 @@ includes = [\n>      libcamera_internal_includes,\n>  ]\n> \n> +libudev = dependency('libudev')\n> +\n>  libcamera = shared_library('camera',\n>                             libcamera_sources,\n>                             install : true,\n> -                           include_directories : includes)\n> +                           include_directories : includes,\n> +                           dependencies : libudev)","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6191D60B2E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 28 Dec 2018 18:02:12 +0100 (CET)","from avalon.localnet (unknown\n\t[IPv6:2a02:2788:66a:3eb:2624:a446:f4b7:b19d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0F7FFDF;\n\tFri, 28 Dec 2018 18:02:12 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1546016532;\n\tbh=eoQUiWSq0dry+s8dCeQKcrUB7kKe8bEdt/xNhYrhBQY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=M1tD3cK1JgWEX2brYuxEHRj2wuyS/dlBniRWpGfa84E+MU5oK8+0KoxDjOYJIlvmB\n\t9v7CFGrdRMhdk1R1dk1USINiJiptElukez2a9YzTjsnf7PAlmVl/tvpe4thpJDg6ix\n\tRncBji7bEt8dCSHzbfphaWbYeUANpYF/QGVV5TNo=","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 28 Dec 2018 19:03:09 +0200","Message-ID":"<3616253.gFc9v980aM@avalon>","Organization":"Ideas on Board Oy","In-Reply-To":"<20181222230041.29999-3-niklas.soderlund@ragnatech.se>","References":"<20181222230041.29999-1-niklas.soderlund@ragnatech.se>\n\t<20181222230041.29999-3-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","Content-Type":"text/plain; charset=\"iso-8859-1\"","Subject":"Re: [libcamera-devel] [PATCH 02/12] libcamera: add dependency on\n\tlibudev","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 28 Dec 2018 17:02:12 -0000"}}]