[{"id":1093,"web_url":"https://patchwork.libcamera.org/comment/1093/","msgid":"<20190321102047.GQ4615@pendragon.ideasonboard.com>","date":"2019-03-21T10:20:47","subject":"Re: [libcamera-devel] [PATCH v4 14/31] HACK: Soraka: Limit\n\tresolution to 2560x1920","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nAs this patch will need to be merged, let's give it the right\n\"libcamera: ipu3:\" prefix.\n\nOn Wed, Mar 20, 2019 at 05:30:38PM +0100, Jacopo Mondi wrote:\n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 10 ++++++++++\n> 1 file changed, 10 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index b99aae95c6d7..ed2409907cf0 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -214,6 +214,16 @@ PipelineHandlerIPU3::streamConfiguration(Camera *camera,\n> \t\t}\n> \t}\n> \n> +\t/*\n> +\t * FIXME: Soraka: the maximum resolution reported by both sensors\n> +\t * (2592x1944 for ov5670 and 4224x3136 for ov13858) are returned as\n> +\t * default configurations but they're not correctly processed by the\n> +\t * ImgU. Resolutions up tp 2560x1920 have been validated.\n\ns/up tp/up to/\n\nWhat's happening when you try to capture in a higher resolution ?\n\n> +\t *\n> +\t * \\todo Clarify ImgU alignement requirements.\n> +\t */\n> +\tconfig->width = 2560;\n> +\tconfig->height = 1920;\n> \tconfig->pixelFormat = V4L2_PIX_FMT_NV12;\n> \tconfig->bufferCount = IPU3_BUFFER_COUNT;\n> \n> -- \n> 2.21.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 52916600F9\n\tfor ;\n\tThu, 21 Mar 2019 11:20:59 +0100 (CET)","from pendragon.ideasonboard.com (30.net042126252.t-com.ne.jp\n\t[42.126.252.30])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0936723A;\n\tThu, 21 Mar 2019 11:20:57 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1553163658;\n\tbh=PFvAOfZc2inkgkg/k059pbj9nMs5wIVankEJ5sdvzMo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=DRx4Vi1ZgdpSagznDDamL38NnTkDylr8FDv8+nFBXjEMp4M6NKTKqjufWtDWoIvy2\n\t9qUHQxz+JADj729WVP7o2kA6naw5Humcjw+oyN2TiMHF4RLUb2yYe6x9CgQBP1GAHz\n\t0CfFa8rfeXVyD+fbTPUvFxHn6eX+KREjL58QjlTg=","Date":"Thu, 21 Mar 2019 12:20:47 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190321102047.GQ4615@pendragon.ideasonboard.com>","References":"<20190320163055.22056-1-jacopo@jmondi.org>\n\t<20190320163055.22056-15-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190320163055.22056-15-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v4 14/31] HACK: Soraka: Limit\n\tresolution to 2560x1920","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 21 Mar 2019 10:20:59 -0000"}}]