[{"id":1092,"web_url":"https://patchwork.libcamera.org/comment/1092/","msgid":"<20190321101849.GP4615@pendragon.ideasonboard.com>","date":"2019-03-21T10:18:49","subject":"Re: [libcamera-devel] [PATCH v4 13/31] libcamera: ipu3: Use NV12 as\n\tdefault image format","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Wed, Mar 20, 2019 at 05:30:37PM +0100, Jacopo Mondi wrote:\n> Now that images come from the ImgU output, hardcode NV12 as default\n> output format.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 2623b2fe65f1..b99aae95c6d7 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -211,16 +211,16 @@ PipelineHandlerIPU3::streamConfiguration(Camera *camera,\n> \n> \t\t\tconfig->width = range.maxWidth;\n> \t\t\tconfig->height = range.maxHeight;\n> -\t\t\tconfig->pixelFormat = cio2Code;\n> \t\t}\n> \t}\n> \n> +\tconfig->pixelFormat = V4L2_PIX_FMT_NV12;\n> \tconfig->bufferCount = IPU3_BUFFER_COUNT;\n> \n> \tLOG(IPU3, Debug)\n> \t\t<< \"Stream format set to: \" << config->width << \"x\"\n> \t\t<< config->height << \"- 0x\" << std::hex << std::setfill('0')\n\nSpaces or no spaces around dash, please pick one. Apart from that,\n\nReviewed-by: Laurent Pinchart \n\n> -\t\t<< std::setw(4) << config->pixelFormat;\n> +\t\t<< std::setw(8) << config->pixelFormat;\n> \n> \treturn configs;\n> }","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8C1E6600F9\n\tfor ;\n\tThu, 21 Mar 2019 11:19:00 +0100 (CET)","from pendragon.ideasonboard.com (30.net042126252.t-com.ne.jp\n\t[42.126.252.30])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3D68223A;\n\tThu, 21 Mar 2019 11:18:58 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1553163540;\n\tbh=GJko1Xe5L8mR4QccgLdAH8moYTZOXw04Z0b2ShOtT7s=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vFNWJC6xnHEeFc9GsJcpuI5T8507Xjo+bWXOXujHDC9iK4tJ0eTEKyM/r9LDpw8Et\n\tUSPIKOyObrKbyzlmNlFpSfTOK2mo2Su7y2KRAHimWDSMfbQp0QouZoodB/X7iRM6O6\n\tlxd3Bj8ap1QdLvDQsBaBiGkfT3xlHlOJTGWemJVE=","Date":"Thu, 21 Mar 2019 12:18:49 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190321101849.GP4615@pendragon.ideasonboard.com>","References":"<20190320163055.22056-1-jacopo@jmondi.org>\n\t<20190320163055.22056-14-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190320163055.22056-14-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v4 13/31] libcamera: ipu3: Use NV12 as\n\tdefault image format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 21 Mar 2019 10:19:00 -0000"}}]