[{"id":1087,"web_url":"https://patchwork.libcamera.org/comment/1087/","msgid":"<20190321095811.GK4615@pendragon.ideasonboard.com>","date":"2019-03-21T09:58:11","subject":"Re: [libcamera-devel] [PATCH v4 08/31] libcamera: ipu3: Implement\n\tcamera start/stop","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Wed, Mar 20, 2019 at 05:30:32PM +0100, Jacopo Mondi wrote:\n> Start and stop video devices in the pipeline.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 54 ++++++++++++++++++++++++----\n> 1 file changed, 48 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 2975c218f6c9..994c95692dd4 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -334,12 +334,52 @@ int PipelineHandlerIPU3::freeBuffers(Camera *camera, Stream *stream)\n> int PipelineHandlerIPU3::start(Camera *camera)\n> {\n> \tIPU3CameraData *data = cameraData(camera);\n> -\tV4L2Device *cio2 = data->cio2.output;\n> \tint ret;\n> \n> -\tret = cio2->streamOn();\n> +\t/*\n> +\t * Enqueue all available buffers to the CIO2 unit to start frame\n> +\t * capture. Start ImgU video devices and queue buffers to the output\n> +\t * ones at queueRequest() time.\n\n\"Start the ImgU video devices, buffers will be queued to the ImgU output\nand viewfinder when requests will be queued.\" ?\n\nReviewed-by: Laurent Pinchart \n\n> +\t */\n> +\tfor (Buffer &buffer : data->cio2.pool.buffers()) {\n> +\t\tret = data->cio2.output->queueBuffer(&buffer);\n> +\t\tif (ret)\n> +\t\t\treturn ret;\n> +\t}\n> +\n> +\tret = data->cio2.output->streamOn();\n> \tif (ret) {\n> -\t\tLOG(IPU3, Info) << \"Failed to start camera \" << camera->name();\n> +\t\tLOG(IPU3, Error) << \"Failed to start CIO2\";\n> +\t\tstop(camera);\n> +\t\treturn ret;\n> +\t}\n> +\n> +\t/* Start the ImgU video devices. */\n> +\tret = data->imgu->output->streamOn();\n> +\tif (ret) {\n> +\t\tLOG(IPU3, Error) << \"Failed to start ImgU output\";\n> +\t\tstop(camera);\n> +\t\treturn ret;\n> +\t}\n> +\n> +\tret = data->imgu->viewfinder->streamOn();\n> +\tif (ret) {\n> +\t\tLOG(IPU3, Error) << \"Failed to start ImgU viewfinder\";\n> +\t\tstop(camera);\n> +\t\treturn ret;\n> +\t}\n> +\n> +\tret = data->imgu->stat->streamOn();\n> +\tif (ret) {\n> +\t\tLOG(IPU3, Error) << \"Failed to start ImgU stat\";\n> +\t\tstop(camera);\n> +\t\treturn ret;\n> +\t}\n> +\n> +\tret = data->imgu->input->streamOn();\n> +\tif (ret) {\n> +\t\tLOG(IPU3, Error) << \"Failed to start ImgU input\";\n> +\t\tstop(camera);\n> \t\treturn ret;\n> \t}\n> \n> @@ -349,10 +389,12 @@ int PipelineHandlerIPU3::start(Camera *camera)\n> void PipelineHandlerIPU3::stop(Camera *camera)\n> {\n> \tIPU3CameraData *data = cameraData(camera);\n> -\tV4L2Device *cio2 = data->cio2.output;\n> \n> -\tif (cio2->streamOff())\n> -\t\tLOG(IPU3, Info) << \"Failed to stop camera \" << camera->name();\n> +\tdata->cio2.output->streamOff();\n> +\tdata->imgu->output->streamOff();\n> +\tdata->imgu->viewfinder->streamOff();\n> +\tdata->imgu->stat->streamOff();\n> +\tdata->imgu->input->streamOff();\n> \n> \tPipelineHandler::stop(camera);\n> }","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7EF5F600F9\n\tfor ;\n\tThu, 21 Mar 2019 10:58:23 +0100 (CET)","from pendragon.ideasonboard.com (30.net042126252.t-com.ne.jp\n\t[42.126.252.30])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0653423A;\n\tThu, 21 Mar 2019 10:58:21 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1553162302;\n\tbh=nCC6FlVyjEEynpt9fK15oLD2TCplwbvL3t7flPTRd4E=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=gtN4qnwzV6dcczFBhz+BkTsTxUqs1FEPpd0z4KHEWCIyI808B3M52bwA092SVlyQx\n\txvPGG6SV598mVCpqOSUddejw21lhJZWt/eFBWTFumyDa+PZob7N0pvwwISj1+tW6wL\n\tYJhA2dL2t/3zZ7rAHfrtwr6mVfAEZDhGMNpIw/NQ=","Date":"Thu, 21 Mar 2019 11:58:11 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190321095811.GK4615@pendragon.ideasonboard.com>","References":"<20190320163055.22056-1-jacopo@jmondi.org>\n\t<20190320163055.22056-9-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190320163055.22056-9-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v4 08/31] libcamera: ipu3: Implement\n\tcamera start/stop","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 21 Mar 2019 09:58:23 -0000"}}]