{"id":706,"url":"https://patchwork.libcamera.org/api/patches/706/?format=json","web_url":"https://patchwork.libcamera.org/patch/706/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190306024755.28726-3-niklas.soderlund@ragnatech.se>","date":"2019-03-06T02:47:52","name":"[libcamera-devel,2/5] test: camera: Add read default format test","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"c6bc1c25417f0610302c3e38bff5a9fe69f9d859","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/706/mbox/","series":[{"id":203,"url":"https://patchwork.libcamera.org/api/series/203/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=203","date":"2019-03-06T02:47:50","name":"test: camera: Add basic tests for the camera","version":1,"mbox":"https://patchwork.libcamera.org/series/203/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/706/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/706/checks/","tags":{},"headers":{"Return-Path":"","Received":["from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 534DE611A8\n\tfor ;\n\tWed, 6 Mar 2019 03:48:20 +0100 (CET)","from bismarck.berto.se (unknown [89.233.230.99])\n\tby bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 4b7644b0-3fba-11e9-985a-005056917f90;\n\tWed, 06 Mar 2019 03:48:18 +0100 (CET)"],"X-Halon-ID":"4b7644b0-3fba-11e9-985a-005056917f90","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 6 Mar 2019 03:47:52 +0100","Message-Id":"<20190306024755.28726-3-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190306024755.28726-1-niklas.soderlund@ragnatech.se>","References":"<20190306024755.28726-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/5] test: camera: Add read default format\n\ttest","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 06 Mar 2019 02:48:20 -0000"},"content":"Add a test to verify reading the default format from a camera works.\n\nSigned-off-by: Niklas Söderlund \n---\n test/camera/camera_test.cpp | 47 ++++++++++++++++++++++\n test/camera/camera_test.h | 32 +++++++++++++++\n test/camera/format_default.cpp | 71 ++++++++++++++++++++++++++++++++++\n test/camera/meson.build | 12 ++++++\n test/meson.build | 1 +\n 5 files changed, 163 insertions(+)\n create mode 100644 test/camera/camera_test.cpp\n create mode 100644 test/camera/camera_test.h\n create mode 100644 test/camera/format_default.cpp\n create mode 100644 test/camera/meson.build","diff":"diff --git a/test/camera/camera_test.cpp b/test/camera/camera_test.cpp\nnew file mode 100644\nindex 0000000000000000..d39a0ed066665946\n--- /dev/null\n+++ b/test/camera/camera_test.cpp\n@@ -0,0 +1,47 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2019, Google Inc.\n+ *\n+ * libcamera Camera API tests\n+ */\n+\n+#include \n+\n+#include \"camera_test.h\"\n+\n+using namespace std;\n+using namespace libcamera;\n+\n+int CameraTest::init()\n+{\n+\tcm_ = CameraManager::instance();\n+\n+\tif (cm_->start()) {\n+\t\tcout << \"Failed to start camera manager\" << endl;\n+\t\treturn TestFail;\n+\t}\n+\n+\tcamera_ = cm_->get(\"VIMC Sensor B\");\n+\tif (!camera_) {\n+\t\tcout << \"Can not find VIMC camera, skip.\" << endl;\n+\t\treturn TestSkip;\n+\t}\n+\n+\t/* Sanity check that camera have streams. */\n+\tif (camera_->streams().size() == 0) {\n+\t\tcout << \"Camera have no streams, fail.\" << endl;\n+\t\treturn TestFail;\n+\t}\n+\n+\treturn TestPass;\n+}\n+\n+void CameraTest::cleanup()\n+{\n+\tif (camera_) {\n+\t\tcamera_->release();\n+\t\tcamera_.reset();\n+\t}\n+\n+\tcm_->stop();\n+};\ndiff --git a/test/camera/camera_test.h b/test/camera/camera_test.h\nnew file mode 100644\nindex 0000000000000000..4aadd027675a5dbd\n--- /dev/null\n+++ b/test/camera/camera_test.h\n@@ -0,0 +1,32 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2019, Google Inc.\n+ *\n+ * camera_test.h - libcamera camera test base class\n+ */\n+#ifndef __LIBCAMERA_CAMERA_TEST_H_\n+#define __LIBCAMERA_CAMERA_TEST_H_\n+\n+#include \n+\n+#include \"test.h\"\n+\n+using namespace libcamera;\n+\n+class CameraTest : public Test\n+{\n+public:\n+\tCameraTest()\n+\t\t: cm_(nullptr){};\n+\n+protected:\n+\tint init();\n+\tvoid cleanup();\n+\n+\tstd::shared_ptr camera_;\n+\n+private:\n+\tCameraManager *cm_;\n+};\n+\n+#endif /* __LIBCAMERA_CAMERA_TEST_H_ */\ndiff --git a/test/camera/format_default.cpp b/test/camera/format_default.cpp\nnew file mode 100644\nindex 0000000000000000..11b947f44c39b40a\n--- /dev/null\n+++ b/test/camera/format_default.cpp\n@@ -0,0 +1,71 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2019, Google Inc.\n+ *\n+ * libcamera Camera API tests\n+ */\n+\n+#include \n+\n+#include \"camera_test.h\"\n+\n+using namespace std;\n+\n+namespace {\n+\n+class FormatDefault : public CameraTest\n+{\n+protected:\n+\tint run()\n+\t{\n+\t\tstd::map conf;\n+\t\tstd::set streams = { *camera_->streams().begin() };\n+\n+\t\t/*\n+\t\t * Test that asking for default format for a valid array of\n+\t\t * streams returns formats and that the formats are somewhat\n+\t\t * sane.\n+\t\t */\n+\t\tconf = camera_->streamConfiguration(streams);\n+\t\tif (!conf.size()) {\n+\t\t\tcout << \"Default format for valid streams test failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tStreamConfiguration *sconf = &conf.begin()->second;\n+\t\tif (sconf->width == 0 || sconf->height == 0 ||\n+\t\t sconf->pixelFormat == 0 || sconf->bufferCount == 0) {\n+\t\t\tcout << \"Default format is set test failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/*\n+\t\t * Test that asking for format for an empty array of streams\n+\t\t * returns an empty list of configurations.\n+\t\t */\n+\t\tstd::set streams_empty = {};\n+\t\tconf = camera_->streamConfiguration(streams_empty);\n+\t\tif (conf.size()) {\n+\t\t\tcout << \"Default format for empty streams test failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/*\n+\t\t * Test that asking for format for an array of streams bad streams\n+\t\t * returns an empty list of configurations.\n+\t\t */\n+\t\tStream *stream_bad = *streams.end();\n+\t\tstd::set streams_bad = { stream_bad };\n+\t\tconf = camera_->streamConfiguration(streams_bad);\n+\t\tif (conf.size()) {\n+\t\t\tcout << \"Default format for bad streams test failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\treturn TestPass;\n+\t}\n+};\n+\n+} /* namespace */\n+\n+TEST_REGISTER(FormatDefault);\ndiff --git a/test/camera/meson.build b/test/camera/meson.build\nnew file mode 100644\nindex 0000000000000000..4f2ed244a9240512\n--- /dev/null\n+++ b/test/camera/meson.build\n@@ -0,0 +1,12 @@\n+# Tests are listed in order of complexity.\n+# They are not alphabetically sorted.\n+camera_tests = [\n+ [ 'format_default', 'format_default.cpp' ],\n+]\n+\n+foreach t : camera_tests\n+ exe = executable(t[0], [t[1], 'camera_test.cpp'],\n+\t\t link_with : test_libraries,\n+\t\t include_directories : test_includes_internal)\n+ test(t[0], exe, suite: 'camera', is_parallel: false)\n+endforeach\ndiff --git a/test/meson.build b/test/meson.build\nindex 5fb16fa6afb62f8d..71a96921697c0e9e 100644\n--- a/test/meson.build\n+++ b/test/meson.build\n@@ -1,5 +1,6 @@\n subdir('libtest')\n \n+subdir('camera')\n subdir('media_device')\n subdir('pipeline')\n subdir('v4l2_device')\n","prefixes":["libcamera-devel","2/5"]}