[{"id":1029,"web_url":"https://patchwork.libcamera.org/comment/1029/","msgid":"<20190310131607.GE4814@pendragon.ideasonboard.com>","date":"2019-03-10T13:16:07","subject":"Re: [libcamera-devel] [PATCH 1/5] libcamera: camera: Fix access bug\n\tin configureStreams()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Wed, Mar 06, 2019 at 03:47:51AM +0100, Niklas Söderlund wrote:\n> It is not permitted to configure streams before a camera is acquired.\n> \n> Fixes: 77100a7578d8a0cc (\"libcamera: camera: add state machine to control access from applications\")\n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/camera.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index e3144c5b4ab093b2..8ee9cc0866167ae1 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -405,7 +405,7 @@ int Camera::configureStreams(std::map &config)\n> \tif (disconnected_)\n> \t\treturn -ENODEV;\n> \n> -\tif (!stateBetween(CameraAvailable, CameraConfigured))\n> +\tif (!stateBetween(CameraAcquired, CameraConfigured))\n> \t\treturn -EACCES;\n> \n> \tif (!config.size()) {","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 08AF4600CB\n\tfor ;\n\tSun, 10 Mar 2019 14:16:14 +0100 (CET)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7C5FC57D;\n\tSun, 10 Mar 2019 14:16:13 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1552223773;\n\tbh=wdbKzOE+uK+lWGEMCv8Y4yBG4WSoFq/+tZpSrlgBaYk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=bQIjlXG0aiROw1ihD5DdQIAhODDi0teuud/2lFMpSQnJoUKZgUuCfhiijXB2e3TE6\n\tIKWvjqCiANk5bhwWIOPitg7nnZacPTxl876X1i9BLJq8q25aHGb4KB5RjDMjV48OkO\n\txIQzyo01OavX22vy6SZDqa+WRn1mttzZK8UvV2wE=","Date":"Sun, 10 Mar 2019 15:16:07 +0200","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190310131607.GE4814@pendragon.ideasonboard.com>","References":"<20190306024755.28726-1-niklas.soderlund@ragnatech.se>\n\t<20190306024755.28726-2-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190306024755.28726-2-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 1/5] libcamera: camera: Fix access bug\n\tin configureStreams()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 10 Mar 2019 13:16:14 -0000"}},{"id":1034,"web_url":"https://patchwork.libcamera.org/comment/1034/","msgid":"<20190310222842.GD5281@bigcity.dyn.berto.se>","date":"2019-03-10T22:28:43","subject":"Re: [libcamera-devel] [PATCH 1/5] libcamera: camera: Fix access bug\n\tin configureStreams()","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your feedback.\n\nOn 2019-03-10 15:16:07 +0200, Laurent Pinchart wrote:\n> Hi Niklas,\n> \n> Thank you for the patch.\n> \n> On Wed, Mar 06, 2019 at 03:47:51AM +0100, Niklas Söderlund wrote:\n> > It is not permitted to configure streams before a camera is acquired.\n> > \n> > Fixes: 77100a7578d8a0cc (\"libcamera: camera: add state machine to control access from applications\")\n> > Signed-off-by: Niklas Söderlund \n> \n> Reviewed-by: Laurent Pinchart \n\nAs this patch is a bug fix and not strictly related to the addition of \nthe camera tests the rest of this series deals with I have pushed this \nfix with your tag, thanks!\n\n> \n> > ---\n> > src/libcamera/camera.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> > index e3144c5b4ab093b2..8ee9cc0866167ae1 100644\n> > --- a/src/libcamera/camera.cpp\n> > +++ b/src/libcamera/camera.cpp\n> > @@ -405,7 +405,7 @@ int Camera::configureStreams(std::map &config)\n> > \tif (disconnected_)\n> > \t\treturn -ENODEV;\n> > \n> > -\tif (!stateBetween(CameraAvailable, CameraConfigured))\n> > +\tif (!stateBetween(CameraAcquired, CameraConfigured))\n> > \t\treturn -EACCES;\n> > \n> > \tif (!config.size()) {\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","Received":["from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6824E610B3\n\tfor ;\n\tSun, 10 Mar 2019 23:28:45 +0100 (CET)","by mail-lj1-x243.google.com with SMTP id z7so2371182lji.0\n\tfor ;\n\tSun, 10 Mar 2019 15:28:45 -0700 (PDT)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tp5sm716753ljg.44.2019.03.10.15.28.43\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tSun, 10 Mar 2019 15:28:43 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=370//5jXNWk2Qyhqpv3RtBOPRD3m6hh8OaE8gOERp6I=;\n\tb=EHNU0W0b9ihQs+0jGRX4Mj+wSxDn5BzSdfzCUdeZHSW4hJiNRJcqx0BcN23B9gqcUU\n\tvlzyhehJBJufypNqyawOzlWJQL4waUmNBo2Ku7o0e3oax55btpglPgCW6hn204DXgyHZ\n\tkPg6+Aee1UxO6tlvsSr0wrS3FA6PnfTL7vs/JZ6raVKdQf/QYG1EuWjKSZtFaxO9g+gk\n\tsqwEoS6OEgXc+L74L2MCvWSbmYr/E75kFx/XFwwxz/ZbXXeU5Juiz4jwRD6mI+9auCdx\n\tI0b4fvlnBBawX7dIS20SQLNzwoq1ou0Seq4171v83UxmMw1e7AV3PfVH3AjnkeCzTHoI\n\tAQig==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=370//5jXNWk2Qyhqpv3RtBOPRD3m6hh8OaE8gOERp6I=;\n\tb=qcLLe9HHYyWGWz+AGw8OJpxMhYqE5phyErj4AGB1fZxCcW7ZJdFeqvqsDSAVq92s+i\n\tk++eAQVypizQrXMl8MW0EjUik+aeEw0blJjMNlSCesggIBtYPcKQREg4XTx5EEktjCzq\n\tPAs3CY4DFODJ94m2CLKTs7BGYgCtwm/xnZKbEdRUjcp/g7NtQX6GApAZMHg5kuz8zs/t\n\t9hAby/Zd3uRws0bizYoV2mreaUdf9pLTkDoVBl0v73SuvvDVSXw3Wr6FxrQfVEpGZnue\n\tF66MfSd8gDfHietqGkPHm6oR/gDUI0wZUjGAJrJasrXEHRks13q+yIJF7qgG8qtZkiJp\n\t8sVg==","X-Gm-Message-State":"APjAAAUw6JsVF+BJFtIkYOesIEbs6KzIXw2RHh9zQVFVZc0yCQ6MqTsQ\n\tFCyGRL2MZzU3M7EPAQIIPyqYM++8HRo=","X-Google-Smtp-Source":"APXvYqxqa7aE5MRE46U31hF3XvEZ81pW8yjfmsUxMGQkjPBFKQjq8M9vq/vt3AQ/Epy/MXiIO99jgQ==","X-Received":"by 2002:a2e:85d2:: with SMTP id\n\th18mr12900145ljj.69.1552256924525; \n\tSun, 10 Mar 2019 15:28:44 -0700 (PDT)","Date":"Sun, 10 Mar 2019 23:28:43 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190310222842.GD5281@bigcity.dyn.berto.se>","References":"<20190306024755.28726-1-niklas.soderlund@ragnatech.se>\n\t<20190306024755.28726-2-niklas.soderlund@ragnatech.se>\n\t<20190310131607.GE4814@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190310131607.GE4814@pendragon.ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 1/5] libcamera: camera: Fix access bug\n\tin configureStreams()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 10 Mar 2019 22:28:45 -0000"}}]