{"id":705,"url":"https://patchwork.libcamera.org/api/patches/705/?format=json","web_url":"https://patchwork.libcamera.org/patch/705/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190306024755.28726-2-niklas.soderlund@ragnatech.se>","date":"2019-03-06T02:47:51","name":"[libcamera-devel,1/5] libcamera: camera: Fix access bug in configureStreams()","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"c3a3926d10064107dc31e0792992f7d2050c6eae","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/705/mbox/","series":[{"id":203,"url":"https://patchwork.libcamera.org/api/series/203/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=203","date":"2019-03-06T02:47:50","name":"test: camera: Add basic tests for the camera","version":1,"mbox":"https://patchwork.libcamera.org/series/203/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/705/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/705/checks/","tags":{},"headers":{"Return-Path":"","Received":["from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CA1A9611A8\n\tfor ;\n\tWed, 6 Mar 2019 03:48:17 +0100 (CET)","from bismarck.berto.se (unknown [89.233.230.99])\n\tby bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 4979d1b6-3fba-11e9-985a-005056917f90;\n\tWed, 06 Mar 2019 03:48:16 +0100 (CET)"],"X-Halon-ID":"4979d1b6-3fba-11e9-985a-005056917f90","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 6 Mar 2019 03:47:51 +0100","Message-Id":"<20190306024755.28726-2-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190306024755.28726-1-niklas.soderlund@ragnatech.se>","References":"<20190306024755.28726-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/5] libcamera: camera: Fix access bug in\n\tconfigureStreams()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 06 Mar 2019 02:48:18 -0000"},"content":"It is not permitted to configure streams before a camera is acquired.\n\nFixes: 77100a7578d8a0cc (\"libcamera: camera: add state machine to control access from applications\")\nSigned-off-by: Niklas Söderlund \n---\n src/libcamera/camera.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex e3144c5b4ab093b2..8ee9cc0866167ae1 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -405,7 +405,7 @@ int Camera::configureStreams(std::map &config)\n \tif (disconnected_)\n \t\treturn -ENODEV;\n \n-\tif (!stateBetween(CameraAvailable, CameraConfigured))\n+\tif (!stateBetween(CameraAcquired, CameraConfigured))\n \t\treturn -EACCES;\n \n \tif (!config.size()) {\n","prefixes":["libcamera-devel","1/5"]}