[{"id":1015,"web_url":"https://patchwork.libcamera.org/comment/1015/","msgid":"<20190305125439.GC4949@pendragon.ideasonboard.com>","date":"2019-03-05T12:54:39","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: camera: Unmap buffers\n\tbefore release","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Mon, Mar 04, 2019 at 11:25:30PM +0000, Kieran Bingham wrote:\n> Before buffers can be released back to V4L2 all mappings must be unmapped.\n\nI don't think \"released back to v4L2\" is the right terminology. Maybe\n\"Before buffers can be freed by the V4L2 device that has allocated them,\nall mappings must be destroyed\" ? Same for the comment below. Apart from\nthat,\n\nReviewed-by: Laurent Pinchart \n\n> Ensure that buffers are released correctly by destroying the buffer pool\n> contents before freeing the resources on the stream.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> src/libcamera/camera.cpp | 7 ++++++-\n> 1 file changed, 6 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index 8e17085bfb50..875e1e46c89c 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -488,8 +488,13 @@ int Camera::freeBuffers()\n> \t\tif (!stream->bufferPool().count())\n> \t\t\tcontinue;\n> \n> -\t\tpipe_->freeBuffers(this, stream);\n> +\t\t/*\n> +\t\t * Destroy Buffers will empty the pool, and unmap any existing\n> +\t\t * memory mapping. This needs to be done before releasing\n> +\t\t * buffers back to the V4L2Device through freeBuffers().\n> +\t\t */\n> \t\tstream->bufferPool().destroyBuffers();\n> +\t\tpipe_->freeBuffers(this, stream);\n> \t}\n> \n> \tstate_ = CameraConfigured;","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7E201600FC\n\tfor ;\n\tTue, 5 Mar 2019 13:54:45 +0100 (CET)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DA46724A;\n\tTue, 5 Mar 2019 13:54:44 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1551790485;\n\tbh=AWVUG9KqoEjDStgq3BSRZraojTcVl8bi4eAWVGQIwFk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=QP8F+1fEoShIeVceOw8m3vZO2ZsAdoKdKCfeEYgDw0dIsKZIJbXlhtwHqDLyYPHCl\n\tJixEg1SZZuRQWv+BR/IBSLDV5r82yNabjFve4Pg6pmj7pIpRzoWkZr2l8wqRPVuTw0\n\t+t4ecfUde6IC9xD3+8VzdW8bozYVoTQT/4oj0IZg=","Date":"Tue, 5 Mar 2019 14:54:39 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Message-ID":"<20190305125439.GC4949@pendragon.ideasonboard.com>","References":"<20190304232530.4427-1-kieran.bingham@ideasonboard.com>\n\t<20190304232530.4427-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190304232530.4427-3-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: camera: Unmap buffers\n\tbefore release","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 05 Mar 2019 12:54:45 -0000"}},{"id":1017,"web_url":"https://patchwork.libcamera.org/comment/1017/","msgid":"","date":"2019-03-05T15:05:48","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: camera: Unmap buffers\n\tbefore release","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 05/03/2019 12:54, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Mon, Mar 04, 2019 at 11:25:30PM +0000, Kieran Bingham wrote:\n>> Before buffers can be released back to V4L2 all mappings must be unmapped.\n> \n> I don't think \"released back to v4L2\" is the right terminology. Maybe\n> \"Before buffers can be freed by the V4L2 device that has allocated them,\n> all mappings must be destroyed\" ? Same for the comment below. Apart from\n> that,\n> \n> Reviewed-by: Laurent Pinchart \n\nAgreed, I'll reword as suggested and push with 1/2.\n\n--\nKieran\n\n\n> \n>> Ensure that buffers are released correctly by destroying the buffer pool\n>> contents before freeing the resources on the stream.\n>>\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> src/libcamera/camera.cpp | 7 ++++++-\n>> 1 file changed, 6 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n>> index 8e17085bfb50..875e1e46c89c 100644\n>> --- a/src/libcamera/camera.cpp\n>> +++ b/src/libcamera/camera.cpp\n>> @@ -488,8 +488,13 @@ int Camera::freeBuffers()\n>> \t\tif (!stream->bufferPool().count())\n>> \t\t\tcontinue;\n>> \n>> -\t\tpipe_->freeBuffers(this, stream);\n>> +\t\t/*\n>> +\t\t * Destroy Buffers will empty the pool, and unmap any existing\n>> +\t\t * memory mapping. This needs to be done before releasing\n>> +\t\t * buffers back to the V4L2Device through freeBuffers().\n>> +\t\t */\n>> \t\tstream->bufferPool().destroyBuffers();\n>> +\t\tpipe_->freeBuffers(this, stream);\n>> \t}\n>> \n>> \tstate_ = CameraConfigured;\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D9E85600FC\n\tfor ;\n\tTue, 5 Mar 2019 16:05:51 +0100 (CET)","from [192.168.0.21]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2D38824A;\n\tTue, 5 Mar 2019 16:05:51 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1551798351;\n\tbh=ZIv5XYxhQdoc2L+dYZbGwM47NVIkYiOqeCY/3yr1y4E=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=JEfzEJxjEhhU+a3OhaByO6xmsG2Xr43Sja0MGKSD8RBVGnAVhGOuBKVctMRPmi9QP\n\tTaV3oEznC6UBS1W1p9FdqOcRGQNIIKm/z4mxDL1Z2gO1ZyIbxP0XkDPBX0IyK+FVNH\n\txajFtLlf7ea7o3rDo5CHDdRfa7DyWVeXgHvPVVb0=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ","Cc":"LibCamera Devel ","References":"<20190304232530.4427-1-kieran.bingham@ideasonboard.com>\n\t<20190304232530.4427-3-kieran.bingham@ideasonboard.com>\n\t<20190305125439.GC4949@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"","Date":"Tue, 5 Mar 2019 15:05:48 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.4.0","MIME-Version":"1.0","In-Reply-To":"<20190305125439.GC4949@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: camera: Unmap buffers\n\tbefore release","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 05 Mar 2019 15:05:52 -0000"}}]