[{"id":67,"web_url":"https://patchwork.libcamera.org/comment/67/","msgid":"<20181221151722.GL5597@w540>","date":"2018-12-21T15:17:22","subject":"Re: [libcamera-devel] [PATCH 4/5] utils: checkstyle: add\n\tkeep-one-line-blocks","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran,\n\nOn Fri, Dec 21, 2018 at 08:13:10AM +0000, Kieran Bingham wrote:\n> Enable --keep-one-line-blocks to prevent astyle from wanting to move\n> single inlined blocks to cover 4 lines such as:\n>\n> - virtual int init() { return 0; }\n> + virtual int init()\n> + {\n> + return 0;\n> + }\n>\n\nThanks, this silences a lot of false positives for me!\n\nPlease add my tag and you can push this one in my opinion.\n\nReviewed-by: Jacopo Mondi \n> Signed-off-by: Kieran Bingham \n\nThe next thing to silence would be in my opinion, astyle trying to\noutsmart me when I force indent to open braces (or where I think is\nmore appropriate)\n\nEg:\n \tstruct media_v2_pad *pad = reinterpret_cast\n-\t\t\t\t (topology.ptr_pads);\n+\t\t\t\t\t (topology.ptr_pads);\n\nThis might be controversial though, so I would postpone this.\n\nThanks\n j\n\n> ---\n> utils/checkstyle.py | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/utils/checkstyle.py b/utils/checkstyle.py\n> index 32974815048a..a40d7dec879f 100755\n> --- a/utils/checkstyle.py\n> +++ b/utils/checkstyle.py\n> @@ -29,6 +29,7 @@ astyle_options = (\n> '--pad-oper',\n> '--align-pointer=name',\n> '--align-reference=name',\n> + '--keep-one-line-blocks',\n> '--max-code-length=120'\n> )\n>\n> --\n> 2.17.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 21CA860B23\n\tfor ;\n\tFri, 21 Dec 2018 16:17:25 +0100 (CET)","from w540 (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id E2359C0012;\n\tFri, 21 Dec 2018 15:17:23 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Fri, 21 Dec 2018 16:17:22 +0100","From":"jacopo mondi ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Message-ID":"<20181221151722.GL5597@w540>","References":"<20181221081311.3291-1-kieran.bingham@ideasonboard.com>\n\t<20181221081311.3291-5-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"tKkaNMvYmhQvRCRK\"","Content-Disposition":"inline","In-Reply-To":"<20181221081311.3291-5-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","Subject":"Re: [libcamera-devel] [PATCH 4/5] utils: checkstyle: add\n\tkeep-one-line-blocks","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 21 Dec 2018 15:17:25 -0000"}},{"id":68,"web_url":"https://patchwork.libcamera.org/comment/68/","msgid":"<3d9415ec-64d8-f3e6-d7d6-66e09667478c@ideasonboard.com>","date":"2018-12-21T15:19:53","subject":"Re: [libcamera-devel] [PATCH 4/5] utils: checkstyle: add\n\tkeep-one-line-blocks","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 21/12/2018 15:17, jacopo mondi wrote:\n> Hi Kieran,\n> \n> On Fri, Dec 21, 2018 at 08:13:10AM +0000, Kieran Bingham wrote:\n>> Enable --keep-one-line-blocks to prevent astyle from wanting to move\n>> single inlined blocks to cover 4 lines such as:\n>>\n>> - virtual int init() { return 0; }\n>> + virtual int init()\n>> + {\n>> + return 0;\n>> + }\n>>\n> \n> Thanks, this silences a lot of false positives for me!\n> \n> Please add my tag and you can push this one in my opinion.\n> \n> Reviewed-by: Jacopo Mondi \n>> Signed-off-by: Kieran Bingham \n> \n\nThanks, and done.\n\n\n> The next thing to silence would be in my opinion, astyle trying to\n> outsmart me when I force indent to open braces (or where I think is\n> more appropriate)\n> \n> Eg:\n> \tstruct media_v2_pad *pad = reinterpret_cast\n> -\t\t\t\t (topology.ptr_pads);\n> +\t\t\t\t\t (topology.ptr_pads);\n> \n> This might be controversial though, so I would postpone this.\n\nI'll leave this one to you then :)\n\nCheers\n\n\n> \n> Thanks\n> j\n> \n>> ---\n>> utils/checkstyle.py | 1 +\n>> 1 file changed, 1 insertion(+)\n>>\n>> diff --git a/utils/checkstyle.py b/utils/checkstyle.py\n>> index 32974815048a..a40d7dec879f 100755\n>> --- a/utils/checkstyle.py\n>> +++ b/utils/checkstyle.py\n>> @@ -29,6 +29,7 @@ astyle_options = (\n>> '--pad-oper',\n>> '--align-pointer=name',\n>> '--align-reference=name',\n>> + '--keep-one-line-blocks',\n>> '--max-code-length=120'\n>> )\n>>\n>> --\n>> 2.17.1\n>>\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 24F4560B0B\n\tfor ;\n\tFri, 21 Dec 2018 16:19:56 +0100 (CET)","from [192.168.0.21]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 926B2558;\n\tFri, 21 Dec 2018 16:19:55 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1545405595;\n\tbh=P/3rV1dF45DM6lOPa5uabPseXZYetdVy3vxY4D+/mts=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=olvtvUdnEBG8o7vq8uVw2Qp5MTh3MJH4rwmujV6ves0OLxUyZLiK1/0DU+NHRY0Ts\n\tWN+neofheb6pZJ+jSbcbC+SRlzg1Z/caYcW6Z4kUHQiCvs4vowe5KKJGg66bgCVNk3\n\tyg3+OM2YlZ2BTM0n8R7lAs1bsxw9GoRIOtlTXhVE=","Reply-To":"kieran.bingham@ideasonboard.com","To":"jacopo mondi ","Cc":"LibCamera Devel ","References":"<20181221081311.3291-1-kieran.bingham@ideasonboard.com>\n\t<20181221081311.3291-5-kieran.bingham@ideasonboard.com>\n\t<20181221151722.GL5597@w540>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"<3d9415ec-64d8-f3e6-d7d6-66e09667478c@ideasonboard.com>","Date":"Fri, 21 Dec 2018 15:19:53 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.2.1","MIME-Version":"1.0","In-Reply-To":"<20181221151722.GL5597@w540>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 4/5] utils: checkstyle: add\n\tkeep-one-line-blocks","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 21 Dec 2018 15:19:56 -0000"}}]