[{"id":991,"web_url":"https://patchwork.libcamera.org/comment/991/","msgid":"<20190301124547.GG26239@pendragon.ideasonboard.com>","date":"2019-03-01T12:45:47","subject":"Re: [libcamera-devel] [PATCH v6 3/5] libcamera: v4l2_subdevice:\n\tCosmetic update","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Fri, Mar 01, 2019 at 12:51:37PM +0100, Jacopo Mondi wrote:\n> Cosmetic updated of V4L2Subdevice class: re-sort methods and comments to\n> reflect the declaration order in the class definition.\n> \n> Cosmetic update, no functional changes intended.\n> \n> Signed-off-by: Jacopo Mondi \n\nAcked-by: Laurent Pinchart \n\n> ---\n> src/libcamera/v4l2_subdevice.cpp | 20 ++++++++++----------\n> 1 file changed, 10 insertions(+), 10 deletions(-)\n> \n> diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> index 07035886c766..de006b898af9 100644\n> --- a/src/libcamera/v4l2_subdevice.cpp\n> +++ b/src/libcamera/v4l2_subdevice.cpp\n> @@ -54,6 +54,11 @@ LOG_DEFINE_CATEGORY(V4L2Subdev)\n> * Section 4.15.3.1 of the above mentioned Linux kernel documentation section.\n> */\n> \n> +/**\n> + * \\var V4L2SubdeviceFormat::mbus_code\n> + * \\brief The image format bus code\n> + */\n> +\n> /**\n> * \\var V4L2SubdeviceFormat::width\n> * \\brief The image width in pixels\n> @@ -64,11 +69,6 @@ LOG_DEFINE_CATEGORY(V4L2Subdev)\n> * \\brief The image height in pixels\n> */\n> \n> -/**\n> - * \\var V4L2SubdeviceFormat::mbus_code\n> - * \\brief The image format bus code\n> - */\n> -\n> /**\n> * \\class V4L2Subdevice\n> * \\brief A V4L2 subdevice as exposed by the Linux kernel\n> @@ -154,11 +154,6 @@ void V4L2Subdevice::close()\n> * \\return The name of the media entity the subdevice is associated to\n> */\n> \n> -std::string V4L2Subdevice::logPrefix() const\n> -{\n> -\treturn \"'\" + deviceName() + \"'\";\n> -}\n> -\n> /**\n> * \\brief Set a crop rectangle on one of the V4L2 subdevice pads\n> * \\param[in] pad The 0-indexed pad number the rectangle is to be applied to\n> @@ -299,6 +294,11 @@ int V4L2Subdevice::setFormat(unsigned int pad, V4L2SubdeviceFormat *format)\n> \treturn 0;\n> }\n> \n> +std::string V4L2Subdevice::logPrefix() const\n> +{\n> +\treturn \"'\" + deviceName() + \"'\";\n> +}\n> +\n> std::vector V4L2Subdevice::enumPadSizes(unsigned int pad,\n> \t\t\t\t\t\t unsigned int code)\n> {","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 499F4610BF\n\tfor ;\n\tFri, 1 Mar 2019 13:45:53 +0100 (CET)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DADAA49;\n\tFri, 1 Mar 2019 13:45:52 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1551444353;\n\tbh=z8NDoSJEiV6ejf4s6/j058fZg59jl9eNFPtOEh+iGJg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=c6uaiHZP0QUMvvuwz/pO1jMKVyxMITHYOKo/tOUGsImvFGbuOXlPSXkd+7kGa10km\n\tyiXX7em3oPOXgkwz2WHiIaib0QHk26uYV01tajlabcdmEM61HJadbEnJRFLnoxCqwe\n\tIF02AVec/dgihG3YQ+FpGMSBSxq94M9ah0+rFlG0=","Date":"Fri, 1 Mar 2019 14:45:47 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190301124547.GG26239@pendragon.ideasonboard.com>","References":"<20190301115139.11060-1-jacopo@jmondi.org>\n\t<20190301115139.11060-4-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190301115139.11060-4-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v6 3/5] libcamera: v4l2_subdevice:\n\tCosmetic update","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 01 Mar 2019 12:45:53 -0000"}}]