[{"id":1013,"web_url":"https://patchwork.libcamera.org/comment/1013/","msgid":"<20190302230527.GQ4682@pendragon.ideasonboard.com>","date":"2019-03-02T23:05:27","subject":"Re: [libcamera-devel] [PATCH 10/10] libcamera: ipu3: Use NV12 as\n\tdefault image format","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Thu, Feb 28, 2019 at 09:04:10PM +0100, Jacopo Mondi wrote:\n> Now that images come from the ImgU output, hardcode NV12 as default\n> output format.\n\nWould it make sense to squash this with 04/12, as that's where you\npropagate formats ? It's not a big deal though, as in any case the patch\nseries breaks bisection. It would be nice not to, but that could only be\nachieved by squashing most of the patches together, which is likely not\nthe best idea.\n\n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 3138eb0bf8b6..660c00dacb2f 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -187,7 +187,7 @@ PipelineHandlerIPU3::streamConfiguration(Camera *camera,\n> \tV4L2Subdevice *sensor = data->cio2.sensor;\n> \tStreamConfiguration *config = &configs[&data->stream_];\n> \n> -\tconfig->pixelFormat = V4L2_PIX_FMT_IPU3_SGRBG10;\n> +\tconfig->pixelFormat = V4L2_PIX_FMT_NV12;\n> \tconfig->bufferCount = IPU3_BUF_NUM;\n> \n> \t/*","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B9A2610BF\n\tfor ;\n\tSun, 3 Mar 2019 00:05:34 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A534954E;\n\tSun, 3 Mar 2019 00:05:33 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1551567933;\n\tbh=UQUDAhZyW+W6wy7z46CUg+07XUWQrctV7QZSeg5yifY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=DFkT4pinQiR7xZdFuSqcvp9CgnXU+i5MwElhTSRaK2aU5LFh1BK93pMK0tDseAQp2\n\tMVMR3f+wk5/99Z4dzaTR6VvZMNX9dJI5OkOgJFKqN8vXm2/daZASNKL7KPiqr1WCVs\n\trMzLyr6LGhYC6We+20Snjb5nvKauA6rOo+sq+4D8=","Date":"Sun, 3 Mar 2019 01:05:27 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190302230527.GQ4682@pendragon.ideasonboard.com>","References":"<20190228200410.3022-1-jacopo@jmondi.org>\n\t<20190228200410.3022-11-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190228200410.3022-11-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 10/10] libcamera: ipu3: Use NV12 as\n\tdefault image format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 02 Mar 2019 23:05:34 -0000"}}]