[{"id":1005,"web_url":"https://patchwork.libcamera.org/comment/1005/","msgid":"<20190302212352.GG4682@pendragon.ideasonboard.com>","date":"2019-03-02T21:23:52","subject":"Re: [libcamera-devel] [PATCH 02/10] libcamera: ipu3: Get default\n\timage sizes from sensor","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Thu, Feb 28, 2019 at 09:04:02PM +0100, Jacopo Mondi wrote:\n> Inspect all image sizes provided by the sensor and select the\n> biggest one to be returned as default stream configuration instead of\n> returning the currently applied one.\n> \n> Hardcode the stream pixel format to the one produced by the CIO2 unit,\n> to be changed to the one provided by the ImgU.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 44 ++++++++++++++++++++--------\n> 1 file changed, 32 insertions(+), 12 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index d3f1d9a95f81..4f1ab72debf8 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -71,6 +71,8 @@ public:\n> \tbool match(DeviceEnumerator *enumerator);\n> \n> private:\n> +\tstatic constexpr unsigned int IPU3_BUF_NUM = 4;\n\nIPU3_BUF_COUNT or IPU3_BUFFER_COUNT to match the name of the bufferCount\nfield ?\n\n> +\n> \tIPU3CameraData *cameraData(const Camera *camera)\n> \t{\n> \t\treturn static_cast(\n> @@ -102,27 +104,45 @@ std::map\n> PipelineHandlerIPU3::streamConfiguration(Camera *camera,\n> \t\t\t\t\t std::vector &streams)\n> {\n> +\tstd::map> formats;\n\nHow about movinf this line down to declare and initialize the variable\nat the same time ?\n\n> \tstd::map configs;\n> \tIPU3CameraData *data = cameraData(camera);\n> \tV4L2Subdevice *sensor = data->cio2.sensor;\n> -\tV4L2SubdeviceFormat format = {};\n> +\tStreamConfiguration *config = &configs[&data->stream_];\n> +\n> +\tconfig->pixelFormat = V4L2_PIX_FMT_IPU3_SGRBG10;\n> +\tconfig->bufferCount = IPU3_BUF_NUM;\n> \n> \t/*\n> -\t * FIXME: As of now, return the image format reported by the sensor.\n> -\t * In future good defaults should be provided for each stream.\n> +\t * Use the largest image size the sensor provides or\n> +\t * use a default one.\n> \t */\n> -\tif (sensor->getFormat(0, &format)) {\n> -\t\tLOG(IPU3, Error) << \"Failed to create stream configurations\";\n> -\t\treturn configs;\n> +\tformats = sensor->formats(0);\n> +\tif (formats.empty()) {\n> +\t\tconfig->width = 1920;\n> +\t\tconfig->height = 1080;\n> +\t\tLOG(IPU3, Info)\n> +\t\t\t<< \"Use default stream sizes \" << config->width\n> +\t\t\t<< \"x\" << config->height;\n\nIt doesn't make much sense to fall back to a default value here, all\nsensor drivers must report the sizes they support. If you're worried\nthey may not, let's add a check when creating the camera and error out.\nYou could then cache the formats supported by the sensor in the\nCIO2Device structure.\n\n> \t}\n> \n> -\tStreamConfiguration config = {};\n> -\tconfig.width = format.width;\n> -\tconfig.height = format.height;\n> -\tconfig.pixelFormat = V4L2_PIX_FMT_IPU3_SGRBG10;\n> -\tconfig.bufferCount = 4;\n> +\tauto it = formats.begin();\n> +\twhile (it != formats.end()) {\n\nWhy do you dislike for loops ? :-)\n\n\tfor (auto it = formats.begin(); it != formats.end(); ++it) {\n\nAnd I'd even make it a const auto it and a const SizeRange & below as\nyou don't modify it.\n\n> +\t\tfor (SizeRange &range : it->second) {\n> +\t\t\tif (range.maxWidth <= config->width ||\n> +\t\t\t range.maxHeight <= config->height)\n> +\t\t\t\tcontinue;\n> +\n> +\t\t\tconfig->width = range.maxWidth;\n> +\t\t\tconfig->height = range.maxHeight;\n> +\t\t}\n\nWhat happens if the sensor supports two sizes with different aspect\nratios, let's say 4:3 and 16:9, where one has a smaller width by larger\nheight ? Shouldn't we compare the areas instead of the individual\ndimensions ?\n\n> +\n> +\t\t++it;\n> +\t}\n> \n> -\tconfigs[&data->stream_] = config;\n> +\tLOG(IPU3, Info) << \"Stream format set to = (\" << config->width << \"x\"\n> +\t\t\t<< config->height << \") - 0x\" << std::hex\n\nI know how much you dislike the streams API, but 0x%08x would be nice.\n\n> +\t\t\t<< config->pixelFormat;\n\nWouldn't Debug make more sense than Info here ?\n\n> \n> \treturn configs;\n> }","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A60F1610BF\n\tfor ;\n\tSat, 2 Mar 2019 22:23:59 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 018C654E;\n\tSat, 2 Mar 2019 22:23:58 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1551561839;\n\tbh=k9qqnUUshtYeL/zEeeVURV8ZKdEhYFpWO3enSmPm08M=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vAaeAnULYXZWwZxHAn49ZKTaEvmS4tiE6mWCRwBlVnp5z+FTKKm5wB6SfYtiRcNub\n\tUMAdNMiQRWxBVwceVgAB4XGi3G8+xBNT3DbfLf0THM84jKM8XYpvInXR1qgeD1uySU\n\torROSPk0Q7NGY2BmPNUUxyRmgaHDUMMc0ZHN1364=","Date":"Sat, 2 Mar 2019 23:23:52 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190302212352.GG4682@pendragon.ideasonboard.com>","References":"<20190228200410.3022-1-jacopo@jmondi.org>\n\t<20190228200410.3022-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190228200410.3022-3-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 02/10] libcamera: ipu3: Get default\n\timage sizes from sensor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 02 Mar 2019 21:23:59 -0000"}},{"id":1020,"web_url":"https://patchwork.libcamera.org/comment/1020/","msgid":"<20190309203949.lr5rrutpbznv3y2j@uno.localdomain>","date":"2019-03-09T20:39:49","subject":"Re: [libcamera-devel] [PATCH 02/10] libcamera: ipu3: Get default\n\timage sizes from sensor","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Sat, Mar 02, 2019 at 11:23:52PM +0200, Laurent Pinchart wrote:\n> Hi Jacopo,\n>\n> Thank you for the patch.\n>\n> On Thu, Feb 28, 2019 at 09:04:02PM +0100, Jacopo Mondi wrote:\n> > Inspect all image sizes provided by the sensor and select the\n> > biggest one to be returned as default stream configuration instead of\n> > returning the currently applied one.\n> >\n> > Hardcode the stream pixel format to the one produced by the CIO2 unit,\n> > to be changed to the one provided by the ImgU.\n> >\n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > src/libcamera/pipeline/ipu3/ipu3.cpp | 44 ++++++++++++++++++++--------\n> > 1 file changed, 32 insertions(+), 12 deletions(-)\n> >\n> > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > index d3f1d9a95f81..4f1ab72debf8 100644\n> > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > @@ -71,6 +71,8 @@ public:\n> > \tbool match(DeviceEnumerator *enumerator);\n> >\n> > private:\n> > +\tstatic constexpr unsigned int IPU3_BUF_NUM = 4;\n>\n> IPU3_BUF_COUNT or IPU3_BUFFER_COUNT to match the name of the bufferCount\n> field ?\n\nI'll use IPU3_BUFFER_COUNT\n>\n> > +\n> > \tIPU3CameraData *cameraData(const Camera *camera)\n> > \t{\n> > \t\treturn static_cast(\n> > @@ -102,27 +104,45 @@ std::map\n> > PipelineHandlerIPU3::streamConfiguration(Camera *camera,\n> > \t\t\t\t\t std::vector &streams)\n> > {\n> > +\tstd::map> formats;\n>\n> How about movinf this line down to declare and initialize the variable\n> at the same time ?\n>\n\nWill do.\n\n> > \tstd::map configs;\n> > \tIPU3CameraData *data = cameraData(camera);\n> > \tV4L2Subdevice *sensor = data->cio2.sensor;\n> > -\tV4L2SubdeviceFormat format = {};\n> > +\tStreamConfiguration *config = &configs[&data->stream_];\n> > +\n> > +\tconfig->pixelFormat = V4L2_PIX_FMT_IPU3_SGRBG10;\n> > +\tconfig->bufferCount = IPU3_BUF_NUM;\n> >\n> > \t/*\n> > -\t * FIXME: As of now, return the image format reported by the sensor.\n> > -\t * In future good defaults should be provided for each stream.\n> > +\t * Use the largest image size the sensor provides or\n> > +\t * use a default one.\n> > \t */\n> > -\tif (sensor->getFormat(0, &format)) {\n> > -\t\tLOG(IPU3, Error) << \"Failed to create stream configurations\";\n> > -\t\treturn configs;\n> > +\tformats = sensor->formats(0);\n> > +\tif (formats.empty()) {\n> > +\t\tconfig->width = 1920;\n> > +\t\tconfig->height = 1080;\n> > +\t\tLOG(IPU3, Info)\n> > +\t\t\t<< \"Use default stream sizes \" << config->width\n> > +\t\t\t<< \"x\" << config->height;\n>\n> It doesn't make much sense to fall back to a default value here, all\n> sensor drivers must report the sizes they support. If you're worried\n> they may not, let's add a check when creating the camera and error out.\n> You could then cache the formats supported by the sensor in the\n> CIO2Device structure.\n>\n\nYes, I agree, defaults are bad. I'll drop this part and assume the\nsensor provides a list of formats.\n\n> > \t}\n> >\n> > -\tStreamConfiguration config = {};\n> > -\tconfig.width = format.width;\n> > -\tconfig.height = format.height;\n> > -\tconfig.pixelFormat = V4L2_PIX_FMT_IPU3_SGRBG10;\n> > -\tconfig.bufferCount = 4;\n> > +\tauto it = formats.begin();\n> > +\twhile (it != formats.end()) {\n>\n> Why do you dislike for loops ? :-)\n>\n> \tfor (auto it = formats.begin(); it != formats.end(); ++it) {\n>\n> And I'd even make it a const auto it and a const SizeRange & below as\n> you don't modify it.\n\nI don't know, I always associate iterators to while loops. Bad habit,\nI'll change this.\n\n>\n> > +\t\tfor (SizeRange &range : it->second) {\n> > +\t\t\tif (range.maxWidth <= config->width ||\n> > +\t\t\t range.maxHeight <= config->height)\n> > +\t\t\t\tcontinue;\n> > +\n> > +\t\t\tconfig->width = range.maxWidth;\n> > +\t\t\tconfig->height = range.maxHeight;\n> > +\t\t}\n>\n> What happens if the sensor supports two sizes with different aspect\n> ratios, let's say 4:3 and 16:9, where one has a smaller width by larger\n> height ? Shouldn't we compare the areas instead of the individual\n> dimensions ?\n>\n\nShould I add an area comparator to Geometry maybe?\n\n> > +\n> > +\t\t++it;\n> > +\t}\n> >\n> > -\tconfigs[&data->stream_] = config;\n> > +\tLOG(IPU3, Info) << \"Stream format set to = (\" << config->width << \"x\"\n> > +\t\t\t<< config->height << \") - 0x\" << std::hex\n>\n> I know how much you dislike the streams API, but 0x%08x would be nice.\n>\n> > +\t\t\t<< config->pixelFormat;\n>\n> Wouldn't Debug make more sense than Info here ?\n\nAs we agreed offline, most of the Info printouts in this series will\nbe turned into Debug ones.\n\nThanks\n j\n\n>\n> >\n> > \treturn configs;\n> > }\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","Received":["from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AF219600F9\n\tfor ;\n\tSat, 9 Mar 2019 21:39:16 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 2505E240002;\n\tSat, 9 Mar 2019 20:39:15 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Sat, 9 Mar 2019 21:39:49 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190309203949.lr5rrutpbznv3y2j@uno.localdomain>","References":"<20190228200410.3022-1-jacopo@jmondi.org>\n\t<20190228200410.3022-3-jacopo@jmondi.org>\n\t<20190302212352.GG4682@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"ixovtg6aob2oe6yz\"","Content-Disposition":"inline","In-Reply-To":"<20190302212352.GG4682@pendragon.ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 02/10] libcamera: ipu3: Get default\n\timage sizes from sensor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 09 Mar 2019 20:39:16 -0000"}},{"id":1026,"web_url":"https://patchwork.libcamera.org/comment/1026/","msgid":"<20190310130243.GB4814@pendragon.ideasonboard.com>","date":"2019-03-10T13:02:43","subject":"Re: [libcamera-devel] [PATCH 02/10] libcamera: ipu3: Get default\n\timage sizes from sensor","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Sat, Mar 09, 2019 at 09:39:49PM +0100, Jacopo Mondi wrote:\n> On Sat, Mar 02, 2019 at 11:23:52PM +0200, Laurent Pinchart wrote:\n> > On Thu, Feb 28, 2019 at 09:04:02PM +0100, Jacopo Mondi wrote:\n> >> Inspect all image sizes provided by the sensor and select the\n> >> biggest one to be returned as default stream configuration instead of\n> >> returning the currently applied one.\n> >>\n> >> Hardcode the stream pixel format to the one produced by the CIO2 unit,\n> >> to be changed to the one provided by the ImgU.\n> >>\n> >> Signed-off-by: Jacopo Mondi \n> >> ---\n> >> src/libcamera/pipeline/ipu3/ipu3.cpp | 44 ++++++++++++++++++++--------\n> >> 1 file changed, 32 insertions(+), 12 deletions(-)\n> >>\n> >> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> >> index d3f1d9a95f81..4f1ab72debf8 100644\n> >> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> >> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> >> @@ -71,6 +71,8 @@ public:\n> >> \tbool match(DeviceEnumerator *enumerator);\n> >>\n> >> private:\n> >> +\tstatic constexpr unsigned int IPU3_BUF_NUM = 4;\n> >\n> > IPU3_BUF_COUNT or IPU3_BUFFER_COUNT to match the name of the bufferCount\n> > field ?\n> \n> I'll use IPU3_BUFFER_COUNT\n> \n> >> +\n> >> \tIPU3CameraData *cameraData(const Camera *camera)\n> >> \t{\n> >> \t\treturn static_cast(\n> >> @@ -102,27 +104,45 @@ std::map\n> >> PipelineHandlerIPU3::streamConfiguration(Camera *camera,\n> >> \t\t\t\t\t std::vector &streams)\n> >> {\n> >> +\tstd::map> formats;\n> >\n> > How about movinf this line down to declare and initialize the variable\n> > at the same time ?\n> \n> Will do.\n> \n> >> \tstd::map configs;\n> >> \tIPU3CameraData *data = cameraData(camera);\n> >> \tV4L2Subdevice *sensor = data->cio2.sensor;\n> >> -\tV4L2SubdeviceFormat format = {};\n> >> +\tStreamConfiguration *config = &configs[&data->stream_];\n> >> +\n> >> +\tconfig->pixelFormat = V4L2_PIX_FMT_IPU3_SGRBG10;\n> >> +\tconfig->bufferCount = IPU3_BUF_NUM;\n> >>\n> >> \t/*\n> >> -\t * FIXME: As of now, return the image format reported by the sensor.\n> >> -\t * In future good defaults should be provided for each stream.\n> >> +\t * Use the largest image size the sensor provides or\n> >> +\t * use a default one.\n> >> \t */\n> >> -\tif (sensor->getFormat(0, &format)) {\n> >> -\t\tLOG(IPU3, Error) << \"Failed to create stream configurations\";\n> >> -\t\treturn configs;\n> >> +\tformats = sensor->formats(0);\n> >> +\tif (formats.empty()) {\n> >> +\t\tconfig->width = 1920;\n> >> +\t\tconfig->height = 1080;\n> >> +\t\tLOG(IPU3, Info)\n> >> +\t\t\t<< \"Use default stream sizes \" << config->width\n> >> +\t\t\t<< \"x\" << config->height;\n> >\n> > It doesn't make much sense to fall back to a default value here, all\n> > sensor drivers must report the sizes they support. If you're worried\n> > they may not, let's add a check when creating the camera and error out.\n> > You could then cache the formats supported by the sensor in the\n> > CIO2Device structure.\n> \n> Yes, I agree, defaults are bad. I'll drop this part and assume the\n> sensor provides a list of formats.\n\nRetrieving the size at open() time and caching it would be a good idea I\nthink, but that can be done outside of this patch if you prefer (please\nadd a \\todo in that case).\n\n> >> \t}\n> >>\n> >> -\tStreamConfiguration config = {};\n> >> -\tconfig.width = format.width;\n> >> -\tconfig.height = format.height;\n> >> -\tconfig.pixelFormat = V4L2_PIX_FMT_IPU3_SGRBG10;\n> >> -\tconfig.bufferCount = 4;\n> >> +\tauto it = formats.begin();\n> >> +\twhile (it != formats.end()) {\n> >\n> > Why do you dislike for loops ? :-)\n> >\n> > \tfor (auto it = formats.begin(); it != formats.end(); ++it) {\n> >\n> > And I'd even make it a const auto it and a const SizeRange & below as\n> > you don't modify it.\n> \n> I don't know, I always associate iterators to while loops. Bad habit,\n> I'll change this.\n> \n> >> +\t\tfor (SizeRange &range : it->second) {\n> >> +\t\t\tif (range.maxWidth <= config->width ||\n> >> +\t\t\t range.maxHeight <= config->height)\n> >> +\t\t\t\tcontinue;\n> >> +\n> >> +\t\t\tconfig->width = range.maxWidth;\n> >> +\t\t\tconfig->height = range.maxHeight;\n> >> +\t\t}\n> >\n> > What happens if the sensor supports two sizes with different aspect\n> > ratios, let's say 4:3 and 16:9, where one has a smaller width by larger\n> > height ? Shouldn't we compare the areas instead of the individual\n> > dimensions ?\n> \n> Should I add an area comparator to Geometry maybe?\n\nI think that's a good idea, it will allow us to standardize comparisons\nin the library.\n\n> >> +\n> >> +\t\t++it;\n> >> +\t}\n> >>\n> >> -\tconfigs[&data->stream_] = config;\n> >> +\tLOG(IPU3, Info) << \"Stream format set to = (\" << config->width << \"x\"\n> >> +\t\t\t<< config->height << \") - 0x\" << std::hex\n> >\n> > I know how much you dislike the streams API, but 0x%08x would be nice.\n> >\n> >> +\t\t\t<< config->pixelFormat;\n> >\n> > Wouldn't Debug make more sense than Info here ?\n> \n> As we agreed offline, most of the Info printouts in this series will\n> be turned into Debug ones.\n> \n> >>\n> >> \treturn configs;\n> >> }\n> >","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8201C600CB\n\tfor ;\n\tSun, 10 Mar 2019 14:02:49 +0100 (CET)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D690157D;\n\tSun, 10 Mar 2019 14:02:48 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1552222969;\n\tbh=vOmizun8R4DqXMrF0zJsStq7F5R3UtC1TI3+kNBPLpo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=n4V4H8q9LUJDr1NHTv6wPwAlImGmiLZgap6x2OqzZ1KB5Dcp+xBnNY/HcX97YJGhr\n\tF73LA5i7hr0VWbBEq1UP9v4LmO9GqzMTn0iWxQHePuf3KI1GPHSsiMGCgDYlk4Izx5\n\tWcFtPM2l7zEPu1IUtcpg4/PyQ7A/B1yTyaoXKci8=","Date":"Sun, 10 Mar 2019 15:02:43 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190310130243.GB4814@pendragon.ideasonboard.com>","References":"<20190228200410.3022-1-jacopo@jmondi.org>\n\t<20190228200410.3022-3-jacopo@jmondi.org>\n\t<20190302212352.GG4682@pendragon.ideasonboard.com>\n\t<20190309203949.lr5rrutpbznv3y2j@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190309203949.lr5rrutpbznv3y2j@uno.localdomain>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 02/10] libcamera: ipu3: Get default\n\timage sizes from sensor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 10 Mar 2019 13:02:49 -0000"}}]