[{"id":157,"web_url":"https://patchwork.libcamera.org/comment/157/","msgid":"<1862656.sx7zilXRcH@avalon>","date":"2018-12-31T09:04:51","subject":"Re: [libcamera-devel] [PATCH 2/5] test: libtest: Add test return\n\tcodes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Friday, 21 December 2018 10:13:08 EET Kieran Bingham wrote:\n> The meson test infrastructure uses return codes to determine test\n> results. Define these values for use in tests.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> test/libtest/test.h | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/test/libtest/test.h b/test/libtest/test.h\n> index c85eeb5d9744..18b430f428c7 100644\n> --- a/test/libtest/test.h\n> +++ b/test/libtest/test.h\n> @@ -9,6 +9,10 @@\n> \n> #include \n> \n> +#define TEST_PASS 0\n> +#define TEST_FAIL -1\n> +#define TEST_SKIP 77\n> +\n\nLet's use an enum instead of macros. Apart from that,\n\nReviewed-by: Laurent Pinchart \n\n> class Test\n> {\n> public:","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1047760B2E\n\tfor ;\n\tMon, 31 Dec 2018 10:03:58 +0100 (CET)","from avalon.localnet (233.56-78-194.adsl-static.isp.belgacom.be\n\t[194.78.56.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8B94C50A;\n\tMon, 31 Dec 2018 10:03:53 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1546247033;\n\tbh=mLeWz1UijoK9uDRYWMraftFEyeA5dBbbHBrlJatYsk0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=gquSvexjYlcz5oG3G5mjSQ412eXZYTXwd8cAKivjMZ0dXffw5KN7XWgiDAVim9+WX\n\t1JZuZcAZEhSWlhbnatOQ0fdkJUupZnazycoy5Riux1urvFWmXNH+yiD0iBDxqfFJZm\n\tXptMoLi+ik5KiycFnPsToePl6Ih7ZOM6NTPHX/L8=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 31 Dec 2018 11:04:51 +0200","Message-ID":"<1862656.sx7zilXRcH@avalon>","Organization":"Ideas on Board Oy","In-Reply-To":"<20181221081311.3291-3-kieran.bingham@ideasonboard.com>","References":"<20181221081311.3291-1-kieran.bingham@ideasonboard.com>\n\t<20181221081311.3291-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"7Bit","Content-Type":"text/plain; charset=\"us-ascii\"","Subject":"Re: [libcamera-devel] [PATCH 2/5] test: libtest: Add test return\n\tcodes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 31 Dec 2018 09:03:58 -0000"}}]