[{"id":961,"web_url":"https://patchwork.libcamera.org/comment/961/","msgid":"<20190228173009.GJ899@bigcity.dyn.berto.se>","date":"2019-02-28T17:30:09","subject":"Re: [libcamera-devel] [PATCH 10/10] cam: Don't requeue requests\n\twhen stopping stream","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2019-02-28 18:29:13 +0200, Laurent Pinchart wrote:\n> When stopping the stream all pending requests are cancelled, resulting\n> in the request completion signal being emitted with the request status\n> set appropriately. Check the request status in the request completion\n> slot and skip requeuing the request if it has been cancelled.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/cam/main.cpp | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n> index 4c2df583fe8e..c8e673e30c0b 100644\n> --- a/src/cam/main.cpp\n> +++ b/src/cam/main.cpp\n> @@ -102,6 +102,9 @@ static void requestComplete(Request *request, const std::map\n> {\n> \tstatic uint64_t last = 0;\n> \n> +\tif (request->status() == Request::RequestCancelled)\n> +\t\treturn;\n> +\n> \tBuffer *buffer = buffers.begin()->second;\n> \n> \tdouble fps = buffer->timestamp() - last;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 60819610B6\n\tfor ;\n\tThu, 28 Feb 2019 18:30:11 +0100 (CET)","by mail-lj1-x243.google.com with SMTP id l5so17898484lje.1\n\tfor ;\n\tThu, 28 Feb 2019 09:30:11 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\ti15sm505978lfl.89.2019.02.28.09.30.10\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 28 Feb 2019 09:30:10 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=M1qqZNAlLslGQ/2YB79FxcA4/EgazpAeByKxNDyP4H0=;\n\tb=NlDROZnhUQlIl1HOMLvSCznz0TGDT597LdOIXlIOFjSGjVMWAzBDwDQt8N4BWk5uXh\n\tWrs5DaPNgPbgKRHu8jYjZo7zqU3z5qm8ST4G9GK4Siew0QkvVeoLi/dDvnUhoJZApOOM\n\tMzXyDL3p1exYdy3t77c601UZkurqDR/SUsHopMfDnu15Wq0+HMUwLXIbo5sfA82ZJlWu\n\tqjVmlX7Wplmh+GYLoQio14qIHJTh0w/3MZxcbkwyWOlBwC1Z7Wp3bbaLdBj/e/ejkNbf\n\twhihMDz4RED7VfqIvqZW6iWukwwVUXWcE/xqwEZfCoNZp8P8xIrc9FcEcxzGRu9zGGR8\n\tv5pw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=M1qqZNAlLslGQ/2YB79FxcA4/EgazpAeByKxNDyP4H0=;\n\tb=pTIWLjpx/bm0zmRVYESdc0cCUKdOYNS0WwcBC7wXcxCfu7EdLUD5aGerj78NoLqSLS\n\tsDWbgcXAh7c8pvL1w+nxJpPX/rR7/VZAUVqSI25DILNo8XoybJWDJvBOYvQ1tVTAZt57\n\tn9G2E3Nv/3LlCdEApm+5sDvOZ19mESFhYHUWpwEgD1GUdf041knkaPvXIuRR7W/ATC9c\n\t1rajZMT8GgLS3oSQHgt2NGxn1+gASXuukg45QM7Gec2E38WkgT479ZsqsUuBI3d+nRu/\n\tXals+z0oitKYMMGy+baA8Xl99Bi3VfxyoqmunO6HlN5q3/6gPF+CAUen8RrK3vkE43FT\n\twhgQ==","X-Gm-Message-State":"APjAAAW0XK+jaZZMhyoQKwhFBXOjxkWhuKmXWFnM6ZrZEshhqLbyduXI\n\tH3/oXUqOypQeEUMt/oAvvvMTjg==","X-Google-Smtp-Source":"APXvYqzjIZdSfXKqT8fjPXgCx60hoPXkSfuX9QI0nOYJdlNobJSZ8TxkmNG9eXXsSnd1eGwgxHarmQ==","X-Received":"by 2002:a2e:9c42:: with SMTP id t2mr22281ljj.149.1551375010729; \n\tThu, 28 Feb 2019 09:30:10 -0800 (PST)","Date":"Thu, 28 Feb 2019 18:30:09 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190228173009.GJ899@bigcity.dyn.berto.se>","References":"<20190228162913.6508-1-laurent.pinchart@ideasonboard.com>\n\t<20190228162913.6508-11-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190228162913.6508-11-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 10/10] cam: Don't requeue requests\n\twhen stopping stream","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 28 Feb 2019 17:30:11 -0000"}}]