[{"id":951,"web_url":"https://patchwork.libcamera.org/comment/951/","msgid":"<20190228170047.GG899@bigcity.dyn.berto.se>","date":"2019-02-28T17:00:47","subject":"Re: [libcamera-devel] [PATCH 04/10] libcamera: pipeline_handler:\n\tPass a non-const Camera to methods","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2019-02-28 18:29:07 +0200, Laurent Pinchart wrote:\n> The start(), stop() and queueRequest() methods receive a const pointer\n> to the related Camera object. The stop() request will need to modify the\n> state of the camera, in order to report completion of pending requests.\n> Un-constify the Camera pointer to that method, and update the start()\n> and queueRequest() methods similarly for coherency.\n> \n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\n> ---\n>  src/libcamera/include/pipeline_handler.h |  6 +++---\n>  src/libcamera/pipeline/ipu3/ipu3.cpp     | 12 ++++++------\n>  src/libcamera/pipeline/uvcvideo.cpp      | 12 ++++++------\n>  src/libcamera/pipeline/vimc.cpp          | 12 ++++++------\n>  4 files changed, 21 insertions(+), 21 deletions(-)\n> \n> diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h\n> index 4363dcd8ed8e..45e1f07ffca9 100644\n> --- a/src/libcamera/include/pipeline_handler.h\n> +++ b/src/libcamera/include/pipeline_handler.h\n> @@ -52,10 +52,10 @@ public:\n>  \tvirtual int allocateBuffers(Camera *camera, Stream *stream) = 0;\n>  \tvirtual int freeBuffers(Camera *camera, Stream *stream) = 0;\n>  \n> -\tvirtual int start(const Camera *camera) = 0;\n> -\tvirtual void stop(const Camera *camera) = 0;\n> +\tvirtual int start(Camera *camera) = 0;\n> +\tvirtual void stop(Camera *camera) = 0;\n>  \n> -\tvirtual int queueRequest(const Camera *camera, Request *request) = 0;\n> +\tvirtual int queueRequest(Camera *camera, Request *request) = 0;\n>  \n>  protected:\n>  \tvoid registerCamera(std::shared_ptr<Camera> camera);\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index cf5c28577393..248e921117f4 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -39,10 +39,10 @@ public:\n>  \tint allocateBuffers(Camera *camera, Stream *stream) override;\n>  \tint freeBuffers(Camera *camera, Stream *stream) override;\n>  \n> -\tint start(const Camera *camera) override;\n> -\tvoid stop(const Camera *camera) override;\n> +\tint start(Camera *camera) override;\n> +\tvoid stop(Camera *camera) override;\n>  \n> -\tint queueRequest(const Camera *camera, Request *request) override;\n> +\tint queueRequest(Camera *camera, Request *request) override;\n>  \n>  \tbool match(DeviceEnumerator *enumerator);\n>  \n> @@ -213,7 +213,7 @@ int PipelineHandlerIPU3::freeBuffers(Camera *camera, Stream *stream)\n>  \treturn 0;\n>  }\n>  \n> -int PipelineHandlerIPU3::start(const Camera *camera)\n> +int PipelineHandlerIPU3::start(Camera *camera)\n>  {\n>  \tIPU3CameraData *data = cameraData(camera);\n>  \tint ret;\n> @@ -227,7 +227,7 @@ int PipelineHandlerIPU3::start(const Camera *camera)\n>  \treturn 0;\n>  }\n>  \n> -void PipelineHandlerIPU3::stop(const Camera *camera)\n> +void PipelineHandlerIPU3::stop(Camera *camera)\n>  {\n>  \tIPU3CameraData *data = cameraData(camera);\n>  \n> @@ -235,7 +235,7 @@ void PipelineHandlerIPU3::stop(const Camera *camera)\n>  \t\tLOG(IPU3, Info) << \"Failed to stop camera \" << camera->name();\n>  }\n>  \n> -int PipelineHandlerIPU3::queueRequest(const Camera *camera, Request *request)\n> +int PipelineHandlerIPU3::queueRequest(Camera *camera, Request *request)\n>  {\n>  \tIPU3CameraData *data = cameraData(camera);\n>  \tStream *stream = &data->stream_;\n> diff --git a/src/libcamera/pipeline/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo.cpp\n> index 4ad311163a95..cc513513cb34 100644\n> --- a/src/libcamera/pipeline/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo.cpp\n> @@ -35,10 +35,10 @@ public:\n>  \tint allocateBuffers(Camera *camera, Stream *stream) override;\n>  \tint freeBuffers(Camera *camera, Stream *stream) override;\n>  \n> -\tint start(const Camera *camera) override;\n> -\tvoid stop(const Camera *camera) override;\n> +\tint start(Camera *camera) override;\n> +\tvoid stop(Camera *camera) override;\n>  \n> -\tint queueRequest(const Camera *camera, Request *request) override;\n> +\tint queueRequest(Camera *camera, Request *request) override;\n>  \n>  \tbool match(DeviceEnumerator *enumerator);\n>  \n> @@ -142,19 +142,19 @@ int PipelineHandlerUVC::freeBuffers(Camera *camera, Stream *stream)\n>  \treturn data->video_->releaseBuffers();\n>  }\n>  \n> -int PipelineHandlerUVC::start(const Camera *camera)\n> +int PipelineHandlerUVC::start(Camera *camera)\n>  {\n>  \tUVCCameraData *data = cameraData(camera);\n>  \treturn data->video_->streamOn();\n>  }\n>  \n> -void PipelineHandlerUVC::stop(const Camera *camera)\n> +void PipelineHandlerUVC::stop(Camera *camera)\n>  {\n>  \tUVCCameraData *data = cameraData(camera);\n>  \tdata->video_->streamOff();\n>  }\n>  \n> -int PipelineHandlerUVC::queueRequest(const Camera *camera, Request *request)\n> +int PipelineHandlerUVC::queueRequest(Camera *camera, Request *request)\n>  {\n>  \tUVCCameraData *data = cameraData(camera);\n>  \tBuffer *buffer = request->findBuffer(&data->stream_);\n> diff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\n> index ef47e7f96436..1d01fa80f8d5 100644\n> --- a/src/libcamera/pipeline/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc.cpp\n> @@ -35,10 +35,10 @@ public:\n>  \tint allocateBuffers(Camera *camera, Stream *stream) override;\n>  \tint freeBuffers(Camera *camera, Stream *stream) override;\n>  \n> -\tint start(const Camera *camera) override;\n> -\tvoid stop(const Camera *camera) override;\n> +\tint start(Camera *camera) override;\n> +\tvoid stop(Camera *camera) override;\n>  \n> -\tint queueRequest(const Camera *camera, Request *request) override;\n> +\tint queueRequest(Camera *camera, Request *request) override;\n>  \n>  \tbool match(DeviceEnumerator *enumerator);\n>  \n> @@ -142,19 +142,19 @@ int PipelineHandlerVimc::freeBuffers(Camera *camera, Stream *stream)\n>  \treturn data->video_->releaseBuffers();\n>  }\n>  \n> -int PipelineHandlerVimc::start(const Camera *camera)\n> +int PipelineHandlerVimc::start(Camera *camera)\n>  {\n>  \tVimcCameraData *data = cameraData(camera);\n>  \treturn data->video_->streamOn();\n>  }\n>  \n> -void PipelineHandlerVimc::stop(const Camera *camera)\n> +void PipelineHandlerVimc::stop(Camera *camera)\n>  {\n>  \tVimcCameraData *data = cameraData(camera);\n>  \tdata->video_->streamOff();\n>  }\n>  \n> -int PipelineHandlerVimc::queueRequest(const Camera *camera, Request *request)\n> +int PipelineHandlerVimc::queueRequest(Camera *camera, Request *request)\n>  {\n>  \tVimcCameraData *data = cameraData(camera);\n>  \tBuffer *buffer = request->findBuffer(&data->stream_);\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<niklas.soderlund@ragnatech.se>","Received":["from mail-lj1-x236.google.com (mail-lj1-x236.google.com\n\t[IPv6:2a00:1450:4864:20::236])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C54E5610B6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 28 Feb 2019 18:00:49 +0100 (CET)","by mail-lj1-x236.google.com with SMTP id v16so17761420ljg.13\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 28 Feb 2019 09:00:49 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tk21sm3882236lfj.66.2019.02.28.09.00.48\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 28 Feb 2019 09:00:48 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=OR/Mfi5jlhumEt35xSEs/x0sv7cf3WGO5OhcyZkT4p4=;\n\tb=FOmA6N2Y+j58Uk8PjCQ2uVZzpW8LKDEUdrATf57v8qj6KALq7XHWWbz8i7P9f9l+XV\n\tDAIfJFedFr/E+cpSwtqXMHoIcBM2tMztiQG3E0QxWkz2z7p38ewGSUGfToNveIp9hJOD\n\tVqBjMv5ji2iSDsMgsici/EFQ19eTQ2954C0/J8vjdYDvIaW1RHbiWm0tsdHIgHgoxgap\n\t949NLnRFeC+y3PXf9KJNynBXfhmQKS1Ol73w9HQvusIFUGowTD4GrdTZo2vza/Ezg97Z\n\ttGtlQS5mGTCnXkKDdVnwuSQcTpopGl5mm4NuUBvdVr5Tw5OLSOvlwVD59Yd4fStJEICA\n\tfn+g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=OR/Mfi5jlhumEt35xSEs/x0sv7cf3WGO5OhcyZkT4p4=;\n\tb=uf2bouS7KdgHjHFeXhwSRh8OcaNyqpwx2YJLmAjD1pDo8Oo/VVWRpg2/dTu5aN0kAx\n\tS+CWWQltWrn10Q3QUv0hd4Sjec/EJFo1SA8rJJb8dkudpxTZVH3VbKBC8wb/o8WxvYIA\n\tmh4rACyMqvP378x3AXArhxcCdVY+GyRbbmLKQC6D7MZPrrdxkxHNzT/iDNfbzJnEmHPM\n\tpokOrgHgUkAvH0qtz/QGt9Nn4UjOBO3GLBb6Kcjua5R3jGZeFDLJvMkDsvnZVzQ+Qh4l\n\tG7dyWFmQNkVdwgyhJdHDyc8sxV4wMRj9oUowynmu9nudicqqtkEE6JYuXBLfUT79eyvr\n\t+5DA==","X-Gm-Message-State":"APjAAAWaDzPMFUXAEY4alq3v/Z4tXi4IJQ0MsqqM3qh/BvJXrUVN2Vz3\n\t/aAmu/Wh1jwGAdX9e7BdUDdollsBwKY=","X-Google-Smtp-Source":"APXvYqxfHh6IvIyjp521xQKPrU2zne96o/QWEk4/N4Uen6GoZmvLjV2ItARI7rBNNiQWNIBCuSreWQ==","X-Received":"by 2002:a2e:20cf:: with SMTP id g76mr5325610lji.36.1551373249068;\n\tThu, 28 Feb 2019 09:00:49 -0800 (PST)","Date":"Thu, 28 Feb 2019 18:00:47 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190228170047.GG899@bigcity.dyn.berto.se>","References":"<20190228162913.6508-1-laurent.pinchart@ideasonboard.com>\n\t<20190228162913.6508-5-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190228162913.6508-5-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 04/10] libcamera: pipeline_handler:\n\tPass a non-const Camera to methods","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Thu, 28 Feb 2019 17:00:50 -0000"}},{"id":999,"web_url":"https://patchwork.libcamera.org/comment/999/","msgid":"<20190301131835.7onpx2vqiq7jwjvt@uno.localdomain>","date":"2019-03-01T13:18:35","subject":"Re: [libcamera-devel] [PATCH 04/10] libcamera: pipeline_handler:\n\tPass a non-const Camera to methods","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Thu, Feb 28, 2019 at 06:00:47PM +0100, Niklas Söderlund wrote:\n> Hi Laurent,\n>\n> Thanks for your patch.\n>\n> On 2019-02-28 18:29:07 +0200, Laurent Pinchart wrote:\n> > The start(), stop() and queueRequest() methods receive a const pointer\n> > to the related Camera object. The stop() request will need to modify the\n> > state of the camera, in order to report completion of pending requests.\n> > Un-constify the Camera pointer to that method, and update the start()\n> > and queueRequest() methods similarly for coherency.\n> >\n> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n>\n> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n\nThanks\n   j\n\n>\n> > ---\n> >  src/libcamera/include/pipeline_handler.h |  6 +++---\n> >  src/libcamera/pipeline/ipu3/ipu3.cpp     | 12 ++++++------\n> >  src/libcamera/pipeline/uvcvideo.cpp      | 12 ++++++------\n> >  src/libcamera/pipeline/vimc.cpp          | 12 ++++++------\n> >  4 files changed, 21 insertions(+), 21 deletions(-)\n> >\n> > diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h\n> > index 4363dcd8ed8e..45e1f07ffca9 100644\n> > --- a/src/libcamera/include/pipeline_handler.h\n> > +++ b/src/libcamera/include/pipeline_handler.h\n> > @@ -52,10 +52,10 @@ public:\n> >  \tvirtual int allocateBuffers(Camera *camera, Stream *stream) = 0;\n> >  \tvirtual int freeBuffers(Camera *camera, Stream *stream) = 0;\n> >\n> > -\tvirtual int start(const Camera *camera) = 0;\n> > -\tvirtual void stop(const Camera *camera) = 0;\n> > +\tvirtual int start(Camera *camera) = 0;\n> > +\tvirtual void stop(Camera *camera) = 0;\n> >\n> > -\tvirtual int queueRequest(const Camera *camera, Request *request) = 0;\n> > +\tvirtual int queueRequest(Camera *camera, Request *request) = 0;\n> >\n> >  protected:\n> >  \tvoid registerCamera(std::shared_ptr<Camera> camera);\n> > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > index cf5c28577393..248e921117f4 100644\n> > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > @@ -39,10 +39,10 @@ public:\n> >  \tint allocateBuffers(Camera *camera, Stream *stream) override;\n> >  \tint freeBuffers(Camera *camera, Stream *stream) override;\n> >\n> > -\tint start(const Camera *camera) override;\n> > -\tvoid stop(const Camera *camera) override;\n> > +\tint start(Camera *camera) override;\n> > +\tvoid stop(Camera *camera) override;\n> >\n> > -\tint queueRequest(const Camera *camera, Request *request) override;\n> > +\tint queueRequest(Camera *camera, Request *request) override;\n> >\n> >  \tbool match(DeviceEnumerator *enumerator);\n> >\n> > @@ -213,7 +213,7 @@ int PipelineHandlerIPU3::freeBuffers(Camera *camera, Stream *stream)\n> >  \treturn 0;\n> >  }\n> >\n> > -int PipelineHandlerIPU3::start(const Camera *camera)\n> > +int PipelineHandlerIPU3::start(Camera *camera)\n> >  {\n> >  \tIPU3CameraData *data = cameraData(camera);\n> >  \tint ret;\n> > @@ -227,7 +227,7 @@ int PipelineHandlerIPU3::start(const Camera *camera)\n> >  \treturn 0;\n> >  }\n> >\n> > -void PipelineHandlerIPU3::stop(const Camera *camera)\n> > +void PipelineHandlerIPU3::stop(Camera *camera)\n> >  {\n> >  \tIPU3CameraData *data = cameraData(camera);\n> >\n> > @@ -235,7 +235,7 @@ void PipelineHandlerIPU3::stop(const Camera *camera)\n> >  \t\tLOG(IPU3, Info) << \"Failed to stop camera \" << camera->name();\n> >  }\n> >\n> > -int PipelineHandlerIPU3::queueRequest(const Camera *camera, Request *request)\n> > +int PipelineHandlerIPU3::queueRequest(Camera *camera, Request *request)\n> >  {\n> >  \tIPU3CameraData *data = cameraData(camera);\n> >  \tStream *stream = &data->stream_;\n> > diff --git a/src/libcamera/pipeline/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo.cpp\n> > index 4ad311163a95..cc513513cb34 100644\n> > --- a/src/libcamera/pipeline/uvcvideo.cpp\n> > +++ b/src/libcamera/pipeline/uvcvideo.cpp\n> > @@ -35,10 +35,10 @@ public:\n> >  \tint allocateBuffers(Camera *camera, Stream *stream) override;\n> >  \tint freeBuffers(Camera *camera, Stream *stream) override;\n> >\n> > -\tint start(const Camera *camera) override;\n> > -\tvoid stop(const Camera *camera) override;\n> > +\tint start(Camera *camera) override;\n> > +\tvoid stop(Camera *camera) override;\n> >\n> > -\tint queueRequest(const Camera *camera, Request *request) override;\n> > +\tint queueRequest(Camera *camera, Request *request) override;\n> >\n> >  \tbool match(DeviceEnumerator *enumerator);\n> >\n> > @@ -142,19 +142,19 @@ int PipelineHandlerUVC::freeBuffers(Camera *camera, Stream *stream)\n> >  \treturn data->video_->releaseBuffers();\n> >  }\n> >\n> > -int PipelineHandlerUVC::start(const Camera *camera)\n> > +int PipelineHandlerUVC::start(Camera *camera)\n> >  {\n> >  \tUVCCameraData *data = cameraData(camera);\n> >  \treturn data->video_->streamOn();\n> >  }\n> >\n> > -void PipelineHandlerUVC::stop(const Camera *camera)\n> > +void PipelineHandlerUVC::stop(Camera *camera)\n> >  {\n> >  \tUVCCameraData *data = cameraData(camera);\n> >  \tdata->video_->streamOff();\n> >  }\n> >\n> > -int PipelineHandlerUVC::queueRequest(const Camera *camera, Request *request)\n> > +int PipelineHandlerUVC::queueRequest(Camera *camera, Request *request)\n> >  {\n> >  \tUVCCameraData *data = cameraData(camera);\n> >  \tBuffer *buffer = request->findBuffer(&data->stream_);\n> > diff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\n> > index ef47e7f96436..1d01fa80f8d5 100644\n> > --- a/src/libcamera/pipeline/vimc.cpp\n> > +++ b/src/libcamera/pipeline/vimc.cpp\n> > @@ -35,10 +35,10 @@ public:\n> >  \tint allocateBuffers(Camera *camera, Stream *stream) override;\n> >  \tint freeBuffers(Camera *camera, Stream *stream) override;\n> >\n> > -\tint start(const Camera *camera) override;\n> > -\tvoid stop(const Camera *camera) override;\n> > +\tint start(Camera *camera) override;\n> > +\tvoid stop(Camera *camera) override;\n> >\n> > -\tint queueRequest(const Camera *camera, Request *request) override;\n> > +\tint queueRequest(Camera *camera, Request *request) override;\n> >\n> >  \tbool match(DeviceEnumerator *enumerator);\n> >\n> > @@ -142,19 +142,19 @@ int PipelineHandlerVimc::freeBuffers(Camera *camera, Stream *stream)\n> >  \treturn data->video_->releaseBuffers();\n> >  }\n> >\n> > -int PipelineHandlerVimc::start(const Camera *camera)\n> > +int PipelineHandlerVimc::start(Camera *camera)\n> >  {\n> >  \tVimcCameraData *data = cameraData(camera);\n> >  \treturn data->video_->streamOn();\n> >  }\n> >\n> > -void PipelineHandlerVimc::stop(const Camera *camera)\n> > +void PipelineHandlerVimc::stop(Camera *camera)\n> >  {\n> >  \tVimcCameraData *data = cameraData(camera);\n> >  \tdata->video_->streamOff();\n> >  }\n> >\n> > -int PipelineHandlerVimc::queueRequest(const Camera *camera, Request *request)\n> > +int PipelineHandlerVimc::queueRequest(Camera *camera, Request *request)\n> >  {\n> >  \tVimcCameraData *data = cameraData(camera);\n> >  \tBuffer *buffer = request->findBuffer(&data->stream_);\n> > --\n> > Regards,\n> >\n> > Laurent Pinchart\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n>\n> --\n> Regards,\n> Niklas Söderlund\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<jacopo@jmondi.org>","Received":["from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 66041610BF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  1 Mar 2019 14:18:07 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id B431FC0006;\n\tFri,  1 Mar 2019 13:18:05 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Fri, 1 Mar 2019 14:18:35 +0100","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"Niklas =?utf-8?q?S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>","Cc":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Message-ID":"<20190301131835.7onpx2vqiq7jwjvt@uno.localdomain>","References":"<20190228162913.6508-1-laurent.pinchart@ideasonboard.com>\n\t<20190228162913.6508-5-laurent.pinchart@ideasonboard.com>\n\t<20190228170047.GG899@bigcity.dyn.berto.se>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"n6puczpvnc3duyrz\"","Content-Disposition":"inline","In-Reply-To":"<20190228170047.GG899@bigcity.dyn.berto.se>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 04/10] libcamera: pipeline_handler:\n\tPass a non-const Camera to methods","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 01 Mar 2019 13:18:07 -0000"}}]