[{"id":949,"web_url":"https://patchwork.libcamera.org/comment/949/","msgid":"<20190228165709.GE899@bigcity.dyn.berto.se>","date":"2019-02-28T16:57:09","subject":"Re: [libcamera-devel] [PATCH 02/10] libcamera: pipeline: uvcvideo:\n\tCreate UVCCameraData","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2019-02-28 18:29:05 +0200, Laurent Pinchart wrote:\n> Subclassing CameraData will become mandatory for pipeline handlers.\n> Create a new UVCCameraData class and instantiate it when creating\n> cameras to prepare for that change. The video_ and stream_ fields of the\n> UVC pipeline handler belong to the camera data, move them there.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/uvcvideo.cpp | 74 +++++++++++++++++++++--------\n> 1 file changed, 53 insertions(+), 21 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo.cpp\n> index dd20bb085a29..4ad311163a95 100644\n> --- a/src/libcamera/pipeline/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo.cpp\n> @@ -13,6 +13,7 @@\n> #include \"log.h\"\n> #include \"media_device.h\"\n> #include \"pipeline_handler.h\"\n> +#include \"utils.h\"\n> #include \"v4l2_device.h\"\n> \n> namespace libcamera {\n> @@ -42,21 +43,38 @@ public:\n> \tbool match(DeviceEnumerator *enumerator);\n> \n> private:\n> +\tclass UVCCameraData : public CameraData\n> +\t{\n> +\tpublic:\n> +\t\tUVCCameraData()\n> +\t\t{\n> +\t\t}\n> +\n> +\t\t~UVCCameraData()\n> +\t\t{\n> +\t\t\tdelete video_;\n> +\t\t}\n> +\n> +\t\tV4L2Device *video_;\n> +\t\tStream stream_;\n> +\t};\n> +\n> +\tUVCCameraData *cameraData(const Camera *camera)\n> +\t{\n> +\t\treturn static_cast(\n> +\t\t\tPipelineHandler::cameraData(camera));\n> +\t}\n> +\n> \tstd::shared_ptr media_;\n> -\tV4L2Device *video_;\n> -\tStream stream_;\n> };\n> \n> PipelineHandlerUVC::PipelineHandlerUVC(CameraManager *manager)\n> -\t: PipelineHandler(manager), media_(nullptr), video_(nullptr)\n> +\t: PipelineHandler(manager), media_(nullptr)\n> {\n> }\n> \n> PipelineHandlerUVC::~PipelineHandlerUVC()\n> {\n> -\tif (video_)\n> -\t\tdelete video_;\n> -\n> \tif (media_)\n> \t\tmedia_->release();\n> }\n> @@ -65,8 +83,9 @@ std::map\n> PipelineHandlerUVC::streamConfiguration(Camera *camera,\n> \t\t\t\t\tstd::vector &streams)\n> {\n> +\tUVCCameraData *data = cameraData(camera);\n> +\n> \tstd::map configs;\n> -\n> \tStreamConfiguration config{};\n> \n> \tLOG(UVC, Debug) << \"Retrieving default format\";\n> @@ -75,7 +94,7 @@ PipelineHandlerUVC::streamConfiguration(Camera *camera,\n> \tconfig.pixelFormat = V4L2_PIX_FMT_YUYV;\n> \tconfig.bufferCount = 4;\n> \n> -\tconfigs[&stream_] = config;\n> +\tconfigs[&data->stream_] = config;\n> \n> \treturn configs;\n> }\n> @@ -83,7 +102,8 @@ PipelineHandlerUVC::streamConfiguration(Camera *camera,\n> int PipelineHandlerUVC::configureStreams(Camera *camera,\n> \t\t\t\t\t std::map &config)\n> {\n> -\tStreamConfiguration *cfg = &config[&stream_];\n> +\tUVCCameraData *data = cameraData(camera);\n> +\tStreamConfiguration *cfg = &config[&data->stream_];\n> \tint ret;\n> \n> \tLOG(UVC, Debug) << \"Configure the camera for resolution \"\n> @@ -94,7 +114,7 @@ int PipelineHandlerUVC::configureStreams(Camera *camera,\n> \tformat.height = cfg->height;\n> \tformat.fourcc = cfg->pixelFormat;\n> \n> -\tret = video_->setFormat(&format);\n> +\tret = data->video_->setFormat(&format);\n> \tif (ret)\n> \t\treturn ret;\n> \n> @@ -108,31 +128,36 @@ int PipelineHandlerUVC::configureStreams(Camera *camera,\n> \n> int PipelineHandlerUVC::allocateBuffers(Camera *camera, Stream *stream)\n> {\n> +\tUVCCameraData *data = cameraData(camera);\n> \tconst StreamConfiguration &cfg = stream->configuration();\n> \n> \tLOG(UVC, Debug) << \"Requesting \" << cfg.bufferCount << \" buffers\";\n> \n> -\treturn video_->exportBuffers(&stream->bufferPool());\n> +\treturn data->video_->exportBuffers(&stream->bufferPool());\n> }\n> \n> int PipelineHandlerUVC::freeBuffers(Camera *camera, Stream *stream)\n> {\n> -\treturn video_->releaseBuffers();\n> +\tUVCCameraData *data = cameraData(camera);\n> +\treturn data->video_->releaseBuffers();\n> }\n> \n> int PipelineHandlerUVC::start(const Camera *camera)\n> {\n> -\treturn video_->streamOn();\n> +\tUVCCameraData *data = cameraData(camera);\n> +\treturn data->video_->streamOn();\n> }\n> \n> void PipelineHandlerUVC::stop(const Camera *camera)\n> {\n> -\tvideo_->streamOff();\n> +\tUVCCameraData *data = cameraData(camera);\n> +\tdata->video_->streamOff();\n> }\n> \n> int PipelineHandlerUVC::queueRequest(const Camera *camera, Request *request)\n> {\n> -\tBuffer *buffer = request->findBuffer(&stream_);\n> +\tUVCCameraData *data = cameraData(camera);\n> +\tBuffer *buffer = request->findBuffer(&data->stream_);\n> \tif (!buffer) {\n> \t\tLOG(UVC, Error)\n> \t\t\t<< \"Attempt to queue request with invalid stream\";\n> @@ -140,7 +165,7 @@ int PipelineHandlerUVC::queueRequest(const Camera *camera, Request *request)\n> \t\treturn -ENOENT;\n> \t}\n> \n> -\tvideo_->queueBuffer(buffer);\n> +\tdata->video_->queueBuffer(buffer);\n> \n> \treturn 0;\n> }\n> @@ -150,29 +175,36 @@ bool PipelineHandlerUVC::match(DeviceEnumerator *enumerator)\n> \tDeviceMatch dm(\"uvcvideo\");\n> \n> \tmedia_ = enumerator->search(dm);\n> -\n> \tif (!media_)\n> \t\treturn false;\n> \n> \tmedia_->acquire();\n> \n> +\tstd::unique_ptr data = utils::make_unique();\n> +\n> +\t/* Locate and open the default video node. */\n> \tfor (MediaEntity *entity : media_->entities()) {\n> \t\tif (entity->flags() & MEDIA_ENT_FL_DEFAULT) {\n> -\t\t\tvideo_ = new V4L2Device(entity);\n> +\t\t\tdata->video_ = new V4L2Device(entity);\n> \t\t\tbreak;\n> \t\t}\n> \t}\n> \n> -\tif (!video_ || video_->open()) {\n> -\t\tif (!video_)\n> +\tif (!data->video_ || data->video_->open()) {\n> +\t\tif (!data->video_)\n> \t\t\tLOG(UVC, Error) << \"Could not find a default video device\";\n> \n> \t\treturn false;\n> \t}\n> \n> -\tstd::vector streams{ &stream_ };\n> +\t/* Create and register the camera. */\n> +\tstd::vector streams{ &data->stream_ };\n> \tstd::shared_ptr camera = Camera::create(this, media_->model(), streams);\n> +\n> +\tsetCameraData(camera.get(), std::move(data));\n> \tregisterCamera(std::move(camera));\n> +\n> +\t/* Enable hot-unplug notifications. */\n> \thotplugMediaDevice(media_.get());\n> \n> \treturn true;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x236.google.com (mail-lj1-x236.google.com\n\t[IPv6:2a00:1450:4864:20::236])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EF81D610B6\n\tfor ;\n\tThu, 28 Feb 2019 17:57:11 +0100 (CET)","by mail-lj1-x236.google.com with SMTP id g80so17771904ljg.6\n\tfor ;\n\tThu, 28 Feb 2019 08:57:11 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tt14sm1764775lfk.83.2019.02.28.08.57.10\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 28 Feb 2019 08:57:10 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=/lJX9bbc+d3R0MDVdOamzcPc++x26EYrUGMuYSfm7to=;\n\tb=oN0Fp1OMwooy62jGOsfdzosVneAlDWzqziLfQMgNbcLAu84Fh/F5TXZZdfHBq+37si\n\tLs938IbX41UOvPQSabSTJcOB10EuCpirSDy3WFXlppAX5+IDNBBheACQX0R+ez/uBGf8\n\tx/gkzM6nQRp5K2WrwoaYpEysxFQPGjNGNv87Z/L2nQM1yalNtiebdNBYN4Rt29Iq3cEC\n\tprvPyRtelUbzoqKdIxmYcNoVldwdYy8nb69oHVoPQih61hAre80FeQML+4aPBCs35hl3\n\tAqkIhTFM393/2SDXuMYgt+QNTR68n5izJl4rUSBdEFZw3ObhfxEClc/2fMvRuIVIX2rh\n\tb2TQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=/lJX9bbc+d3R0MDVdOamzcPc++x26EYrUGMuYSfm7to=;\n\tb=SGM0cNYvuIig0O/ptFqI7Yg15o14fCYMs4lLnkgZb/z+QioVQU12aUurJsJJWOV1yF\n\tQjvU8vct05fymAKYWYdnaBqLapRZnMy/JzfLR5dC2xlH5SS3YF7MCf+QrHINbWrfhdnV\n\tMJ800WU7Ec9en7VM8FN4BhsKWFi0wwbapOMvr9tOGYVMGn4CtdGGO1ui5jL77KV0dk3S\n\t0aLXde1R9Ltz87KAOfZ3sja6EOAMb/hY3LTG17/9Z+ivuwrYWKXxJjUfOd3moMB78/dK\n\tao8jaFDjrwTyIQ8y396ef9I0c6xXhlPWxGkhoqcn0k604XgzcUhJo6340q6t7Av90eHr\n\t8s4A==","X-Gm-Message-State":"AHQUAuZsaXUekxSG2/umnGO8Lui6viEDREyoCG6hdalm88/EoVMSiipP\n\t+LPp1Y1+NTnNrgwWfE85nzOCL0J64oA=","X-Google-Smtp-Source":"AHgI3Ible6LhsSlOZOQBUKri9uRngvW4yDOjwTBfHfIu+knnlECWqT5+nI66dc+BsnK08jZ6EyIasg==","X-Received":"by 2002:a2e:9f0b:: with SMTP id u11mr5570102ljk.64.1551373031216;\n\tThu, 28 Feb 2019 08:57:11 -0800 (PST)","Date":"Thu, 28 Feb 2019 17:57:09 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190228165709.GE899@bigcity.dyn.berto.se>","References":"<20190228162913.6508-1-laurent.pinchart@ideasonboard.com>\n\t<20190228162913.6508-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190228162913.6508-3-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 02/10] libcamera: pipeline: uvcvideo:\n\tCreate UVCCameraData","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 28 Feb 2019 16:57:12 -0000"}},{"id":997,"web_url":"https://patchwork.libcamera.org/comment/997/","msgid":"<20190301130505.kqght243ugq324c2@uno.localdomain>","date":"2019-03-01T13:05:05","subject":"Re: [libcamera-devel] [PATCH 02/10] libcamera: pipeline: uvcvideo:\n\tCreate UVCCameraData","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Thu, Feb 28, 2019 at 06:29:05PM +0200, Laurent Pinchart wrote:\n> Subclassing CameraData will become mandatory for pipeline handlers.\n> Create a new UVCCameraData class and instantiate it when creating\n> cameras to prepare for that change. The video_ and stream_ fields of the\n> UVC pipeline handler belong to the camera data, move them there.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/pipeline/uvcvideo.cpp | 74 +++++++++++++++++++++--------\n> 1 file changed, 53 insertions(+), 21 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo.cpp\n> index dd20bb085a29..4ad311163a95 100644\n> --- a/src/libcamera/pipeline/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo.cpp\n> @@ -13,6 +13,7 @@\n> #include \"log.h\"\n> #include \"media_device.h\"\n> #include \"pipeline_handler.h\"\n> +#include \"utils.h\"\n> #include \"v4l2_device.h\"\n>\n> namespace libcamera {\n> @@ -42,21 +43,38 @@ public:\n> \tbool match(DeviceEnumerator *enumerator);\n>\n> private:\n> +\tclass UVCCameraData : public CameraData\n> +\t{\n> +\tpublic:\n> +\t\tUVCCameraData()\nnit:\n : video_(nullptr)\n\n> +\t\t{\n> +\t\t}\n> +\n> +\t\t~UVCCameraData()\n> +\t\t{\n> +\t\t\tdelete video_;\n> +\t\t}\n> +\n> +\t\tV4L2Device *video_;\n> +\t\tStream stream_;\n> +\t};\n> +\n> +\tUVCCameraData *cameraData(const Camera *camera)\n> +\t{\n> +\t\treturn static_cast(\n> +\t\t\tPipelineHandler::cameraData(camera));\n> +\t}\n> +\n> \tstd::shared_ptr media_;\n> -\tV4L2Device *video_;\n> -\tStream stream_;\n> };\n>\n> PipelineHandlerUVC::PipelineHandlerUVC(CameraManager *manager)\n> -\t: PipelineHandler(manager), media_(nullptr), video_(nullptr)\n> +\t: PipelineHandler(manager), media_(nullptr)\n> {\n> }\n>\n> PipelineHandlerUVC::~PipelineHandlerUVC()\n> {\n> -\tif (video_)\n> -\t\tdelete video_;\n> -\n> \tif (media_)\n> \t\tmedia_->release();\n> }\n> @@ -65,8 +83,9 @@ std::map\n> PipelineHandlerUVC::streamConfiguration(Camera *camera,\n> \t\t\t\t\tstd::vector &streams)\n> {\n> +\tUVCCameraData *data = cameraData(camera);\n> +\n> \tstd::map configs;\n> -\n> \tStreamConfiguration config{};\n>\n> \tLOG(UVC, Debug) << \"Retrieving default format\";\n> @@ -75,7 +94,7 @@ PipelineHandlerUVC::streamConfiguration(Camera *camera,\n> \tconfig.pixelFormat = V4L2_PIX_FMT_YUYV;\n> \tconfig.bufferCount = 4;\n>\n> -\tconfigs[&stream_] = config;\n> +\tconfigs[&data->stream_] = config;\n>\n> \treturn configs;\n> }\n> @@ -83,7 +102,8 @@ PipelineHandlerUVC::streamConfiguration(Camera *camera,\n> int PipelineHandlerUVC::configureStreams(Camera *camera,\n> \t\t\t\t\t std::map &config)\n> {\n> -\tStreamConfiguration *cfg = &config[&stream_];\n> +\tUVCCameraData *data = cameraData(camera);\n> +\tStreamConfiguration *cfg = &config[&data->stream_];\n> \tint ret;\n>\n> \tLOG(UVC, Debug) << \"Configure the camera for resolution \"\n> @@ -94,7 +114,7 @@ int PipelineHandlerUVC::configureStreams(Camera *camera,\n> \tformat.height = cfg->height;\n> \tformat.fourcc = cfg->pixelFormat;\n>\n> -\tret = video_->setFormat(&format);\n> +\tret = data->video_->setFormat(&format);\n> \tif (ret)\n> \t\treturn ret;\n>\n> @@ -108,31 +128,36 @@ int PipelineHandlerUVC::configureStreams(Camera *camera,\n>\n> int PipelineHandlerUVC::allocateBuffers(Camera *camera, Stream *stream)\n> {\n> +\tUVCCameraData *data = cameraData(camera);\n> \tconst StreamConfiguration &cfg = stream->configuration();\n>\n> \tLOG(UVC, Debug) << \"Requesting \" << cfg.bufferCount << \" buffers\";\n>\n> -\treturn video_->exportBuffers(&stream->bufferPool());\n> +\treturn data->video_->exportBuffers(&stream->bufferPool());\n> }\n>\n> int PipelineHandlerUVC::freeBuffers(Camera *camera, Stream *stream)\n> {\n> -\treturn video_->releaseBuffers();\n> +\tUVCCameraData *data = cameraData(camera);\n> +\treturn data->video_->releaseBuffers();\n> }\n>\n> int PipelineHandlerUVC::start(const Camera *camera)\n> {\n> -\treturn video_->streamOn();\n> +\tUVCCameraData *data = cameraData(camera);\n> +\treturn data->video_->streamOn();\n> }\n>\n> void PipelineHandlerUVC::stop(const Camera *camera)\n> {\n> -\tvideo_->streamOff();\n> +\tUVCCameraData *data = cameraData(camera);\n> +\tdata->video_->streamOff();\n> }\n>\n> int PipelineHandlerUVC::queueRequest(const Camera *camera, Request *request)\n> {\n> -\tBuffer *buffer = request->findBuffer(&stream_);\n> +\tUVCCameraData *data = cameraData(camera);\n> +\tBuffer *buffer = request->findBuffer(&data->stream_);\n> \tif (!buffer) {\n> \t\tLOG(UVC, Error)\n> \t\t\t<< \"Attempt to queue request with invalid stream\";\n> @@ -140,7 +165,7 @@ int PipelineHandlerUVC::queueRequest(const Camera *camera, Request *request)\n> \t\treturn -ENOENT;\n> \t}\n>\n> -\tvideo_->queueBuffer(buffer);\n> +\tdata->video_->queueBuffer(buffer);\n>\n> \treturn 0;\n> }\n> @@ -150,29 +175,36 @@ bool PipelineHandlerUVC::match(DeviceEnumerator *enumerator)\n> \tDeviceMatch dm(\"uvcvideo\");\n>\n> \tmedia_ = enumerator->search(dm);\n> -\n> \tif (!media_)\n> \t\treturn false;\n>\n> \tmedia_->acquire();\n>\n> +\tstd::unique_ptr data = utils::make_unique();\n> +\n> +\t/* Locate and open the default video node. */\n> \tfor (MediaEntity *entity : media_->entities()) {\n> \t\tif (entity->flags() & MEDIA_ENT_FL_DEFAULT) {\n> -\t\t\tvideo_ = new V4L2Device(entity);\n> +\t\t\tdata->video_ = new V4L2Device(entity);\n> \t\t\tbreak;\n> \t\t}\n> \t}\n>\n> -\tif (!video_ || video_->open()) {\n> -\t\tif (!video_)\n> +\tif (!data->video_ || data->video_->open()) {\n> +\t\tif (!data->video_)\n\nThis double (!data->video_) check is weird.\nCould you check for !data->video_ after the for loop, and handle the\nopen() return code here?\n\nThis check would also possibly benefit from the video_(nullptr)\ninitialization in UVCCameraData constructor.\n\n> \t\t\tLOG(UVC, Error) << \"Could not find a default video device\";\n>\n> \t\treturn false;\n> \t}\n>\n> -\tstd::vector streams{ &stream_ };\n> +\t/* Create and register the camera. */\n> +\tstd::vector streams{ &data->stream_ };\n> \tstd::shared_ptr camera = Camera::create(this, media_->model(), streams);\n> +\n> +\tsetCameraData(camera.get(), std::move(data));\n> \tregisterCamera(std::move(camera));\n> +\n> +\t/* Enable hot-unplug notifications. */\n> \thotplugMediaDevice(media_.get());\n>\n> \treturn true;\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2D37E610BF\n\tfor ;\n\tFri, 1 Mar 2019 14:04:36 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id B1FE31C0008;\n\tFri, 1 Mar 2019 13:04:35 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Fri, 1 Mar 2019 14:05:05 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190301130505.kqght243ugq324c2@uno.localdomain>","References":"<20190228162913.6508-1-laurent.pinchart@ideasonboard.com>\n\t<20190228162913.6508-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"jtn6wqbvyrwnytel\"","Content-Disposition":"inline","In-Reply-To":"<20190228162913.6508-3-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 02/10] libcamera: pipeline: uvcvideo:\n\tCreate UVCCameraData","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 01 Mar 2019 13:04:36 -0000"}}]