[{"id":893,"web_url":"https://patchwork.libcamera.org/comment/893/","msgid":"<20190226172126.bfqwlcssqfdefxq6@uno.localdomain>","date":"2019-02-26T17:21:26","subject":"Re: [libcamera-devel] [PATCH 8/8] libcamera: camera: make sure\n\tcamera is configured before starting","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Tue, Feb 26, 2019 at 03:18:57AM +0100, Niklas Söderlund wrote:\n> If the camera is not configured there is little use to start it. Add a\n> check to make sure the camera is configured before it's started.\n>\n\nAs commented on the previous patch, shouldn't this (and more..)\nbe caught by the state machine?\n\nThanks\n j\n\n\n> Signed-off-by: Niklas Söderlund \n> ---\n> src/libcamera/camera.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n>\n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index ba8638009992170f..cbc34599d25e5ed5 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -423,12 +423,19 @@ int Camera::queueRequest(Request *request)\n> *\n> * \\return 0 on success or a negative error code\n> * \\retval -EACCES The camera is not in a state where it can be started.\n> + * \\retval -EINVAL The camera is not configured.\n> */\n> int Camera::start()\n> {\n> \tif (!stateIs(Acquired))\n> \t\treturn -EACCES;\n>\n> +\tif (activeStreams_.empty()) {\n> +\t\tLOG(Camera, Error)\n> +\t\t\t<< \"Can't start camera without configuration\";\n> +\t\treturn -EINVAL;\n> +\t}\n> +\n> \tLOG(Camera, Debug) << \"Starting capture\";\n>\n> \tint ret = pipe_->start(this);\n> --\n> 2.20.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9AB14610B2\n\tfor ;\n\tTue, 26 Feb 2019 18:20:57 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 3A89124000B;\n\tTue, 26 Feb 2019 17:20:57 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Tue, 26 Feb 2019 18:21:26 +0100","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190226172126.bfqwlcssqfdefxq6@uno.localdomain>","References":"<20190226021857.28255-1-niklas.soderlund@ragnatech.se>\n\t<20190226021857.28255-9-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"nkbfom63qawhcqel\"","Content-Disposition":"inline","In-Reply-To":"<20190226021857.28255-9-niklas.soderlund@ragnatech.se>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 8/8] libcamera: camera: make sure\n\tcamera is configured before starting","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 26 Feb 2019 17:20:57 -0000"}},{"id":897,"web_url":"https://patchwork.libcamera.org/comment/897/","msgid":"<20190226190854.GN899@bigcity.dyn.berto.se>","date":"2019-02-26T19:08:54","subject":"Re: [libcamera-devel] [PATCH 8/8] libcamera: camera: make sure\n\tcamera is configured before starting","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your feedback.\n\nOn 2019-02-26 18:21:26 +0100, Jacopo Mondi wrote:\n> Hi Niklas,\n> \n> On Tue, Feb 26, 2019 at 03:18:57AM +0100, Niklas Söderlund wrote:\n> > If the camera is not configured there is little use to start it. Add a\n> > check to make sure the camera is configured before it's started.\n> >\n> \n> As commented on the previous patch, shouldn't this (and more..)\n> be caught by the state machine?\n\nIf we introduce a Configured state sometime in the future this could be \nreplaced with such a check. As I replied earlier, this series aim is to \nenforce the current behavior and what have been discussed. Currently \nthere is no way for an application to un-configure a camera so adding \nsuch a state now is not possible.\n\n> \n> Thanks\n> j\n> \n> \n> > Signed-off-by: Niklas Söderlund \n> > ---\n> > src/libcamera/camera.cpp | 7 +++++++\n> > 1 file changed, 7 insertions(+)\n> >\n> > diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> > index ba8638009992170f..cbc34599d25e5ed5 100644\n> > --- a/src/libcamera/camera.cpp\n> > +++ b/src/libcamera/camera.cpp\n> > @@ -423,12 +423,19 @@ int Camera::queueRequest(Request *request)\n> > *\n> > * \\return 0 on success or a negative error code\n> > * \\retval -EACCES The camera is not in a state where it can be started.\n> > + * \\retval -EINVAL The camera is not configured.\n> > */\n> > int Camera::start()\n> > {\n> > \tif (!stateIs(Acquired))\n> > \t\treturn -EACCES;\n> >\n> > +\tif (activeStreams_.empty()) {\n> > +\t\tLOG(Camera, Error)\n> > +\t\t\t<< \"Can't start camera without configuration\";\n> > +\t\treturn -EINVAL;\n> > +\t}\n> > +\n> > \tLOG(Camera, Debug) << \"Starting capture\";\n> >\n> > \tint ret = pipe_->start(this);\n> > --\n> > 2.20.1\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 70646610B2\n\tfor ;\n\tTue, 26 Feb 2019 20:08:56 +0100 (CET)","by mail-lf1-x142.google.com with SMTP id a8so4695686lfi.7\n\tfor ;\n\tTue, 26 Feb 2019 11:08:56 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\td18sm1197548lfa.26.2019.02.26.11.08.54\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 26 Feb 2019 11:08:55 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=hzH829MnCIjeCeoiA6dNKgZLWk70Mc+keUWeSrWuFS8=;\n\tb=GPJwQBrwpOgiQf9xZyx6NQ6u53T1gkXE1FYhMey+UJ+a6szOSfR5xRkPBNKqlGaswW\n\t9ED5mOBgZfnBSU6udiX541PL0sHWtO9k8AjUGvoAx9lbfBYLvhbOnZTwGUEWcyfkctAb\n\tOvPk0h9rwc+nTnc/WCrCcXaWkJVDn6Wr0bxu3iLf3mERO9osuXFJfYwNK6BEKCwG0g0P\n\tc6S0Wb1oPWDCgQoI6rDTo1zhLN4XoCsPnbvRrd9+dNVZ1GkUD22sGf1QU0fyA4EJBZBo\n\ttxcDn+82XCwQkfR2kdzubZ0BU1rwiFP2Yc6xteOGibpUKlRUaJR7WsaOSb9vjC/+NY1m\n\ttXig==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=hzH829MnCIjeCeoiA6dNKgZLWk70Mc+keUWeSrWuFS8=;\n\tb=LoUhlc50mnXZ0Ik6BrhTQI2BAi3/W6Thh0PwTne3neu9p+dgNuBIa8qHrLQ6+lPKhz\n\t9WiQKouR4+QmODdTq3dk0kC+xJTy565wgivmbQubl8YzW7sASU1Rin6pz/b7Y5fcRnqv\n\t7gFCuT/ubEQvBksOHxuvKYLblhYKwixrguipt9gHXohTU59RFjufkFOdRel26u7U0zTj\n\tuwNFfDA1cM4ELghftOoArOl73SfmXNMSgdxHgCs+iWzus8HcVDNKqUMMmVQUuwvjuXUz\n\tQe93X94uaNaQnMoxgQTQ8wZJWxUjZgGPlhDgTWczVozPgmq3M++ijXj6Ez4iMs2Zp2kI\n\tMDGw==","X-Gm-Message-State":"AHQUAuZqF2tMC2i0XkAGSAB6xB84if1d22oSaIaCEc+rN7fjZHtVprWO\n\ts7dQ5DgizvyMkhK4BDzodoR63qx1PCE=","X-Google-Smtp-Source":"AHgI3IacuPRG2ZmZ/ce77GXlRCOaxqChO/CpNJxMbQahM5vm3fJi55YNNu/Cw+eNUhEnGVBGEp0iNA==","X-Received":"by 2002:a19:5611:: with SMTP id\n\tk17mr14051182lfb.168.1551208135716; \n\tTue, 26 Feb 2019 11:08:55 -0800 (PST)","Date":"Tue, 26 Feb 2019 20:08:54 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190226190854.GN899@bigcity.dyn.berto.se>","References":"<20190226021857.28255-1-niklas.soderlund@ragnatech.se>\n\t<20190226021857.28255-9-niklas.soderlund@ragnatech.se>\n\t<20190226172126.bfqwlcssqfdefxq6@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190226172126.bfqwlcssqfdefxq6@uno.localdomain>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 8/8] libcamera: camera: make sure\n\tcamera is configured before starting","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 26 Feb 2019 19:08:56 -0000"}},{"id":915,"web_url":"https://patchwork.libcamera.org/comment/915/","msgid":"<20190227095249.eungcqddael7ehqf@uno.localdomain>","date":"2019-02-27T09:52:49","subject":"Re: [libcamera-devel] [PATCH 8/8] libcamera: camera: make sure\n\tcamera is configured before starting","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Tue, Feb 26, 2019 at 08:08:54PM +0100, Niklas Söderlund wrote:\n> Hi Jacopo,\n>\n> Thanks for your feedback.\n>\n> On 2019-02-26 18:21:26 +0100, Jacopo Mondi wrote:\n> > Hi Niklas,\n> >\n> > On Tue, Feb 26, 2019 at 03:18:57AM +0100, Niklas Söderlund wrote:\n> > > If the camera is not configured there is little use to start it. Add a\n> > > check to make sure the camera is configured before it's started.\n> > >\n> >\n> > As commented on the previous patch, shouldn't this (and more..)\n> > be caught by the state machine?\n>\n> If we introduce a Configured state sometime in the future this could be\n> replaced with such a check. As I replied earlier, this series aim is to\n> enforce the current behavior and what have been discussed. Currently\n> there is no way for an application to un-configure a camera so adding\n> such a state now is not possible.\n>\n\nIt was my intention to start discussing if we want an explicit\n'unconfigure' step, that would make sure 'allocate' and 'free' buffers\ncould only be called on a configured Camera (and possible hide 'free'\n(and allocate?) completely from the application).\n\nIf you do consider this is not the right time to do so, please add my\n\nReviewed-by: Jacopo Mondi \n\n> >\n> > Thanks\n> > j\n> >\n> >\n> > > Signed-off-by: Niklas Söderlund \n> > > ---\n> > > src/libcamera/camera.cpp | 7 +++++++\n> > > 1 file changed, 7 insertions(+)\n> > >\n> > > diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> > > index ba8638009992170f..cbc34599d25e5ed5 100644\n> > > --- a/src/libcamera/camera.cpp\n> > > +++ b/src/libcamera/camera.cpp\n> > > @@ -423,12 +423,19 @@ int Camera::queueRequest(Request *request)\n> > > *\n> > > * \\return 0 on success or a negative error code\n> > > * \\retval -EACCES The camera is not in a state where it can be started.\n> > > + * \\retval -EINVAL The camera is not configured.\n> > > */\n> > > int Camera::start()\n> > > {\n> > > \tif (!stateIs(Acquired))\n> > > \t\treturn -EACCES;\n> > >\n> > > +\tif (activeStreams_.empty()) {\n> > > +\t\tLOG(Camera, Error)\n> > > +\t\t\t<< \"Can't start camera without configuration\";\n> > > +\t\treturn -EINVAL;\n> > > +\t}\n> > > +\n> > > \tLOG(Camera, Debug) << \"Starting capture\";\n> > >\n> > > \tint ret = pipe_->start(this);\n> > > --\n> > > 2.20.1\n> > >\n> > > _______________________________________________\n> > > libcamera-devel mailing list\n> > > libcamera-devel@lists.libcamera.org\n> > > https://lists.libcamera.org/listinfo/libcamera-devel\n>\n>\n>\n> --\n> Regards,\n> Niklas Söderlund","headers":{"Return-Path":"","Received":["from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 99E02601E2\n\tfor ;\n\tWed, 27 Feb 2019 10:52:20 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id 1FAE5200010;\n\tWed, 27 Feb 2019 09:52:19 +0000 (UTC)"],"Date":"Wed, 27 Feb 2019 10:52:49 +0100","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190227095249.eungcqddael7ehqf@uno.localdomain>","References":"<20190226021857.28255-1-niklas.soderlund@ragnatech.se>\n\t<20190226021857.28255-9-niklas.soderlund@ragnatech.se>\n\t<20190226172126.bfqwlcssqfdefxq6@uno.localdomain>\n\t<20190226190854.GN899@bigcity.dyn.berto.se>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"5prffxe7wvkujghf\"","Content-Disposition":"inline","In-Reply-To":"<20190226190854.GN899@bigcity.dyn.berto.se>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 8/8] libcamera: camera: make sure\n\tcamera is configured before starting","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 27 Feb 2019 09:52:20 -0000"}},{"id":926,"web_url":"https://patchwork.libcamera.org/comment/926/","msgid":"<20190227165718.GI4813@pendragon.ideasonboard.com>","date":"2019-02-27T16:57:18","subject":"Re: [libcamera-devel] [PATCH 8/8] libcamera: camera: make sure\n\tcamera is configured before starting","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Tue, Feb 26, 2019 at 03:18:57AM +0100, Niklas Söderlund wrote:\n> If the camera is not configured there is little use to start it. Add a\n> check to make sure the camera is configured before it's started.\n> \n> Signed-off-by: Niklas Söderlund \n> ---\n> src/libcamera/camera.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index ba8638009992170f..cbc34599d25e5ed5 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -423,12 +423,19 @@ int Camera::queueRequest(Request *request)\n> *\n> * \\return 0 on success or a negative error code\n> * \\retval -EACCES The camera is not in a state where it can be started.\n> + * \\retval -EINVAL The camera is not configured.\n> */\n> int Camera::start()\n> {\n> \tif (!stateIs(Acquired))\n> \t\treturn -EACCES;\n> \n> +\tif (activeStreams_.empty()) {\n> +\t\tLOG(Camera, Error)\n> +\t\t\t<< \"Can't start camera without configuration\";\n> +\t\treturn -EINVAL;\n> +\t}\n\nSo this essentially creates a Configured state, without naming it. I\nthink the implementation may be simpler if you added an explicit state,\nbut there's no urgency, as the check is in place here.\n\nI however wonder if -EINVAL is the right error code, given that you use\n-EACCESS to denote state-related errors.\n\n> +\n> \tLOG(Camera, Debug) << \"Starting capture\";\n> \n> \tint ret = pipe_->start(this);","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1059B610B3\n\tfor ;\n\tWed, 27 Feb 2019 17:57:27 +0100 (CET)","from pendragon.ideasonboard.com (unknown [83.145.195.18])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 306BE49;\n\tWed, 27 Feb 2019 17:57:25 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1551286646;\n\tbh=9gPowa5UoaUlYTn8S8X2GCKU74X5nQnanPkgjjVoJ8c=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Zld53V/bucPSvv0/SqNa2gI0MbOAcFdXFgvHhyYnzYOzlpUI7cVaTaKzADYS1RE5P\n\tVBjyRdfzuMNxSJ87JIjJFInro9Sl9T5iZEWT81gfr92nxY9LdC59SED2mwSFckqxJY\n\tNxiACghQaBR56siIVyccG46nLcDsDSg6aI1yqRTk=","Date":"Wed, 27 Feb 2019 18:57:18 +0200","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190227165718.GI4813@pendragon.ideasonboard.com>","References":"<20190226021857.28255-1-niklas.soderlund@ragnatech.se>\n\t<20190226021857.28255-9-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190226021857.28255-9-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 8/8] libcamera: camera: make sure\n\tcamera is configured before starting","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 27 Feb 2019 16:57:27 -0000"}}]