[{"id":916,"web_url":"https://patchwork.libcamera.org/comment/916/","msgid":"<20190227125236.4xaujupt4bf7jtp4@uno.localdomain>","date":"2019-02-27T12:52:36","subject":"Re: [libcamera-devel] [PATCH 1/8] libcamera: camera: fix bug in\n\terror check for streamConfiguration()","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Tue, Feb 26, 2019 at 03:18:50AM +0100, Niklas Söderlund wrote:\n> The return statement is missing altogether and an error is silently\n> ignored. Fix this and also update the empty map to use the correct type\n> for the map key.\n\nSorry, forgot to reply. Please add\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n>\n> Fixes: 65ea2422d24a3073 (\"libcamera: camera: extend camera object to support configuration of streams\")\n> Signed-off-by: Niklas Söderlund \n> ---\n> src/libcamera/camera.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index 1acb399c80a6fd3e..6409d10ff88b2189 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -213,7 +213,7 @@ std::map\n> Camera::streamConfiguration(std::vector &streams)\n> {\n> \tif (disconnected_ || !streams.size())\n> -\t\tstd::map {};\n> +\t\treturn std::map{};\n>\n> \treturn pipe_->streamConfiguration(this, streams);\n> }\n> --\n> 2.20.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CAFB5600FD\n\tfor ;\n\tWed, 27 Feb 2019 13:52:07 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 00144E0006;\n\tWed, 27 Feb 2019 12:52:06 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Wed, 27 Feb 2019 13:52:36 +0100","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190227125236.4xaujupt4bf7jtp4@uno.localdomain>","References":"<20190226021857.28255-1-niklas.soderlund@ragnatech.se>\n\t<20190226021857.28255-2-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"lcbcmy7ou3qdn6rl\"","Content-Disposition":"inline","In-Reply-To":"<20190226021857.28255-2-niklas.soderlund@ragnatech.se>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 1/8] libcamera: camera: fix bug in\n\terror check for streamConfiguration()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 27 Feb 2019 12:52:08 -0000"}},{"id":917,"web_url":"https://patchwork.libcamera.org/comment/917/","msgid":"<20190227125315.GB4813@pendragon.ideasonboard.com>","date":"2019-02-27T12:53:15","subject":"Re: [libcamera-devel] [PATCH 1/8] libcamera: camera: fix bug in\n\terror check for streamConfiguration()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Tue, Feb 26, 2019 at 03:18:50AM +0100, Niklas Söderlund wrote:\n> The return statement is missing altogether and an error is silently\n> ignored. Fix this and also update the empty map to use the correct type\n> for the map key.\n> \n> Fixes: 65ea2422d24a3073 (\"libcamera: camera: extend camera object to support configuration of streams\")\n> Signed-off-by: Niklas Söderlund \n\nOops.\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/camera.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index 1acb399c80a6fd3e..6409d10ff88b2189 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -213,7 +213,7 @@ std::map\n> Camera::streamConfiguration(std::vector &streams)\n> {\n> \tif (disconnected_ || !streams.size())\n> -\t\tstd::map {};\n> +\t\treturn std::map{};\n> \n> \treturn pipe_->streamConfiguration(this, streams);\n> }","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8095D600FD\n\tfor ;\n\tWed, 27 Feb 2019 13:53:21 +0100 (CET)","from pendragon.ideasonboard.com (unknown [185.25.200.246])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0D7C149;\n\tWed, 27 Feb 2019 13:53:20 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1551272001;\n\tbh=pN9d76IucoEeoUoMcHtSBADhpiKx5PFqaUJnaCgmBL8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=obE8ahg4E+3dnWk9xUJbCB3AaIvF9AY+0ewK9OBymFBWXkwhn9IUGhPEEFL9XFL9m\n\tRsbvVy6tOodFsXW7rKp6436+0lkJycllvg5wYMlUbv8Z2PdU0CQoMd20i3EbRZnxwV\n\toOWSybgyOwqWcdltaUtnlBSyqp0CtK7ZrCfy1sBQ=","Date":"Wed, 27 Feb 2019 14:53:15 +0200","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190227125315.GB4813@pendragon.ideasonboard.com>","References":"<20190226021857.28255-1-niklas.soderlund@ragnatech.se>\n\t<20190226021857.28255-2-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190226021857.28255-2-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 1/8] libcamera: camera: fix bug in\n\terror check for streamConfiguration()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 27 Feb 2019 12:53:21 -0000"}},{"id":921,"web_url":"https://patchwork.libcamera.org/comment/921/","msgid":"<20190227163002.GS899@bigcity.dyn.berto.se>","date":"2019-02-27T16:30:02","subject":"Re: [libcamera-devel] [PATCH 1/8] libcamera: camera: fix bug in\n\terror check for streamConfiguration()","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi,\n\nI have pushed this single patch with Jacopo's and Laurent's tags, \nthanks!\n\nOn 2019-02-26 03:18:50 +0100, Niklas Söderlund wrote:\n> The return statement is missing altogether and an error is silently\n> ignored. Fix this and also update the empty map to use the correct type\n> for the map key.\n> \n> Fixes: 65ea2422d24a3073 (\"libcamera: camera: extend camera object to support configuration of streams\")\n> Signed-off-by: Niklas Söderlund \n> ---\n> src/libcamera/camera.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index 1acb399c80a6fd3e..6409d10ff88b2189 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -213,7 +213,7 @@ std::map\n> Camera::streamConfiguration(std::vector &streams)\n> {\n> \tif (disconnected_ || !streams.size())\n> -\t\tstd::map {};\n> +\t\treturn std::map{};\n> \n> \treturn pipe_->streamConfiguration(this, streams);\n> }\n> -- \n> 2.20.1\n>","headers":{"Return-Path":"","Received":["from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 441D8610B3\n\tfor ;\n\tWed, 27 Feb 2019 17:30:05 +0100 (CET)","by mail-lj1-x243.google.com with SMTP id z25so14515317ljk.8\n\tfor ;\n\tWed, 27 Feb 2019 08:30:05 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\to7sm2292551lff.73.2019.02.27.08.30.02\n\tfor \n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 27 Feb 2019 08:30:03 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=bLjrJqupJFw+ONe5ruTbF3GwismtBaLluVi1RwsdEXg=;\n\tb=steecX0p/P8wmHtXK0xC2MzWqrEKAycE6pQ9hbq1akQzZtqeb+2wBcBdlTUCRKRCmJ\n\tz4TackcSBC7TIB+RJY6bS479khGET0yUT0topsvYEb3dToRw/ZXUcdm+RElo34Z/sxY8\n\tjiMgkqqHAkRs/Vrx9y2d/qVcIKvSJwejAoiuAidG8KKLpTKYpSRitcIFsM3dAoJl+11I\n\tNrwWvnkY4psNvKRyPU9mTHE4UlAjpZwHgEomPNKfNnGVaeGbWSjUqxkabwrukkWIUW10\n\tKM9Mlt5GgftIavLZINGqWivFbQy9VvuyhnO7+0MNNVutmkW+XcP/iRzu4u83suaCqvbX\n\tOYgw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=bLjrJqupJFw+ONe5ruTbF3GwismtBaLluVi1RwsdEXg=;\n\tb=D0cRMh9SeygiZtOU6MVYa6Hb/NPsBC1TwlJl91OQxp87F8wU4jJsICP61UOM0nkk9B\n\tYikOxyFxYSiEzitqVvv5LVyr/ppPgLwY5Sm8o0WUYwvl2HusdTRENhGZaF2TGJABQfkX\n\tCh6DlIr5jiuWK9c7mwr7BtQTTXtrg5P+iQoSqQOS8pCagMFH8TfsorBKshdL2iiVmGh3\n\tIqP6pu6JZKA0ljxtcJ9VuuID3wuebnWkoPbKbHOXZ6ErTblLCBfJN6ll+Jm/ZQQnpOjp\n\t+pmv5zIWedpKxrWzVx/BwY9cJ0IV2IcKsWA2idGsvQMY8XovYAiQFG03QOLGG+U52zYc\n\tTL2w==","X-Gm-Message-State":"APjAAAXRj/B7HHRNULYKKBi3J5PjkfKXUNM8QAia1VkExizLf7X8WjtU\n\t+QMrTTq5GHKFdYJaMEZW3Mka3DKxL2I=","X-Google-Smtp-Source":"AHgI3IbVNBU7YAv094zxHuXmEhhyw7/NsA7ajvi9Ed9jyXyjc92lF3x8GUI9VcoFKs71yMupnGjqDg==","X-Received":"by 2002:a2e:711b:: with SMTP id\n\tm27mr1958720ljc.141.1551285004096; \n\tWed, 27 Feb 2019 08:30:04 -0800 (PST)","Date":"Wed, 27 Feb 2019 17:30:02 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190227163002.GS899@bigcity.dyn.berto.se>","References":"<20190226021857.28255-1-niklas.soderlund@ragnatech.se>\n\t<20190226021857.28255-2-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190226021857.28255-2-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 1/8] libcamera: camera: fix bug in\n\terror check for streamConfiguration()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 27 Feb 2019 16:30:05 -0000"}}]