{"id":615,"url":"https://patchwork.libcamera.org/api/patches/615/?format=json","web_url":"https://patchwork.libcamera.org/patch/615/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190225121037.11415-2-jacopo@jmondi.org>","date":"2019-02-25T12:10:32","name":"[libcamera-devel,v2,1/6] libcamera: v4l2_subdevice: Store media entity","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"c2239dcbfd725aadbc3c752e3cc6e32d488c8390","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/615/mbox/","series":[{"id":191,"url":"https://patchwork.libcamera.org/api/series/191/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=191","date":"2019-02-25T12:10:31","name":"v4l2_(sub)dev: improvements and tests","version":2,"mbox":"https://patchwork.libcamera.org/series/191/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/615/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/615/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B6BEE600FB\n\tfor ;\n\tMon, 25 Feb 2019 13:10:18 +0100 (CET)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id 4C6DF100008;\n\tMon, 25 Feb 2019 12:10:18 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 25 Feb 2019 13:10:32 +0100","Message-Id":"<20190225121037.11415-2-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20190225121037.11415-1-jacopo@jmondi.org>","References":"<20190225121037.11415-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 1/6] libcamera: v4l2_subdevice: Store\n\tmedia entity","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 25 Feb 2019 12:10:18 -0000"},"content":"Store the media entity backing the V4L2Subdevice and add a deviceName()\nmethod to retrieve the human readable name of the subdevice, which is\ncreated using the name of the associated media entity.\n\nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/include/v4l2_subdevice.h | 5 ++++-\n src/libcamera/v4l2_subdevice.cpp | 9 ++++++++-\n 2 files changed, 12 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/include/v4l2_subdevice.h b/src/libcamera/include/v4l2_subdevice.h\nindex 82fa6685ab52..fcfbee5af106 100644\n--- a/src/libcamera/include/v4l2_subdevice.h\n+++ b/src/libcamera/include/v4l2_subdevice.h\n@@ -9,9 +9,10 @@\n \n #include \n \n+#include \"media_object.h\"\n+\n namespace libcamera {\n \n-class MediaEntity;\n struct Rectangle;\n \n struct V4L2SubdeviceFormat {\n@@ -32,6 +33,7 @@ public:\n \tvoid close();\n \n \tstd::string deviceNode() const { return deviceNode_; }\n+\tstd::string deviceName() const { return entity_->name(); }\n \n \tint setCrop(unsigned int pad, Rectangle *rect);\n \tint setCompose(unsigned int pad, Rectangle *rect);\n@@ -43,6 +45,7 @@ private:\n \tint setSelection(unsigned int pad, unsigned int target,\n \t\t\t Rectangle *rect);\n \n+\tconst MediaEntity *entity_;\n \tstd::string deviceNode_;\n \tint fd_;\n };\ndiff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\nindex b436f73cc75f..ebf87f0124cb 100644\n--- a/src/libcamera/v4l2_subdevice.cpp\n+++ b/src/libcamera/v4l2_subdevice.cpp\n@@ -88,7 +88,7 @@ LOG_DEFINE_CATEGORY(V4L2Subdev)\n * path\n */\n V4L2Subdevice::V4L2Subdevice(const MediaEntity *entity)\n-\t: deviceNode_(entity->deviceNode()), fd_(-1)\n+\t: entity_(entity), deviceNode_(entity->deviceNode()), fd_(-1)\n {\n }\n \n@@ -147,6 +147,13 @@ void V4L2Subdevice::close()\n * \\return The subdevice's device node system path\n */\n \n+/**\n+ * \\fn V4L2Subdevice::deviceName()\n+ * \\brief Retrieve the name of the media entity associated with the subdevice\n+ *\n+ * \\return The name of the media entity the subdevice is associated to\n+ */\n+\n /**\n * \\brief Set a crop rectangle on one of the V4L2 subdevice pads\n * \\param[in] pad The 0-indexed pad number the rectangle is to be applied to\n","prefixes":["libcamera-devel","v2","1/6"]}