[{"id":876,"web_url":"https://patchwork.libcamera.org/comment/876/","msgid":"<20190225194324.GC4756@pendragon.ideasonboard.com>","date":"2019-02-25T19:43:24","subject":"Re: [libcamera-devel] [PATCH v2 1/4] libcamera: pipeline_handler:\n\textend documentation for configureStreams()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Sun, Feb 24, 2019 at 06:36:58PM +0100, Niklas Söderlund wrote:\n> Extend the documentation to explicitly state that the pipeline handler\n> implementations are responsible for validating that the requested\n> configuration can be exactly satisfied by the hardware.\n> \n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline_handler.cpp | 8 ++++++++\n> 1 file changed, 8 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index 616838fed702fec7..dad0a2964486c5d4 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -136,6 +136,14 @@ PipelineHandler::~PipelineHandler()\n> * is the Camera class which will receive configuration to apply from the\n> * application.\n> *\n> + * Each pipeline handler implementation is responsible for validating\n> + * that the configuration requested in \\a config can be achieved\n> + * exactly. Any difference in pixel format, frame size or any other\n> + * parameter shall result in the -EINVAL error being returned, and no\n> + * change in configuration being applied to the pipeline. If\n> + * configuration of a subset of the streams can't be satisfied, the\n> + * whole configuration is considered invalid.\n> + *\n> * \\return 0 on success or a negative error code on error.\n> */\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1ED01610B6\n\tfor ;\n\tMon, 25 Feb 2019 20:43:35 +0100 (CET)","from pendragon.ideasonboard.com (unknown [83.145.195.18])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7F41167;\n\tMon, 25 Feb 2019 20:43:34 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1551123814;\n\tbh=1vNrrIxtucahhW25tJbfr7MGQ/z0jVzjen0OeuQX5f0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=lNwN3t2HlzuMHrBjuG0zijkpgXQf/DMbLxTL/tJV+XlMFdXrlFtWaLuCauWh4wQEt\n\tgWBVJW+dyCyWTRhaiGNL2mZHkluWkXyu+HkmOIr1J6/JqUBqlxTGLaPNvqG2oTfteY\n\tM1NFgfcoHaWK8997kx4qrCNk7jQZxRFbioCJkVDU=","Date":"Mon, 25 Feb 2019 21:43:24 +0200","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190225194324.GC4756@pendragon.ideasonboard.com>","References":"<20190224173701.8587-1-niklas.soderlund@ragnatech.se>\n\t<20190224173701.8587-2-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190224173701.8587-2-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 1/4] libcamera: pipeline_handler:\n\textend documentation for configureStreams()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 25 Feb 2019 19:43:35 -0000"}}]