[{"id":875,"web_url":"https://patchwork.libcamera.org/comment/875/","msgid":"<20190225194201.GB4756@pendragon.ideasonboard.com>","date":"2019-02-25T19:42:01","subject":"Re: [libcamera-devel] [PATCH v2 4/4] cam: Improve when usage\n\tinformation is printed","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Sun, Feb 24, 2019 at 06:14:07PM +0100, Niklas Söderlund wrote:\n> Running the cam tool without any options results in the tool to exit\n> with EXIT_FAILURE but no usage being printed, this is confusing. Improve\n> this by also printing the usage text.\n> \n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/cam/main.cpp | 9 +++------\n> 1 file changed, 3 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n> index 522d2f0d3373dc25..90859fe04abfb944 100644\n> --- a/src/cam/main.cpp\n> +++ b/src/cam/main.cpp\n> @@ -67,12 +67,9 @@ static int parseOptions(int argc, char *argv[])\n> \tparser.addOption(OptList, OptionNone, \"List all cameras\", \"list\");\n> \n> \toptions = parser.parse(argc, argv);\n> -\tif (!options.valid())\n> -\t\treturn -EINVAL;\n> -\n> -\tif (argc == 1 || options.isSet(OptHelp)) {\n> +\tif (!options.valid() || options.isSet(OptHelp)) {\n> \t\tparser.usage();\n> -\t\treturn 1;\n> +\t\treturn !options.valid() ? -EINVAL : -EINTR;\n> \t}\n> \n> \treturn 0;\n> @@ -207,7 +204,7 @@ int main(int argc, char **argv)\n> \n> \tret = parseOptions(argc, argv);\n> \tif (ret < 0)\n> -\t\treturn EXIT_FAILURE;\n> +\t\treturn ret == -EINTR ? 0 : EXIT_FAILURE;\n> \n> \tCameraManager *cm = CameraManager::instance();\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 76D2D610B6\n\tfor ;\n\tMon, 25 Feb 2019 20:42:12 +0100 (CET)","from pendragon.ideasonboard.com (unknown [83.145.195.18])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A50B667;\n\tMon, 25 Feb 2019 20:42:11 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1551123732;\n\tbh=KyPSYUXt2fNAjBgYoLxW7+LqTIrQ3OYeClBYYzks71o=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=f1QlJF5eFImRQ3UCkHKO3c/pJAwwxonGnzutOmQ/uR8guwdbf2TzypSZM04Mg0+W3\n\tG0g5ag3AdbZ62KjQNa2IaJLgp5MlWvrpj84SY88M7P1356JvwLBOjl5OxX94v50eT3\n\tvUC/NVBkVvEzxQs8GiQOvtiICQ2PHknaEWxa7q/M=","Date":"Mon, 25 Feb 2019 21:42:01 +0200","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190225194201.GB4756@pendragon.ideasonboard.com>","References":"<20190224171407.7856-1-niklas.soderlund@ragnatech.se>\n\t<20190224171407.7856-5-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190224171407.7856-5-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 4/4] cam: Improve when usage\n\tinformation is printed","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 25 Feb 2019 19:42:12 -0000"}}]